From: Ross Burton Date: Thu, 14 Oct 2021 16:33:19 +0000 (+0100) Subject: sstate: don't silently handle all exceptions in sstate_checkhashes X-Git-Tag: uninative-3.5~1191 X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=50d99faf88a1d82cbd939b9bd6e33ebed2b1ffd8;p=openembedded-core.git sstate: don't silently handle all exceptions in sstate_checkhashes If checkstatus returns an exception we should silently handle FetchError, as this means the fetch failed for 'normal' reasons such as file not found. However, other exceptions may be raised, and these should be made visible. Signed-off-by: Ross Burton Signed-off-by: Richard Purdie --- diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass index 7f034d746a..3c179259e7 100644 --- a/meta/classes/sstate.bbclass +++ b/meta/classes/sstate.bbclass @@ -995,10 +995,11 @@ def sstate_checkhashes(sq_data, d, siginfo=False, currentcount=0, summary=True, foundNet.add(tid) if tid in missed: missed.remove(tid) - except: + except bb.fetch2.FetchError as e: missed.add(tid) - bb.debug(2, "SState: Unsuccessful fetch test for %s" % srcuri) - pass + bb.debug(2, "SState: Unsuccessful fetch test for %s (%s)" % (srcuri, e)) + except Exception as e: + bb.error("SState: cannot test %s: %s" % (srcuri, e)) if len(tasklist) >= min_tasks: bb.event.fire(bb.event.ProcessProgress(msg, len(tasklist) - thread_worker.tasks.qsize()), d)