From: Richard Röjfors Date: Sun, 30 Jul 2017 09:12:56 +0000 (+0200) Subject: package_manager: Fix support for NO_RECOMMENDATONS X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=5f9ea84d304a519acb0504516b86f2683a43f9e9;p=openembedded-core.git package_manager: Fix support for NO_RECOMMENDATONS When support for dnf was introduced the check of the no NO_RECOMMENDATIONS variable got broken. This fixes the issue by compairing to the string "1" rather than the number 1. Signed-off-by: Richard Röjfors Signed-off-by: Ross Burton (cherry picked from commit 1849ce3bd7c0af055f3e849a6508e746b6a0dca5) Signed-off-by: Armin Kuster --- diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py index 93d079d73d..28c6b2aec2 100644 --- a/meta/lib/oe/package_manager.py +++ b/meta/lib/oe/package_manager.py @@ -585,7 +585,7 @@ class RpmPM(PackageManager): output = self._invoke_dnf((["--skip-broken"] if attempt_only else []) + (["-x", ",".join(exclude_pkgs)] if len(exclude_pkgs) > 0 else []) + - (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == 1 else []) + + (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == "1" else []) + (["--nogpgcheck"] if self.d.getVar('RPM_SIGN_PACKAGES') != '1' else ["--setopt=gpgcheck=True"]) + ["install"] + pkgs)