From: Ross Burton <ross@burtonini.com>
Date: Wed, 2 Sep 2020 10:41:53 +0000 (+0100)
Subject: insane: improve gnu-hash-style warning
X-Git-Tag: 2020-04.3-dunfell~38
X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=60b474320e2dd36bff9f0ef5f1dc491cbe734919;p=openembedded-core.git

insane: improve gnu-hash-style warning

Instead of showing a filename under packages-split, show the package
name and filename inside the package.

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 4f78fc65bb0c9bff05651d9e543bab3d75998f79)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
---

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 12ae44d4d1..c595080bdf 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -442,7 +442,8 @@ def package_qa_hash_style(path, name, d, elf, messages):
         if ("[mips32]" in line or "[mips64]" in line) and d.getVar('TCLIBC') == "musl":
             sane = True
     if has_syms and not sane:
-        package_qa_add_message(messages, "ldflags", "No GNU_HASH in the ELF binary %s, didn't pass LDFLAGS?" % path)
+        path = package_qa_clean_path(path, d, name)
+        package_qa_add_message(messages, "ldflags", "File %s in package %s doesn't have GNU_HASH (didn't pass LDFLAGS?)" % (path, name))
 
 
 QAPATHTEST[buildpaths] = "package_qa_check_buildpaths"