From: Peter Seebach Date: Mon, 14 May 2012 22:49:23 +0000 (-0500) Subject: runqemu: replace bashism with working shell idiom X-Git-Tag: 2015-4~10653 X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=716ae8dbd1fb29292c9fca0f59d3807a54508e87;p=openembedded-core.git runqemu: replace bashism with working shell idiom The =~ operator is not one of my favorites, not just due to portability issues, but because it's not well known, and a lot of people might not expect a regex operator. The canonical shell idiom for this is to use case with alternation and wildcards. As a side note, if you are matching anything containing core-image-sato, you don't need to also check for core-image-sato-sdk. Signed-off-by: Peter Seebach Signed-off-by: Richard Purdie --- diff --git a/scripts/runqemu b/scripts/runqemu index 305e46aebf..fc7363fdd8 100755 --- a/scripts/runqemu +++ b/scripts/runqemu @@ -300,14 +300,15 @@ findimage() { # recently created one is the one we most likely want to boot. filenames=`ls -t $where/*-image*$machine.$extension 2>/dev/null | xargs` for name in $filenames; do - if [ "$name" =~ core-image-sato-sdk -o \ - "$name" =~ core-image-sato -o \ - "$name" =~ core-image-lsb -o \ - "$name" =~ core-image-basic -o \ - "$name" =~ core-image-minimal ]; then + case $name in + *core-image-sato* | \ + *core-image-lsb* | \ + *core-image-basic* | \ + *core-image-minimal* ) ROOTFS=$name return - fi + ;; + esac done echo "Couldn't find a $machine rootfs image in $where."