From: Richard Purdie <richard.purdie@linuxfoundation.org>
Date: Tue, 28 Apr 2015 16:09:58 +0000 (+0100)
Subject: lib/oe/package: Improve strip subprocess handling
X-Git-Tag: 2015-10~2020
X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=85e8fb1c7a3baac5633ecdfb36113aec7f4235cb;p=openembedded-core.git

lib/oe/package: Improve strip subprocess handling

Currently if the strip process fails, we get a message but don't know why. This adds
code to show the return value and any error output.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/meta/lib/oe/package.py b/meta/lib/oe/package.py
index 8bc56c6e88..947a97785a 100644
--- a/meta/lib/oe/package.py
+++ b/meta/lib/oe/package.py
@@ -34,14 +34,14 @@ def runstrip(arg):
     stripcmd = "'%s' %s '%s' -o '%s.tmp' && chown --reference='%s' '%s.tmp' && mv '%s.tmp' '%s'" % (strip, extraflags, file, file, file, file, file, file)
     bb.debug(1, "runstrip: %s" % stripcmd)
 
-    ret = subprocess.call(stripcmd, shell=True)
+    try:
+        output = subprocess.check_output(stripcmd, stderr=subprocess.STDOUT, shell=True)
+    except subprocess.CalledProcessError as e:
+        bb.error("runstrip: '%s' strip command failed with %s (%s)" % (stripcmd, e.returncode, e.output))
 
     if newmode:
         os.chmod(file, origmode)
 
-    if ret:
-        bb.error("runstrip: '%s' strip command failed" % stripcmd)
-
     return