From: Phil Blundell Date: Mon, 15 Oct 2012 10:28:00 +0000 (+0100) Subject: insane: Don't try to run objdump on symlinks X-Git-Tag: 2015-4~8844 X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=91769af1c1175ac9bb43d16d05fb1c8736dd9287;p=openembedded-core.git insane: Don't try to run objdump on symlinks If the link is absolute then we might end up reading from a host binary or a nonexistent path, neither of which will produce useful results and may result in objdump failure and python backtrace spew. If the link does point to a binary within the installation root then we will scan the pointed-to file at some point anyway so there is no need to do it again. Signed-off-by: Phil Blundell Signed-off-by: Richard Purdie --- diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 2b4841933c..71a9a588c3 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -157,6 +157,9 @@ def package_qa_check_rpath(file,name, d, elf, messages): if not elf: return + if os.path.islink(file): + return + bad_dirs = [d.getVar('TMPDIR', True) + "/work", d.getVar('STAGING_DIR_TARGET', True)] bad_dir_test = d.getVar('TMPDIR', True) @@ -186,6 +189,9 @@ def package_qa_check_useless_rpaths(file, name, d, elf, messages): if not elf: return + if os.path.islink(file): + return + libdir = d.getVar("libdir", True) base_libdir = d.getVar("base_libdir", True)