From: Ross Burton Date: Mon, 14 Oct 2019 11:42:57 +0000 (+0100) Subject: sanity: check the format of SDK_VENDOR X-Git-Tag: 2019-10.1-zeus~94 X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=95d3ca54453cdb0662fae2a2cf7e8173611c86f4;p=openembedded-core.git sanity: check the format of SDK_VENDOR If SDK_VENDOR isn't formatted as -foosdk and is instead for example -foo-sdk then the triple that are constructed are not in fact triples, which results in mysterious compile errors. Check in sanity.bbclass so this failure is detected early. [ YOCTO #13573 ] Signed-off-by: Ross Burton Signed-off-by: Richard Purdie (cherry picked from commit b0efd8d4d0dbc30e6505b42f5603f18fa764d732) Signed-off-by: Armin Kuster --- diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass index 2d3f49eb1a..705062bc86 100644 --- a/meta/classes/sanity.bbclass +++ b/meta/classes/sanity.bbclass @@ -798,6 +798,11 @@ def check_sanity_everybuild(status, d): elif d.getVar('SDK_ARCH', False) == "${BUILD_ARCH}": status.addresult('SDKMACHINE is set, but SDK_ARCH has not been changed as a result - SDKMACHINE may have been set too late (e.g. in the distro configuration)\n') + # If SDK_VENDOR looks like "-my-sdk" then the triples are badly formed so fail early + sdkvendor = d.getVar("SDK_VENDOR") + if not (sdkvendor.startswith("-") and sdkvendor.count("-") == 1): + status.addresult("SDK_VENDOR should be of the form '-foosdk' with a single dash\n") + check_supported_distro(d) omask = os.umask(0o022)