From: Sumit Garg <sumit.garg@linaro.org>
Date: Tue, 1 Sep 2020 12:59:23 +0000 (+0530)
Subject: insane: fix gnu-hash-style check
X-Git-Tag: 2020-10-gatesgarth~335
X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=996010f1b9ca98592e2c87e1adcb0c79b86517b7;p=openembedded-core.git

insane: fix gnu-hash-style check

Fix gnu-hash-style check that always returned True after commit [1]
leading to false positive presence of "GNU_HASH" in objdump output.

Fixes: 9ff90bf04a4c ("mips: Enable gnu-hash-style on glibc") [1]
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index ee19ef673e..c32bf25124 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -438,7 +438,7 @@ def package_qa_hash_style(path, name, d, elf, messages):
     for line in phdrs.split("\n"):
         if "SYMTAB" in line:
             has_syms = True
-        if "GNU_HASH" or "DT_MIPS_XHASH" in line:
+        if "GNU_HASH" in line or "DT_MIPS_XHASH" in line:
             sane = True
         if ("[mips32]" in line or "[mips64]" in line) and d.getVar('TCLIBC') == "musl":
             sane = True