From: Mark Hatle Date: Tue, 19 Jul 2016 07:42:32 +0000 (+0800) Subject: package_manager.py: Avoid installing an empty package list X-Git-Tag: uninative-1.3~231 X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=9ae6a2830dacb3c335754a6da91bd5cc30546b31;p=openembedded-core.git package_manager.py: Avoid installing an empty package list It is possible in an attempt only install, that everything listed is not available to be installed. This will have the effect of clearing the package list. However, we only check for an empty package list at the beginning of the function. We need to also check before running the install, otherwise we can fail due to 'error: no package(s) given". Signed-off-by: Mark Hatle Signed-off-by: Mingli Yu Signed-off-by: Ross Burton Signed-off-by: Richard Purdie --- diff --git a/meta/lib/oe/package_manager.py b/meta/lib/oe/package_manager.py index 2004a42a01..47f6831f98 100644 --- a/meta/lib/oe/package_manager.py +++ b/meta/lib/oe/package_manager.py @@ -1186,6 +1186,9 @@ class RpmPM(PackageManager): new_depends[new_depend] = deps[depend] pkgs = bb.utils.join_deps(new_depends, commasep=True).split(', ') pkgs = self._pkg_translate_oe_to_smart(pkgs, attempt_only) + if not pkgs: + bb.note("There are no packages to install") + return if not attempt_only: bb.note('to be installed: %s' % ' '.join(pkgs)) cmd = "%s %s install -y %s" % \