From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
Date: Tue, 4 Dec 2012 10:40:59 +0000 (+0500)
Subject: qa.py: Toolchain path should not be hardcoded to execute objdump
X-Git-Tag: 2015-4~8425
X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=a3a0e29d5d796fdf6755503cc31e45199b79d756;p=openembedded-core.git

qa.py: Toolchain path should not be hardcoded to execute objdump

Currently objdump command is invoked from the STAGING_BINDIR_TOOLCHAIN
directory. In case of external toolchain if this directory doesn't
exist then objdump fails to execute. Instead of hardcoding the path
it should search PATH to find it.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---

diff --git a/meta/lib/oe/qa.py b/meta/lib/oe/qa.py
index 2c51141515..d9848c8e4a 100644
--- a/meta/lib/oe/qa.py
+++ b/meta/lib/oe/qa.py
@@ -97,14 +97,14 @@ class ELFFile:
             return self.objdump_output[cmd]
 
         objdump = d.getVar('OBJDUMP', True)
-        staging_dir = d.getVar('STAGING_BINDIR_TOOLCHAIN', True)
 
         env = os.environ.copy()
         env["LC_ALL"] = "C"
+        env["PATH"] = d.getVar('PATH', True)
 
         try:
             bb.note("%s %s %s" % (objdump, cmd, self.name))
-            self.objdump_output[cmd] = bb.process.run([ os.path.join(staging_dir, objdump), cmd, self.name ], env=env, shell=False)[0]
+            self.objdump_output[cmd] = bb.process.run([objdump, cmd, self.name], env=env, shell=False)[0]
             return self.objdump_output[cmd]
         except Exception, e:
             bb.note("%s %s %s failed: %s" % (objdump, cmd, self.name, e))