From: Joshua Lock <josh@linux.intel.com>
Date: Thu, 11 Nov 2010 10:14:11 +0000 (+0000)
Subject: bitbake/crumbs: do the test for ignored messages sooner
X-Git-Tag: 2011-1~3594
X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=bd8ff30da075357727ae3c200c31ccbea62bf56a;p=openembedded-core.git

bitbake/crumbs: do the test for ignored messages sooner

Move the test for ignored messages to the start of the message handling loop to
avoid doing work for messages which are only going to be ignored.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
---

diff --git a/bitbake/lib/bb/ui/crumbs/runningbuild.py b/bitbake/lib/bb/ui/crumbs/runningbuild.py
index 6f77b83c69..711697cecb 100644
--- a/bitbake/lib/bb/ui/crumbs/runningbuild.py
+++ b/bitbake/lib/bb/ui/crumbs/runningbuild.py
@@ -68,6 +68,9 @@ class RunningBuild (gobject.GObject):
                 parent = self.tasks_to_iter[(package, task)]
 
         if isinstance(event, bb.msg.MsgBase):
+            # Ignore the "Running task i of n .."
+            if (event._message.startswith ("Running task")):
+                return # don't add these to the list
 
             # Set a pretty icon for the message based on it's type.
             if isinstance(event, bb.msg.MsgWarn):
@@ -77,10 +80,6 @@ class RunningBuild (gobject.GObject):
             else:
                 icon = None
 
-            # Ignore the "Running task i of n .." messages
-            if (event._message.startswith ("Running task")):
-                return
-
             # Add the message to the tree either at the top level if parent is
             # None otherwise as a descendent of a task.
             self.model.append (parent,