From: Patrick Ohly Date: Fri, 23 Jan 2015 14:48:17 +0000 (-0800) Subject: binconfig-disabled: try harder to prevent usage of config scripts X-Git-Tag: 2015-4~630 X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=d1ff61a16a3fcfdd7cf882bc89fb1d164cb1603a;p=openembedded-core.git binconfig-disabled: try harder to prevent usage of config scripts Returning a non-zero exit code is not enough to cause errors when configure scripts call the patched config scripts: for example, swig's configure script uses PCRE_LIBS=`$PCRE_CONFIG --libs` and does not abort on errors. Using empty output may then succeed, for example when the required library is available indirectly. Returning some nonsense command line arguments covers such cases, because using them will definitely lead to errors during compilation. The faked arguments were chosen such that these errors can be linked back to the root cause. Signed-off-by: Patrick Ohly Signed-off-by: Ross Burton --- diff --git a/meta/classes/binconfig-disabled.bbclass b/meta/classes/binconfig-disabled.bbclass index 27f904eb42..4c42ae22e4 100644 --- a/meta/classes/binconfig-disabled.bbclass +++ b/meta/classes/binconfig-disabled.bbclass @@ -10,6 +10,9 @@ FILES_${PN}-dev += "${bindir}/*-config" do_install_append () { for x in ${BINCONFIG}; do echo "#!/bin/sh" > ${D}$x + # Make the disabled script emit invalid parameters for those configure + # scripts which call it without checking the return code. + echo "echo '--should-not-have-used-$x'" > ${D}$x echo "exit 1" >> ${D}$x done }