Ian Ray [Wed, 30 Sep 2015 10:03:38 +0000 (13:03 +0300)]
ptest: run-ptest not required to run do_install_ptest
Modify do_install_ptest_base to run do_install_ptest and install the
Makefile irrespective of the presence of ${WORKDIR}/run-ptest. This
change allows "ptest-aware" packages to install run-ptest as part of
the make machinery.
Signed-off-by: Ian Ray <ian.ray@ge.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
distrodata: Take account proxies on distrodata tasks
Proxies defined in the enviroment where not taken into account
on the distrodata tasks. This commit implied passing the datastore
into the distro_check library and context manager for the
urllib.urlopen function.
One way to run distrodata tasks is using 'universe' as target and the
'all' distrodata task:
Richard Purdie [Wed, 30 Sep 2015 22:31:44 +0000 (23:31 +0100)]
oeqa/selftest/wic: Use SetupLocal instead of Setup
If we replace the code Setup method, we don't get the cleanup it performs
and this just resulted in failures on the autobuilder due to a stale
config fragment. Setup will call SetupLocal so this should be a safe
and easy fix to resolve the auobuilder failures.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Kevin Hao [Wed, 30 Sep 2015 02:29:33 +0000 (10:29 +0800)]
kernel.bbclass: fix the bug of checking the existing sections in do_strip()
Ross reported the following waring when building edgerouter BSP:
WARNING: Section not found: .comment
The reason is that the testing of the existing sections in do_strip()
returned the wrong value. Please see the following code in do_strip():
for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do {
if [ "$headers" != *"$str"* ]; then
bbwarn "Section not found: $str";
fi
The "*" doesn't have special meaning in the if string test, so it will
return true even the $str is a substring of $headers. Fix this issue
by replacing it with "! (echo "$headers" | grep -q "^$str$")".
Reported-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Kevin Hao <kexin.hao@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
runqemu-internal: qemuarm enable usage of virtio devices
We are experiencing occasional segfaults in scsi sym53c8xx driver
on qemuarm boot. There are some old discussions into the mailing
lists [1] about the scsi problem and seems to be isn't fixed.
We use virtio blk/net devices into qemuarm64 also are supported
into qemuarm so change to use it because virtio devices are the best
choice.
Richard Purdie [Wed, 30 Sep 2015 13:54:35 +0000 (14:54 +0100)]
distutils3: Avoid MACHINE specific checksums
The MACHINE variable is used to handle sysroot paths within one of the
patches to python3-native. In this context, it is relocation safe and
the resulting packages should not have MACHINE specific checksums,
therefore excluding MACHINE in this context is safe.
This whole setup is ugly and ideally we should come up with a better
way of handling this but at least allow a stop gap solution for now.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 30 Sep 2015 13:53:51 +0000 (14:53 +0100)]
gstreamer-omx: Improve variable expansion of ${S}
The way ${S} is expanded into CFLAGS means the recipe is marked as depending
on the path within which its built. We can avoid this by avoiding the expansion
which then allows reuse of the recipe from sstate.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 30 Sep 2015 13:52:49 +0000 (14:52 +0100)]
bitbake.conf: Exclude sstate-outputdirs flag from checksums
This was making deploy tasks MACHINE specific since they place output
into DEPLOY_DIR_IMAGE which contains MACHINE. On the plus side, this
was accidentally ensuring the output was placed for each machine,
on the downside it was triggering a rebuild every time for the different
checksum.
There is a better way to handle this which avoids the rebuild, see
the following tweak to do_deploy to mark it as MACHINE specific
in a different way.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 30 Sep 2015 13:52:20 +0000 (14:52 +0100)]
deploy: Mark deploy tasks as MACHINE specific
This adds the markup to inform bitbake to rerun the deploy task per MACHINE.
This makes sense since DEPLOY_DIR_IMAGE contains MACHINE. Doing it this
way means the same artefact will be reused from sstate rather than rebuilt.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 30 Sep 2015 13:51:53 +0000 (14:51 +0100)]
layer.conf: Add SIGGEN exclusion for oprofile kernel dependency
The oprofile kernel dependency is a simple RRECOMMENDS, it therefore
doesn't have any interface constraints and doesn't need to rebuild
every time the kernel changes.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 30 Sep 2015 13:51:25 +0000 (14:51 +0100)]
layer.conf: Improve siggen exclusion to handle virtual/libc
Now the system supports virtual/xxx in SIGGEN_ variables, convert
this one to use virtual/libc instead of the hardcoded expansion which
is error prone.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 30 Sep 2015 13:50:42 +0000 (14:50 +0100)]
multilib_global: Add handling of SIGGEN variables for multilib
multilib task signatures turned out to have issues since
SIGGEN_EXCLUDERECIPES_ABISAFE and SIGGEN_EXCLUDE_SAFE_RECIPE_DEP
did not have multilib mappings. This adds those mappings in which
in turn improves multilib task checksums to match the standard
non-mulitlib versions.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 30 Sep 2015 13:50:00 +0000 (14:50 +0100)]
lib/oe/sstate: Add tasks_resolved handler for virtual/xxx mappings
In SIGGEN_EXCLUDERECIPES_ABISAFE and SIGGEN_EXCLUDE_SAFE_RECIPE_DEP
we really need to be able to use virtual/xxx namespaces but this
currently doesn't work.
To make this work, we need to translate them into the resolved
providers. After such a hook was added to bitbake, we can add
this translation here.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 30 Sep 2015 13:49:23 +0000 (14:49 +0100)]
oeqa/selftest/sstatetests: Add test that MACHINE doesn't change target sigs
When we change between two machines with the same tune, we shouldn't see
rebuilds of binaries. This adds a test for this using the qemux86copy
machine. We also extend the test to cover multilibs.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 30 Sep 2015 13:47:13 +0000 (14:47 +0100)]
meta-selftest: Add qemux86copy machine
I know Martin finds something like this useful for testing sstate signatures,
this adds one to meta-selftest so we can use it from oe-selftest in the sstate
tests there too.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Changing SDKMACHINE (which changes SDK_ARCH) shouldn't cause
target task signatures to change. Exclude the dependency
on SDK_ARCH for this reason. It only affects nativesdk builds
and those already account for SDK_ARCH in the build WORKDIR paths.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Bruce Ashfield [Tue, 29 Sep 2015 14:31:35 +0000 (10:31 -0400)]
kern-tools: fix multi-layer patch application
Updating the kern-tools SRCREV to import the following fix:
kgit-meta: resume after last applied patch
When the auto-resume (resume point detection) was removed from the
processing of a meta-series, it ignored the fact that a single patch
series may in fact be processed a number of times.
Two layers patching a kernel will generate two different runs on the
same branch, which always start at patch one. This will obviously
break with duplicate patches.
To avoid this, we simply track the last patch applied, and
explicitly
tell the patch scripts where to start. This gets us resume
functionality, without the overhead of resume point detection.
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Bruce Ashfield [Tue, 29 Sep 2015 14:31:34 +0000 (10:31 -0400)]
linux-yocto/4.1: braswell bug fixes
Updating the 4.1 SRCREVs to integrate the following DRM backports:
a8abc111a96d drm/i915: Only wait for required lanes in vlv_wait_port_ready() 81354180432b Revert "drm/i915: Hack to tie both common lanes together on chv" d660fc117731 drm/i915: Work around DISPLAY_PHY_CONTROL register corruption on CHV 0e797e9cb717 drm/i915: Implement chv display PHY lane stagger setup
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Bruce Ashfield [Tue, 29 Sep 2015 14:31:32 +0000 (10:31 -0400)]
linux-yocto-rt/4.1: integrate axxia BSP
As part of the axxia preempt-rt integration, the preempt-rt
branch now becomes standard/preempt-rt/base, to allow proper
branch inheritance as: standard/preempt-rt/axxia/base.
No functional changes happen to the base -rt, just the default
KBRANCH changes.
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gettext-0.16.1: kill target m4 macros from sysroot
This is aim for using gettext-native's macros(gettext-native-0.19.4),
but when we set:
PREFERRED_VERSION_gettext = "0.16.1"
And build the recipes like pcmanfm, we would get errors when
do_configure:
Khem Raj [Mon, 31 Aug 2015 06:15:34 +0000 (06:15 +0000)]
hostap-utils: Use C99 stddefs in defining local typedefs
The code is creating more abstract types which is nice however it should
be using standard defines from stdint.h and not random defines to base
its own type system
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Update the NAME version tweak example patch for the
newer kernel. This moves the example to the 4.2 stable
kernel and appends -custom to the VERSION string.
Signed-off-by: Saul Wold <sgw@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Currently the logic to check if a test failed was
to check for an exception in the thread, but some
decorators used in the syslog runtime test would
generate and handle exceptions; this will mess
with the current check logic and will dump the
host and the target as if the test failed.
This patch changes the check logic to verify if
the test that just happend is in the failure test
list and dump the host and target accordingly.
[YOCTO #8406]
Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
CWAUTOMACROSPREFIX is ${D}${prefix} which is used as the prefix
of install dir and used to replace the path placeholder in script
autogen.sh, the former is correct but not for the later, we can
fix the Makefile to use two variables for this, but I think a sed
replacement would be fine since the package has not been in
development for a long time.
Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
oeqa/runexported: Fix a problem with ssh_target_log existing in folder.
When copying the exported tests to a remote machine ssh_target_log can
be transformed from softlink to file which will throw an error when
trying to run again.
Signed-off-by: Lucian Musat <george.l.musat@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
qemurunner: Sanitize output from qemu and qemu pid
Currently the output from qemu could contain control
or Unicode characters; having such characters in the
log will cause an internal server error when sending
the report to error reporting web. Control characters
can be found in the command line used to run quemu too.
This change sanitize the output from qemu and the
command line used to run qemu, this way the logs doesn't
contain control or Unicode characters and this will solve
the issue of error reporting web and generate better
logs.
The only Unicode character found in the qemu output
is the copyright symbol, it really doesn't interfer
removing Unicode characters with debugging.
[YOCTO #8225]
Signed-off-by: Mariano Lopez <mariano.lopez@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Robert Yang [Mon, 28 Sep 2015 08:18:42 +0000 (01:18 -0700)]
python-async: inherit setuptools
Fixed when bitbake nativesdk-python-async:
DEBUG: Executing shell function do_compile
Traceback (most recent call last):
File "setup.py", line 2, in <module>
from setuptools import setup
ImportError: No module named setuptools
Replace distutils with setuptools will fix the problem.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
util-linux: add runuser PAM config files to fix runuser error
The runuser command fails with below error message, add proper PAM
config files to fix the problem. The config files are borrowed from
CentOS 7.0 release.
runuser: Failure setting user credentials
Signed-off-by: Shan Hai <shan.hai@windriver.com> Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
oeqa/decorators: Fixed a problem with decorator logs link.
When not doing actual tests with testimage, like for example
exporting tests, the link to the log file was still created
although the actual log file was not existent. Fixed it by
moving the link creation part into the run() method.
Signed-off-by: Lucian Musat <george.l.musat@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Tue, 29 Sep 2015 12:43:45 +0000 (13:43 +0100)]
toolchain-shar-extract: Correct environment-setup script names for multilib
Currently a lib32-core-image-* SDK prints an incorrect environment-setup-*
file name when installing the SDK. Instead of printing the wrong thing, list
the environment setup files present in the SDK.
As it happens this fixes the message printed with buildtools-tarball too
which someone reported to me about the same time as I finished this patch!
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Alex Franco [Fri, 25 Sep 2015 21:03:05 +0000 (16:03 -0500)]
lsb: add lsbinitscripts and util-linux rdepends
Building a base image such as core-image-minimal with lsb and then
attempting to source /lib/lsb/init-functions, then using the start
_daemon function (to start a daemon, such as syslogd) fails, since
/lib/lsb/init-functions use functions (incl. "daemon()") from file
/etc/init.d/functions.lsbinitscripts, which is provided by package
lsbinitscripts.
Running daemon() then calls /usr/bin/mountpoint, which is provided
by util-linux.
So, lsbinitscripts has been added as an RDEPENDency in lsb, and in
turn util-linux has been added to lsbinitscripts.
[YOCTO #7732]
Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Jonathan Liu [Fri, 25 Sep 2015 23:35:21 +0000 (09:35 +1000)]
opkg: create opkg.lock in /run instead of /var/run
This avoids a "Could not unlink" warning when extracting a /var/run
symbolic link pointing to /run from the base-files package as it is
unable to unlink the /var/run directory when it contains opkg.lock.
This also fixes an issue where /var/run is created as a directory
instead of a symbolic link to /run.
Signed-off-by: Jonathan Liu <net147@gmail.com> Acked-by: Anders Darander <anders@chargestorm.se> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Robert Yang [Mon, 28 Sep 2015 06:58:37 +0000 (23:58 -0700)]
toolchain-shar-relocate.sh: make it faster
Make the extrating faster by:
* Merge the two heavy "for .. find" loops into one
* Move the commands out of for loop rather than inside, this can reduce the
forking amount.
As a result, when install:
* buildtools-nativesdk-standalone: 14s -> 7s (50% saved)
* core-image-minimal-core2-64-toolchain: 56s -> 47s (17% saved)
[YOCTO #8404]
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Mon, 28 Sep 2015 10:56:15 +0000 (11:56 +0100)]
populate_sdk_base: Simplify postprocess commands
When looking at and trying to build a slightly customised SDK, I
realised the code could be simplified and written in a way which was
more customisable.
This patch moves various function calls into the SDK_POSTPROCESS_COMMAND
which was intended for this kind of use.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Mon, 28 Sep 2015 10:53:35 +0000 (11:53 +0100)]
classes/meta: Add DISTRO_FEATURES check for gtk+/gtk3+
If you currently do a DISTRO_FEATURES_remove = "x11" with OE-Core, you
see failures due to dependency problems. The work in resolving this was
partially completed a while back. This adds in the markup mainly for
gtk/gtk3+ recipes and means "bitbake world" will work successfully.
Rather than code the gtk/gtk+ specific distro features into each recipe,
a shared variable is used.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Markus Lehtonen [Tue, 21 Apr 2015 12:30:35 +0000 (15:30 +0300)]
devtool: modify: make bitbake use local files from srctree
This change makes it possible to have local files (non-remote SRC_URI
files, i.e. files that are located in the "recipe space") under the
srctree even if S!=WORKDIR. The files must be placed under the
'local-files' subdirectory.
Complements the previous patch that imports local files into srctree.
[YOCTO #7602]
Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
Markus Lehtonen [Thu, 23 Apr 2015 14:11:42 +0000 (17:11 +0300)]
devtool: better support for local source files
* extract: Copy all local source files (i.e. non-compressed/non-arcived
SRC_URI files that have file:// URI prefix) - excluding patches - to
the srctree repository. The files will be placed in a subdirectory
called 'oe-local-files'. The oe-local-files directory is not committed
to the Git repository, but, marked to be ignored by a .gitignore file.
The developer can manually add and commit the files to Git if the
changes to them need to be tracked.
Before this patch, local source files (were copied (and committed) to
the srctree repository only in some special cases (basically when
S=WORKDIR) when doing devtool-extract. For most of the packages local
files were not copied at all.
* update-recipe: This patch causes the local files to be 'synced' from
the srctree (i.e. from the 'oe-local-files' subdirectory) to the
layer. Being 'synced' means that in addition to copying modified
files over the original sources, devtool will also handle removing and
adding local source files and updating the recipe accordingly. We
don't want to create patches against the local source files but rather
update them directly. Thus, 'oe-local-file' directory is ignored in
patch generation when doing update-recipe, even if committed to Git.
This functionality is only enabled if the 'oe-local-files' directory
is present in srctree.
[YOCTO #7602]
Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
Richard Purdie [Sat, 26 Sep 2015 17:12:17 +0000 (18:12 +0100)]
gdk-pixbuf: Only apply native cleaning in normal task, not setscene
The previous fix works well for normal tasks since the ordering is always
correct and gdk-pixbuf-native comes first. Setscene ordering is reversed
so we can't rely on this there. Remove the fix in that case since
it breaks more than it solves.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
oeqa/testimage: Remove absolute path to oeqa from json
In the json file the whole datastore is serialized which contains
absolute path to the oeqa folder. This breaks the functionality
when trying to run the tests from other machines.
Signed-off-by: Lucian Musat <george.l.musat@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
Previously, the iproute2's configure script is actually run in the
do_compile stage. There's a Makefile rule 'all: Config' which makes
the configure process run to generate the Config file.
However, this makes it hard to fix the dependency problems. We need
to generate the Config file in the do_configure stage.
Add do_configure_append to separate the configure process from the
compile process.
Besides, explicitly disable ATM support for iproute2, otherwise we'll
sometimes meet errors like below when building.
ld: cannot find -latm
collect2: error: ld returned 1 exit status
Makefile:154: recipe for target 'q_atm.so' failed
make[1]: *** [q_atm.so] Error 1
Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
The ccargs obtained from get_tune_parameters may not be fully expanded,
so that the gcc_multilib_setup function can be confused, and generates
invalid MULTILIB_OPTIONS in GCC Makefile fragment, which will break the
multilib feature of target gcc.
To address problems above, this patch modifies gcc_multilib_setup
function to expand ccargs before use.
Upstream-Status: Inappropriate [configuration]
Signed-off-by: Yuanjie Huang <yuanjie.huang@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
Bruce Ashfield [Thu, 24 Sep 2015 22:17:54 +0000 (18:17 -0400)]
linux-yocto/4.1: rt update to 4.1.x-rt8
The -rt build suffered the same breakage in master as the standard
kernel builds: due to a bad git history merge, existing patches were
dropped from branches.
This meant that we were missing the -rt changes, which re-introduced
some failures with linux-yocto-rt.
With these SRCREV updates, we have the latest 4.1.x-rt and all
architectures build.
Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
busybox: Use CC instead of bare LD to be the Linker
This patch was on mailing list, another patch to make sure -r is not
passed directly but via -Wl switch is added.
This was exposed when using clang and gold linker, clang does not have
-r switch to do relocatable objects and problem happens specific to OE
becuase we use LD = CC
now what happens is that busybox assumes that linker will be called
directly, and hence sprinkles linkers options in its kbuild system which
aggregate into LDFLAGS, some of these options are happily ignored by gcc
as well but it passes -r options rightly to linker so it all works,
however when using clang, this falls apart since -r is not known option
for clang so it drops this option and all obects which should be
partially linked becomes ET_EXEC and when they are added to final link
then gold starts to get confused
/mnt/home/kraj/work/angstrom/build/tmp-angstrom-glibc/sysroots/x86_64-linux/usr/bin/arm-angstrom-linux-gnueabi/arm-angstrom-linux-gnueabi-ld:
error: applets/built-in.o: unsupported ELF file type 2
clang-3.7: error: linker command failed with exit code 1 (use -v to see invocation)
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
Ross Burton [Thu, 24 Sep 2015 08:54:33 +0000 (09:54 +0100)]
sstate: run recipe-provided hooks outside of ${B}
To avoid races between the sstate tasks/hooks using ${B} as the cwd, and other
tasks such as cmake_do_configure which deletes and re-creates ${B}, ensure that
all sstate hooks are run in the right directory, and run the prefunc/postfunc in WORKDIR.
To avoid logs being overwriten when running the automated
tests multiple times, log files include timestamps in
their names and a link is created to point to the latest one.
Signed-off-by: Lucian Musat <george.l.musat@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
Patrick Ohly [Thu, 24 Sep 2015 14:53:10 +0000 (16:53 +0200)]
image types: add hdddirect
When image-vm.bbclass was introduced, it indirectly also introduced a
".hdddirect" image type based on boot-directdisk.bbclass. However, one
could only get that image when also enabling at least one of the
virtual machine images.
The .hdddirect images are useful by themselves. By registering
image-vm.bbclass as implementation of it, it becomes possible to
select them with:
IMAGE_FSTYPES = "hdddirect"
Signed-off-by: Patrick Ohly <patrick.ohly@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
