resulttool/manualexecution: Fixed step sorted by integer
Currently the manual execution display step by sorting
the step as string, where steps were not being sorted
correctly when there are more than 9 steps.
Fixed the step sorting by sorting step as integer.
Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
resulttool/manualexecution: Enable display full steps without press enter
Current manualexecution required pressing enter button to show each step
information, where this was wasting execution time. Enable display
full steps without needing to any press enter button.
Signed-off-by: Mazliana <mazliana.mohamad@intel.com> Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Current input checking does not match the standard input practiced
by QA team. Change the input checking to match the standard
input practiced by the QA team.
Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Richard Purdie [Sat, 2 Mar 2019 16:34:16 +0000 (16:34 +0000)]
resulttool: Allow extraction of ptest data
Rather than simply discarding the ptest data, change the code to discard
it when writing out the new testresult files, or optionally either preserve
it, or write it as seperate discrete logs.
This means the autobuilder should start writing out individual ptest log
files as well as allowing ueers to extract these manually.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Richard Purdie [Tue, 2 Apr 2019 22:51:02 +0000 (23:51 +0100)]
resulttool: Allow store to work on single files
Store operations using a single file as a source weren't working as the os.walk
command didn't like being given a single file. Fix the store operation to
work for single files.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Yeoh Ee Peng [Tue, 19 Mar 2019 01:53:53 +0000 (09:53 +0800)]
oeqa/manual/toaster: updated test id naming
All test id (eg. @alias) inside manual testcase file shall follow the same
test id naming convention from oeqa automated tests (eg. selftest,
runtime, sdk, etc), where the test id consists of
<test_module>.<test_suite>.<test_function>. Furthermore, there shall be
only 1 unique test_module per each manual testcases file, where
test_module match the file name itself.
This file was using test_module name that does not match the file name
itself. Fixed test_module name as well as the test_suite name.
Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Yeoh Ee Peng [Fri, 28 Dec 2018 06:54:44 +0000 (14:54 +0800)]
oeqa/manual/toaster: transfer manual toaster test cases to oeqa
As part of the solution to replace Testopia, manual test cases
need to be migrated to OEQA. These manual test case json files
will serve two use cases.
Use case#1: as input to the future commandline-based manual test
runner script, where this script will display actions and expected
result information in user friendly text, then it will capture
user input for test result and log, finally it will write test
result and log into existing standardize test result json format
from OEQA framework for automated tests.
Use case#2: QA will open and read these json file manually for
planning manual test execution. Any reader interested in
understanding manual test cases will open and read these files.
Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
sangeeta jain [Thu, 14 Mar 2019 05:14:18 +0000 (13:14 +0800)]
oeqa/manual/kernel-dev.json: test id updated
All test id (eg. @alias) inside manual testcase file shall follow the same test id
naming convention from oeqa automated tests (eg. selftest, runtime, sdk, etc), where
the test id consists of <test_module>.<test_suite>.<test_function>. Furthermore,
there shall be only 1 unique test_module per each manual testcases file.
This file was using more than 1 unique test_module for testcases. Furthermore,
some of the testcases were defined using different test_suite where it was not needed.
This patch fix the manual testcases file to have only 1 unique test_module
as well as test_suite to simplify test id naming.
sangeeta jain [Thu, 14 Mar 2019 04:31:17 +0000 (12:31 +0800)]
oeqa/manual/compliance-test.json: test id updated and missing test cases added
Two changes made in oeqa/manual/compliance-test.json:
1. All test id (eg. @alias) inside manual testcase file shall follow the same test id
naming convention from oeqa automated tests (eg. selftest, runtime, sdk, etc), where
the test id consists of <test_module>.<test_suite>.<test_function>. Furthermore,
there shall be only 1 unique test_module per each manual testcases file.
This file was using more than 1 unique test_module for testcases. Furthermore, some of
the testcases were defined using different test_suite where it was not needed. This patch
fix the manual testcases file to have only 1 unique test_module as well as test_suite to
simplify test id naming.
2. Added 2 missing test cases for Beaglebone Stress Test.
sangeeta jain [Thu, 14 Mar 2019 02:55:23 +0000 (10:55 +0800)]
oeqa/manual/bsp-hw.json: test id updated and obsolete test cases removed
Two changes made in oeqa/manual/bsp-hw.json:
1. All test id (eg. @alias) inside manual testcase file shall follow the same test id naming
convention from oeqa automated tests (eg. selftest, runtime, sdk, etc), where the
test id consists of <test_module>.<test_suite>.<test_function>. Furthermore,
there shall be only 1 unique test_module per each manual testcases file.
This file was using more than 1 unique test_module for testcases.
Furthermore, some of the testcases were defined using different test_suite where it was not
needed. This patch fix the manual testcases file to have only 1 unique
test_module as well as test_suite to simplify test id naming.
2. As per review by Intel and Windriver team, 7 testcases were found obsolete. Removed 7 testcases.
sangeeta jain [Mon, 28 Jan 2019 08:11:15 +0000 (16:11 +0800)]
oeqa/manual/sdk.json: Updated toolchain tarball to core-image-sato
Manual test step for SDK is updated. Previously toolchain was "poky-glibc-x86_64-core-image-sato-sdk<type-arch>-toolchain-<release-version>.sh"
But toochain for core-image-sato-sdk is not available in releases after 2.1, hence changed it to "poky-glibc-x86_64-core-image-sato-<type-arch>-toolchain-<release-version>.sh
Other less significant update is to add exepcted result in intermediate test steps.
Richard Purdie [Thu, 28 Feb 2019 12:24:49 +0000 (12:24 +0000)]
scripts/wic: Be consistent about how we call bitbake
Whilst its tempting to call bitbake_main(), the script also directly executes
bitbake. By doing both this creates all kinds of races. Therefore
change to use subprocess execution in all cases.
Mazliana [Mon, 11 Mar 2019 08:30:33 +0000 (16:30 +0800)]
resulttool/manualexecution: To output right test case id
We found that manualexecution does not capture test suite values
correctly if there are more than one test suite in test cases.
After verification has made we found out we should retrieved
full test cases value <test_module.test_suite.test_case> from
oeqa/manual/ json file rather than split it them into new
variables test_suite and test_cases.
Signed-off-by: Mazliana <mazliana.mohamad@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Yeoh Ee Peng [Thu, 7 Mar 2019 04:49:08 +0000 (12:49 +0800)]
scripts/resulttool: Enable manual result store and regression
To enable store for testresults.json file from manualexecution,
add layers metadata to configuration and add "manual" map to
resultutils.store_map.
To enable regression for manual, add "manual" map to
resultutils.regression_map. Also added compulsory configurations
('MACHINE', 'IMAGE_BASENAME') to manualexecution.
Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Wed, 27 Feb 2019 17:05:29 +0000 (17:05 +0000)]
resulttool/report: Ensure test suites with no results show up on the report
ptest suites with no results don't show up on the reports even though we have
a duration for them. Fix this so the fact they report no tests is visible.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Sat, 16 Feb 2019 18:13:00 +0000 (18:13 +0000)]
resulttool: Improvements to allow integration to the autobuilder
This is a combined patch of the various tweaks and improvements I
made to resulttool:
* Avoid subprocess.run() as its a python 3.6 feature and we
have autobuilder workers with 3.5.
* Avoid python keywords as variable names
* Simplify dict accesses using .get()
* Rename resultsutils -> resultutils to match the resultstool ->
resulttool rename
* Formalised the handling of "file_name" to "TESTSERIES" which the code
will now add into the json configuration data if its not present, based
on the directory name.
* When we don't have failed test cases, print something saying so
instead of an empty table
* Tweak the table headers in the report to be more readable (reference
"Test Series" instead if file_id and ID instead of results_id)
* Improve/simplify the max string length handling
* Merge the counts and percentage data into one table in the report
since printing two reports of the same data confuses the user
* Removed the confusing header in the regression report
* Show matches, then regressions, then unmatched runs in the regression
report, also remove chatting unneeded output
* Try harder to "pair" up matching configurations to reduce noise in
the regressions report
* Abstracted the "mapping" table concept used to pairing in the
regression code to general code in resultutils
* Created multiple mappings for results analysis, results storage and
'flattening' results data in a merge
* Simplify the merge command to take a source and a destination,
letting the destination be a directory or a file, removing the need for
an output directory parameter
* Add the 'IMAGE_PKGTYPE' and 'DISTRO' config options to the regression
mappings
* Have the store command place the testresults files in a layout from
the mapping, making commits into the git repo for results storage more
useful for simple comparison purposes
* Set the oe-git-archive tag format appropriately for oeqa results
storage (and simplify the commit messages closer to their defaults)
* Fix oe-git-archive to use the commit/branch data from the results file
* Cleaned up the command option help to match other changes
* Follow the model of git branch/tag processing used by oe-build-perf-report
and use that to read the data using git show to avoid branch change
* Add ptest summary to the report command
* Update the tests to match the above changes
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Mazliana [Thu, 14 Feb 2019 05:50:38 +0000 (13:50 +0800)]
scripts/resulttool: enable manual execution and result creation
Integrated “manualexecution” operation to resulttool scripts.
Manual execution script is a helper script to execute all manual
test cases in baseline command, which consists of user guideline
steps and the expected results. The last step will ask user to
provide their input to execute result. The input options are
passed/failed/blocked/skipped status. The result given will be
written in testresults.json including log error from the user
input and configuration if there is any.The output test result
for json file is created by using OEQA library.
The configuration part is manually key-in by the user. The system
allow user to specify how many configuration they want to add and
they need to define the required configuration name and value pair.
In QA perspective, "configuration" means the test environments and
parameters used during QA setup before testing can be carry out.
Example of configurations: image used for boot up, host machine
distro used, poky configurations, etc.
The purpose of adding the configuration is to standardize the
output test result format between automation and manual execution.
To use these scripts, first source oe environment, then run the
entry point script to look for help.
$ resulttool
To execute manual test cases, execute the below
$ resulttool manualexecution <manualjsonfile>
By default testresults.json store in <build_dir>/tmp/log/manual/
[YOCTO #12651]
Signed-off-by: Mazliana <mazliana.mohamad@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Yeoh Ee Peng [Thu, 14 Feb 2019 05:50:37 +0000 (13:50 +0800)]
resulttool: enable merge, store, report and regression analysis
OEQA outputs test results into json files and these files were
archived by Autobuilder during QA releases. Example: each oe-selftest
run by Autobuilder for different host distro generate a
testresults.json file.
These scripts were developed as a test result tools to manage
these testresults.json file.
Using the "store" operation, user can store multiple testresults.json
files as well as the pre-configured directories used to hold those files.
Using the "merge" operation, user can merge multiple testresults.json
files to a target file.
Using the "report" operation, user can view the test result summary
for all available testresults.json files inside a ordinary directory
or a git repository.
Using the "regression-file" operation, user can perform regression
analysis on testresults.json files specified. Using the "regression-dir"
and "regression-git" operations, user can perform regression analysis
on directory and git accordingly.
These resulttool operations expect the testresults.json file to use
the json format below.
{
"<testresult_1>": {
"configuration": {
"<config_name_1>": "<config_value_1>",
"<config_name_2>": "<config_value_2>",
...
"<config_name_n>": "<config_value_n>",
},
"result": {
"<testcase_namespace_1>": {
"status": "<PASSED or FAILED or ERROR or SKIPPED>",
"log": "<failure or error logging>"
},
"<testcase_namespace_2>": {
"status": "<PASSED or FAILED or ERROR or SKIPPED>",
"log": "<failure or error logging>"
},
...
"<testcase_namespace_n>": {
"status": "<PASSED or FAILED or ERROR or SKIPPED>",
"log": "<failure or error logging>"
},
}
},
...
"<testresult_n>": {
"configuration": {
"<config_name_1>": "<config_value_1>",
"<config_name_2>": "<config_value_2>",
...
"<config_name_n>": "<config_value_n>",
},
"result": {
"<testcase_namespace_1>": {
"status": "<PASSED or FAILED or ERROR or SKIPPED>",
"log": "<failure or error logging>"
},
"<testcase_namespace_2>": {
"status": "<PASSED or FAILED or ERROR or SKIPPED>",
"log": "<failure or error logging>"
},
...
"<testcase_namespace_n>": {
"status": "<PASSED or FAILED or ERROR or SKIPPED>",
"log": "<failure or error logging>"
},
}
},
}
To use these scripts, first source oe environment, then run the
entry point script to look for help.
$ resulttool
To store test result from oeqa automated tests, execute the below
$ resulttool store <source_dir> <git_branch>
To merge multiple testresults.json files, execute the below
$ resulttool merge <base_result_file> <target_result_file>
To report test report, execute the below
$ resulttool report <source_dir>
To perform regression file analysis, execute the below
$ resulttool regression-file <base_result_file> <target_result_file>
To perform regression dir analysis, execute the below
$ resulttool regression-dir <base_result_dir> <target_result_dir>
To perform regression git analysis, execute the below
$ resulttool regression-git <source_dir> <base_branch> <target_branch>
[YOCTO# 13012]
[YOCTO# 12654]
Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Chen Qi [Thu, 10 Jan 2019 02:37:32 +0000 (10:37 +0800)]
target-sdk-provides-dummy: add more perl modules to avoid populate_sdk failure
When 'adduser' package, which is from meta-perl layer, is added to rootfs,
we will get do_populate_sdk failure like below.
Error:
Problem: package perl-module-cwd-5.24.4-r0.core2_64 requires perl-module-dynaloader, but none of the providers can be installed
- package perl-module-file-temp-5.24.4-r0.core2_64 requires perl-module-cwd, but none of the providers can be installed
- package perl-module-dynaloader-5.24.4-r0.core2_64 requires perl-module-config, but none of the providers can be installed
- package adduser-3.118-r0.core2_64 requires perl-module-file-temp, but none of the providers can be installed
- package target-sdk-provides-dummy-1.0-r0.sdk_provides_dummy_target conflicts with perl provided by perl-5.24.4-r0.core2_64
This is because adduser depends on some perl modules which are not
listed in target-sdk-provides-dummy.
Signed-off-by: Ming Liu <liu.ming50@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Robert Yang [Tue, 5 Mar 2019 03:30:35 +0000 (11:30 +0800)]
send-error-report: Add --no-ssl to use http protocol
The script use https protocol by default, but the error-report-web server's
https connection may not work (e.g., doesn't work with python 2.7.6), so add an
option --no-ssl to make it use http.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Richard Purdie [Thu, 21 Feb 2019 16:00:02 +0000 (16:00 +0000)]
kernel: Ensure an initramfs is added if configured
If ${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE_NAME}.cpio does not exist,
nor any of the compressed variants, nothing is copied to kernel build's
./usr directory.
The code does not fail, but silently proceeds without a bundled initramfs.
Change to fail and tell the user something is wrong.
Also, if an initramfs is found, contrary to the comments, it does not stop
at the first uncompressed/compressed cpio image found. Instead it keeps
processing all so the last is used. Fix this to behave as per the comments.
Apply patches from systemd_239-7ubuntu10.8 to fix CVE-2019-6454.
CVE-2019-6454 is an issue in which systemd (PID1) can be crashed with a
specially formed D-Bus message.
Richard Purdie [Mon, 28 Jan 2019 13:57:44 +0000 (13:57 +0000)]
systemd: Update recent CVE patches
* Added CVE tag, Upstream-Status tag and Sign-off-by tags.
* Removed the verification of the entry length in the header
* Squashed CVE-2018-16865 patches into one
* CVE-2018-16866 patch now taken from systemd-stable and includes
an additional heap buffer overflow fix.
Signed-off-by: Marcus Cooper <marcusc@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Richard Purdie [Sat, 9 Mar 2019 18:50:07 +0000 (19:50 +0100)]
target-sdk-provides-dummy: Extend to -dev and -src packages
This avoids errors when running populate_sdk under opkg:
* Problem 1/1:
* - package busybox-dev-1.30.1-r0.core2-64 requires busybox = 1.30.1-r0, but none of the providers can be installed
*
* Solution 1:
* - allow deinstallation of target-sdk-provides-dummy-1.0-r0.sdk-provides-dummy-target
* Solution 2:
* - do not ask to install a package providing busybox-dev
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 33d2cde3be4d25389cbea07064ffbc7b2f74273e) Signed-off-by: Armin Kuster <akuster808@gmail.com>
André Draszik [Thu, 7 Mar 2019 14:27:09 +0000 (16:27 +0200)]
systemd: RDEPENDS on util-linux-umount
It looks like there is an implicit dependency on util-linux'
umount - as otherwise when using busybox' umount we see a
long delay on shutdown / reboot.
openssl10: Fix mutliple include assumptions for des.h in opensslconf.h
The fix is heavily based on Khem's previous fix for bn.h/BN_LLONG breakage:
https://git.openembedded.org/openembedded-core/commit/?id=f787b0bb9b0626ddbf2ac94cb206c76716a3773d
Richard Purdie [Sun, 17 Feb 2019 22:12:40 +0000 (22:12 +0000)]
scripts/oe-git-archive: Separate out functionality to library function
This turns the core of the script into a library function. Ultimately this
will let us call that code with custom 'keywords' rather than relying
on the data parsed from bitbake metadata which can't be used when archiving
historical results.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Robert Yang [Fri, 15 Feb 2019 08:14:51 +0000 (16:14 +0800)]
runqemu: Let qemuparams override default settings
Fixed:
In meta/conf/machine/include/qemuboot-x86.inc:
QB_CPU_x86-64 = "-cpu core2duo"
$ runqemu qemux86-64 qemuparams="-cpu coreduo"
Check /proc/cpuinfo, it should use coreduo rather than core2duo since user
specifies it, but it doesn't, append qemuparams to the last can fix the
problem.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
OE-Core rev: a88bcbae850a2e6d182291d3f8e167aabdbe4842 broke the ability
to find parted as it may be in sbin which is not in PATH for some users
on some distros.
Iterate on the original patch to fix this and also fix the original problem.
William Bourque [Mon, 11 Feb 2019 20:00:48 +0000 (15:00 -0500)]
wic/engine.py: Load paths from PATH environment variable
Load self.paths from environment variable and
if it fails, fall back to hardcoded list.
This is required for users that would need to load
different e2fsprogs binaries if their system's ones
are not recent enought
scripts/lib/wic/engine: Fix cp's target path for ext* filesystems
Python subprocess' shell=True defaults to /bin/sh[1][2], which
often refers to a POSIX-compliant shell. As the -e flag is
not defined in the POSIX standard[3], some shells may
interpret "-e" as the first argument to the echo command,
causing the rest of the command line to fail.
In this particular case, "echo -e 'cd {}'" is interpreted
as "-e cd {}", which causes the first line of the command
to fail, and causing cp to always place the source file
in the filesystem's root.
Replacing "echo -e" for a printf command makes this
more portable.
This issue only affects "wic cp" for ext* filesystems.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Changqing Li [Thu, 15 Nov 2018 08:16:55 +0000 (16:16 +0800)]
checklayer: generate locked-sigs.inc under builddir
yocto-check-layer will find locked-sigs.inc under builddir,
but locked-sigs.inc is generated under current bitbake working
dir. if run yocto-check-layer outside builddir, we will met error
like "No such file or directory: *locked-sigs.inc". change to
run bitbake -S under builddir to fix this problem.
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
When comparing branches, correctly filter the revisions corresponding
to the specific branch specified.
Also use the commit numbers as a way to gauge spatially related commits
for comparision meaning comparisions for out of order build revisions
becomes meaninful.
This should improve the reporting for autobuilder generated builds.
Richard Purdie [Fri, 8 Feb 2019 13:38:22 +0000 (13:38 +0000)]
oe-build-perf-report: Allow commits from different branches
The code won't currently allow comparisions of two commits on different
branches even if the commits are specified by their hashes.
This updates the code to search two branches for any relavent commits,
hence allowing comparisions to be made. A particularly useful case is
master vs. master-next for example.
Richard Purdie [Fri, 8 Feb 2019 13:37:06 +0000 (13:37 +0000)]
oe-build-perf-report: Allow branch without hostname
Allow the branch to be set without the hostname option. Previously
if hostname wasn't set, branch would be overwritten regardless of
whether it was set or not.
Khem Raj [Tue, 5 Feb 2019 00:36:26 +0000 (16:36 -0800)]
multilib_header_wrapper.h: Use #pragma once
Avoid infinite include loops, especially with bits/wordsize.h which is
now possible with the synthesized headers since we now also synthesize
bits/wordsize.h itelf for some arches e.g. arm/aarch64
In cases where extra preprocessing tools are used such as clang-tidy
e.g. and these tools are not passed the knowledge about architecture
then case comes where we enter into header include loop for
bits/wordsize.h, since this template does explicitly include
bits/wordsize.h
To fix this emits the pragma once at beginning of file, this is better
solution than include guards, and pragma once is practically supported
on all compilers except few e.g. cray c/c++ compiler
Jan Kiszka [Tue, 29 Jan 2019 16:48:35 +0000 (17:48 +0100)]
oe-git-proxy: Avoid resolving NO_PROXY against local files
NO_PROXY may contain * elements, and if we are unlucky (or want to match
all hosts with *), we will pick up local files rather than doing the
match in match_host. Quoting helps here.
Dan Dedrick [Mon, 21 Jan 2019 20:15:27 +0000 (15:15 -0500)]
devtool: improve git repo checks before check_commits logic
The check_commits logic assumes that both devtool-base and args.branch
exist in the git repo that it is operating on. In order to prevent
errors at that point it's best to first ensure that both of these refs
actually exist. If they don't both exist then the check_commits logic
should just be skipped, as it would be if the repo wasn't originally
checked out by devtool.
Previously if a user removed the args.branch branch from their devtool
cloned repo this code would crash on adding the repo with -n. The crash
would look like this:
Traceback (most recent call last):
File "/home/ddedrick/src/poky/scripts/devtool", line 344, in <module>
ret = main()
File "/home/ddedrick/src/poky/scripts/devtool", line 331, in main
ret = args.func(args, config, basepath, workspace)
File "/home/ddedrick/src/poky/scripts/lib/devtool/standard.py", line 812, in modify
(stdout, _) = bb.process.run('git log devtool-base..%s' % branch, cwd=srctree)
File "/home/ddedrick/src/poky/bitbake/lib/bb/process.py", line 178, in run
raise ExecutionError(cmd, pipe.returncode, stdout, stderr)
bb.process.ExecutionError: Execution of 'git log devtool-base..devtool' failed with exit code 128:
fatal: ambiguous argument 'devtool-base..devtool': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Dan Dedrick [Mon, 21 Jan 2019 16:05:02 +0000 (11:05 -0500)]
devtool: remove duplicate overrides
DEVTOOL_EXTRA_OVERRIDES only needs one entry for each instance of
overrides. Previous to these changes it would find every override to
SRC_URI and add it to the list. This would duplicate instances where
SRC_URI is modified multiple times with the same override like:
SRC_URI_append_foo += "file://0001-foo.patch"
SRC_URI_append_foo += "file://0002-bar.patch"
A bbappend might also overwrite a SRC_URI override, which would also
cause multiple instances to occur.
When there are multiple instances of the same override in
DEVTOOL_EXTRA_OVERRIDES it causes devtool modify to fail when creating
override branches. The failure occurs when attempting to create the same
override branch a second time and looks like this:
The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_python_func() autogenerated', lineno: 2, function: <module>
0001:
*** 0002:devtool_post_patch(d)
0003:
File: '/build/poky/meta/classes/devtool-source.bbclass', lineno: 202, function: devtool_post_patch
0198:
0199: for override in extra_override_list:
0200: localdata = bb.data.createCopy(d)
0201: if override in default_overrides:
*** 0202: bb.process.run('git branch devtool-override-%s %s' % (override, devbranch), cwd=srcsubdir)
0203: else:
0204: # Reset back to the initial commit on a new branch
0205: bb.process.run('git checkout %s -b devtool-override-%s' % (initial_rev, override), cwd=srcsubdir)
0206: # Run do_patch function with the override applied
File: '/build/poky/bitbake/lib/bb/process.py', lineno: 178, function: run
0174: if not stderr is None:
0175: stderr = stderr.decode("utf-8")
0176:
0177: if pipe.returncode != 0:
*** 0178: raise ExecutionError(cmd, pipe.returncode, stdout, stderr)
0179: return stdout, stderr
Exception: bb.process.ExecutionError: Execution of 'git branch devtool-override-foo devtool' failed with exit code 128:
fatal: A branch named 'devtool-override-foo' already exists.
Richard Purdie [Sun, 20 Jan 2019 11:51:34 +0000 (11:51 +0000)]
scripts/contrib/build-perf-test-wrapper.sh: Improve interaction with autobuilder automation
This tweaks the script to:
* Ensure directories exist and can be written to
* Allow the downloads directory to be specified
* Error early if the phantomjs or optipng dependencies are not installed
* Allow the location of the globalres.log file to be specified
This means that the main build directory can be destroyed and any state
from the script is stored elsewhere allowing it to be triggered
automatically from the autobuilder infrastructure.
Khem Raj [Thu, 7 Feb 2019 06:25:26 +0000 (22:25 -0800)]
openssl10: Fix mutliple include assumptions for bn.h in opensslconf.h
After adding #pragma once to wrapper header ( opensslconf.h ) this
latent issue got to bite us, where it expect bn.h to be including
openssl.h to define BN_* defines, which is fragile. This patch removes
the contraints for nested includes for bn.h
Xulin Sun [Tue, 29 Jan 2019 07:31:22 +0000 (15:31 +0800)]
openssl: fix multilib file install conflicts
To avoid issue like below if run "bitbake lib32-core-image-minimal"
with series userspace packages(LAMP,krb5...) added.
Add multilib_script support for openssl's c_rehash which is a perl script.
Error: Transaction check error:
file /usr/bin/c_rehash conflicts between attempted installs of
lib32-openssl-bin-1.1.1-r0.armv7at2hf_neon and openssl-bin-1.1.1-r0.aarch64
Liu Haitao [Thu, 3 Jan 2019 05:48:38 +0000 (13:48 +0800)]
iw: fix parsing of WEP keys
The current iw4.14 has a fatal bug that could casue a Segmentation fault
when parsing WEP keys. The issue has been fixed by upstream.
[https://git.kernel.org/pub/scm/linux/kernel/git/jberg/iw.git/commit/?id=0e39f109c4b8155697a12ef090b59cdb304c8c44]
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
Jens Rehsack [Wed, 28 Nov 2018 08:15:30 +0000 (09:15 +0100)]
avahi: avoid depending on skipped package
When built without D-Bus, libavahi-client is not build:
Building libavahi-client: no (You need avahi-daemon and D-Bus!)
which causes avahi-dev RDEPENDS failing when creating an image
containing development-tools:
* - nothing provides libavahi-client = 0.7-r0 needed by avahi-dev-0.7-r0.cortexa8hf-neon
Bruce Ashfield [Wed, 6 Feb 2019 19:50:39 +0000 (19:50 +0000)]
linux-yocto/4.18: update to v4.18.27
Integrating the -stable updates from Paul Gortmaker that comprise the
following commits:
fb957805a800 Linux 4.18.27 e40e99b6b15d ipmi:ssif: Fix handling of multi-part return messages ec5b2f3f897b ipmi: Prevent use-after-free in deliver_response d605dfec5314 ipmi: msghandler: Fix potential Spectre v1 vulnerabilities 6fcd5c67bbed ipmi: fix use-after-free of user->release_barrier.rda 8978d7c6dec4 Bluetooth: Fix unnecessary error message for HCI request completion 9aa6a6afdc9d iwlwifi: mvm: Send LQ command as async when necessary be293e2c8d5d mm, proc: be more verbose about unstable VMA flags in /proc/<pid>/smaps 5da1802b5dd9 userfaultfd: clear flag if remap event not enabled 08861c6db0c1 mm/swap: use nr_node_ids for avail_lists in swap_info_struct fbd6851e6d57 mm/page-writeback.c: don't break integrity writeback on ->writepage() error 42af1b118dec ocfs2: fix panic due to unrecovered local alloc e701c6b47b1e scsi: megaraid: fix out-of-bound array accesses c2414688a11f scsi: smartpqi: call pqi_free_interrupts() in pqi_shutdown() 248849ffcee8 ath10k: fix peer stats null pointer dereference e6e7a27d9894 scsi: smartpqi: correct lun reset issues f82c77b69dd4 scsi: mpt3sas: fix memory ordering on 64bit writes 7fe3902a1b30 IB/usnic: Fix potential deadlock 07716336ae4f sysfs: Disable lockdep for driver bind/unbind files 52223b291461 ALSA: bebob: fix model-id of unit for Apogee Ensemble f55b7d8c5747 dm: Check for device sector overflow if CONFIG_LBDAF is not set 744fb8e55bdc clocksource/drivers/integrator-ap: Add missing of_node_put() c7e5ef0fad26 quota: Lock s_umount in exclusive mode for Q_XQUOTA{ON,OFF} quotactls. 051f86c6e4fe perf tools: Add missing open_memstream() prototype for systems lacking it f40cb62ae378 perf tools: Add missing sigqueue() prototype for systems lacking it fe10d3ee10ae dm snapshot: Fix excessive memory usage and workqueue stalls dbb2e01442dd tools lib subcmd: Don't add the kernel sources to the include path 9844e0dbc6d0 perf stat: Avoid segfaults caused by negated options d8dc75d3d9fc dm kcopyd: Fix bug causing workqueue stalls dff3fa1af70f dm crypt: use u64 instead of sector_t to store iv_offset 26dfea580c42 x86/topology: Use total_cpus for max logical packages calculation 5f13f97aad1e netfilter: ipt_CLUSTERIP: fix deadlock in netns exit routine d5e112ef684d netfilter: ipt_CLUSTERIP: remove wrong WARN_ON_ONCE in netns exit routine ed843e0c755b netfilter: ipt_CLUSTERIP: check MAC address when duplicate config is set ab68568470d6 perf vendor events intel: Fix Load_Miss_Real_Latency on SKL/SKX 5ddf63d48c16 perf parse-events: Fix unchecked usage of strncpy() 882079829dfb perf svghelper: Fix unchecked usage of strncpy() e689fb5da3fc perf tests ARM: Disable breakpoint tests 32-bit ef3ae9b3e540 perf intel-pt: Fix error with config term "pt=0" 8639a6aacfd7 tty/serial: do not free trasnmit buffer page under port lock 80c3cdea380c btrfs: improve error handling of btrfs_add_link 2202b846b13c btrfs: alloc_chunk: fix more DUP stripe size handling ab3a0bbe8b0b mmc: atmel-mci: do not assume idle after atmci_request_end 32f972da3d3a kconfig: fix memory leak when EOF is encountered in quotation 10d9a6a992ee kconfig: fix file name and line number of warn_ignored_character() f7bcc8b2f7ef bpf: relax verifier restriction on BPF_MOV | BPF_ALU eec0856907da arm64: Fix minor issues with the dcache_by_line_op macro f2300824da71 clk: imx6q: reset exclusive gates on init 1604baf07d22 arm64: kasan: Increase stack size for KASAN_EXTRA 13ba93449b46 selftests: do not macro-expand failed assertion expressions 3bbd076d9136 scsi: target: use consistent left-aligned ASCII INQUIRY data e37db031ef5a net: call sk_dst_reset when set SO_DONTROUTE fb614921bc34 media: venus: core: Set dma maximum segment size eb2c9c4ca615 ASoC: use dma_ops of parent device for acp_audio_dma 68a03c142063 media: firewire: Fix app_info parameter type in avc_ca{,_app}_info b60c7a6713d5 powerpc/pseries/cpuidle: Fix preempt warning df30a1b5d8d2 powerpc/xmon: Fix invocation inside lock region 4f03e69412ba media: uvcvideo: Refactor teardown of uvc on USB disconnect e6b355ae24ba pstore/ram: Do not treat empty buffers as valid 72d479d16ec9 clk: imx: make mux parent strings const 277364cbbd21 jffs2: Fix use of uninitialized delayed_work, lockdep breakage d206a38109fc efi/libstub: Disable some warnings for x86{,_64} 643a876a5b01 rxe: IB_WR_REG_MR does not capture MR's iova field f5d7d77be0a6 scsi: qedi: Check for session online before getting iSCSI TLV data. 5c28f6e86aff ASoC: pcm3168a: Don't disable pcm3168a when CONFIG_PM defined 6ca660928969 selinux: always allow mounting submounts 128146d4fb71 fpga: altera-cvp: fix probing for multiple FPGAs on the bus 3e60aeeefaeb usb: gadget: udc: renesas_usb3: add a safety connection way for forced_b_device e1c8feafd5fe samples: bpf: fix: error handling regarding kprobe_events 2b3081b77e3f clk: meson: meson8b: fix incorrect divider mapping in cpu_scale_table 0bf0163094a9 drm/atomic-helper: Complete fake_commit->flip_done potentially earlier 21330a217643 arm64: perf: set suppress_bind_attrs flag to true 066b9fddd721 crypto: ecc - regularize scalar for scalar multiplication e26359f1620c MIPS: SiByte: Enable swiotlb for SWARM, LittleSur and BigSur 3afff9e63c8e x86/mce: Fix -Wmissing-prototypes warnings 9b3a195320ca ALSA: oxfw: add support for APOGEE duet FireWire 04aba67bbf94 bpf: Allow narrow loads with offset > 0 f30cc07af44f serial: set suppress_bind_attrs flag only if builtin d264a0f394ba writeback: don't decrement wb->refcnt if !wb->bdi 74691a75e365 of: overlay: add missing of_node_put() after add new node to changeset 419af4cd1015 selftests/bpf: enable (uncomment) all tests in test_libbpf.sh 2e3f88e667c6 e1000e: allow non-monotonic SYSTIM readings f782c9d1da48 platform/x86: asus-wmi: Tell the EC the OS will handle the display off hotkey 1261977d0ab4 ixgbe: allow IPsec Tx offload in VEPA mode 7c73931b7303 drm/amd/display: Guard against null stream_state in set_crc_source 39d92f35a8dc gpio: pl061: Move irq_chip definition inside struct pl061 3aec221e313a netfilter: ipset: Allow matching on destination MAC address for mac and ipmac sets 6a5be9a2ffef ipv6: Take rcu_read_lock in __inet6_bind for mapped addresses 50d329eca381 r8169: Add support for new Realtek Ethernet d1aad26bb964 qmi_wwan: add MTU default to qmap network interface 62b4f9e777bf net, skbuff: do not prefer skb allocation fails early eb5c8d69ea42 net: dsa: mv88x6xxx: mv88e6390 errata 993bc7d54dac mlxsw: spectrum_switchdev: Set PVID correctly during VLAN deletion 8fb8533a5309 mlxsw: spectrum: Disable lag port TX before removing it 75daf3c475df ipv6: Consider sk_bound_dev_if when binding a socket to a v4 mapped address 73827a8e2e30 nbd: Use set_blocksize() to set device blocksize f65d7d5574e1 drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock 528fa9207170 loop: drop caches if offset or block_size are changed 3df31feee60d loop: Fix double mutex_unlock(&loop_ctl_mutex) in loop_control_ioctl() d4082dc05ac9 loop: Get rid of 'nested' acquisition of loop_ctl_mutex 78f210acfd34 loop: Avoid circular locking dependency between loop_ctl_mutex and bd_mutex 3ebf94b079ba loop: Fix deadlock when calling blkdev_reread_part() fc4a4583f9f1 loop: Move loop_reread_partitions() out of loop_ctl_mutex 2c2c3aa3ab1c loop: Move special partition reread handling in loop_clr_fd() e2c6ee2931ca loop: Push loop_ctl_mutex down to loop_change_fd() b442997a7285 loop: Push loop_ctl_mutex down to loop_set_fd() 33d682700fb0 loop: Push loop_ctl_mutex down to loop_set_status() 49f911a6a4c0 loop: Push loop_ctl_mutex down to loop_get_status() c3be2cd6ad9e loop: Push loop_ctl_mutex down into loop_clr_fd() 9a4a7555c177 loop: Split setting of lo_state from loop_clr_fd d1f05249099a loop: Push lo_ctl_mutex down into individual ioctls 50bbdfab99c1 loop: Get rid of loop_index_mutex bc40dc95afdc loop: Fold __loop_release into loop_release 23d5eac305d0 block/loop: Use global lock for ioctl() operation. e0d29ef2a8b0 block/loop: Don't grab "struct file" for vfs_getattr() operation. 8281310f32aa tipc: fix uninit-value in tipc_nl_compat_doit 95c94c995d8e tipc: fix uninit-value in tipc_nl_compat_name_table_dump b099f94e1e4d tipc: fix uninit-value in tipc_nl_compat_link_set 8e649a4839e0 tipc: fix uninit-value in tipc_nl_compat_bearer_enable e54458ac168e tipc: fix uninit-value in tipc_nl_compat_link_reset_stats 9a8f56b713dc tipc: fix uninit-value in in tipc_conn_rcv_sub 08ea8e1bfd4b sctp: allocate sctp_sockaddr_entry with kzalloc 4c02dbac416c blockdev: Fix livelocks on loop device af7bec66e3ee selinux: fix GPF on invalid policy de9b736152ed block: use rcu_work instead of call_rcu to avoid sleep in softirq b232d75be71a netfilter: ebtables: account ebt_table_info to kmemcg aa4d1d6641b5 sunrpc: handle ENOMEM in rpcb_getport_async ddb29b79dbff media: vb2: be sure to unlock mutex on errors b9f0f2f9cf59 media: vb2: vb2_mmap: move lock up 7308ece86dd0 LSM: Check for NULL cred-security on free 71ba5763243b ipv6: make icmp6_send() robust against null skb->dev 05e6bff7e7a6 bpf: in __bpf_redirect_no_mac pull mac only if present 4181e7d61b1a media: vivid: set min width/height to a value > 0 cbfc610ae5f2 media: vivid: fix error handling of kthread_run 05f5b1394483 omap2fb: Fix stack memory disclosure 28063cb50ed8 fix int_sqrt64() for very large numbers 37112a960b7f Disable MSI also when pcie-octeon.pcie_disable on 8fd61f25fcf3 arm64: dts: marvell: armada-ap806: reserve PSCI area 58c3acda1754 arm64: kaslr: ensure randomized quantities are clean to the PoC 9a013b991c02 pstore/ram: Avoid allocation and leak of platform data 1aa9985076dc RDMA/nldev: Don't expose unsafe global rkey to regular user b409b102c7d8 media: v4l: ioctl: Validate num_planes for debug messages 92dd1f93a3c9 mfd: tps6586x: Handle interrupts on suspend 2e63388cbfdb OF: properties: add missing of_node_put 1957d16bceca drm/i915/gvt: Fix mmap range check f1e756d98a46 MIPS: lantiq: Fix IPI interrupt handling ac8f34885340 mips: fix n32 compat_ipc_parse_version 0830f02f81b3 scsi: sd: Fix cache_type_store() f25d687e3d8b scsi: core: Synchronize request queue PM status only on successful resume 0f7357d9b8e4 Yama: Check for pid death before checking ancestry f94e8c0566d0 btrfs: wait on ordered extents on abort cleanup 4b1129e59323 Revert "btrfs: balance dirty metadata pages in btrfs_finish_ordered_io" f9ac2ffa0255 xen: Fix x86 sched_clock() interface for xen 79ad9eda6689 x86/xen/time: Output xen sched_clock time from 0 7b3718f98f17 crypto: talitos - fix ablkcipher for CONFIG_VMAP_STACK c194e944dc98 crypto: talitos - reorder code in talitos_edesc_alloc() 0b612c90335c crypto: authenc - fix parsing key with misaligned rta_len bed3cec44833 crypto: bcm - convert to use crypto_authenc_extractkeys() f1daff3d1cb1 crypto: ccree - convert to use crypto_authenc_extractkeys() b445d866e2fa crypto: authencesn - Avoid twice completion call in decrypt path 1d5d8babb9a8 crypto: caam - fix zero-length buffer DMA mapping 04836f6b86bd crypto: sm3 - fix undefined shift by >= width of value 42cd579fd790 bonding: update nest level on unlink 12dff858b935 r8169: don't try to read counters if chip is in a PCI power-save state 5087c2825807 smc: move unhash as early as possible in smc_release() cf652d77ac45 tun: publish tfile after it's fully initialized faee48550bf4 tcp: change txhash on SYN-data timeout e87c244b11cd net: bridge: fix a bug on using a neighbour cache entry without checking its state c499692ded84 ipv6: fix kernel-infoleak in ipv6_local_error() a3ab077a3f79 arm64: Don't trap host pointer auth use to EL2 6f127252fe5f arm64/kvm: consistently handle host HCR_EL2 flags e5fed8d49b5b scsi: target: iscsi: cxgbit: fix csk leak f1778e1523fa netfilter: nf_conncount: don't skip eviction when age is negative df00c2c10e4f can: gw: ensure DLC boundaries after CAN frame modification 58e9f5227691 tty: Don't hold ldisc lock in tty_reopen() if ldisc present c6e522371001 tty: Simplify tty->count math in tty_reopen() e3ac534b8aa5 tty: Hold tty_ldisc_lock() during tty_reopen() 3456ecaf8d34 tty/ldsem: Wake up readers after timed out down_write() 2b1afc9c3506 Btrfs: use nofs context when initializing security xattrs to avoid deadlock 403d0f9134a7 Btrfs: fix access to available allocation bits when starting balance 343ae5df68a2 KVM: arm/arm64: Fix VMID alloc race by reverting to lock-less 42e3a4424b12 sunrpc: use-after-free in svc_process_common() 39e372a81d13 mm: page_mapped: don't assume compound page is huge or THP 845f8457893a ext4: track writeback errors using the generic tracking infrastructure a0e9782472b8 ext4: use ext4_write_inode() when fsyncing w/o a journal c60e8096cc4d ext4: avoid kernel warning when writing the superblock to a dead device 3ec6f7792def ext4: fix a potential fiemap/page fault deadlock w/ inline_data 02d823cdb2a4 ext4: make sure enough credits are reserved for dioread_nolock writes 154261392771 rbd: don't return 0 on unmap if RBD_DEV_FLAG_REMOVING is set 98213a9d5ce0 drm/amdgpu: Don't fail resume process if resuming atomic state fails dc2660871a4a drm/amdgpu: Don't ignore rc from drm_dp_mst_topology_mgr_resume() 26089047b42c drm/amd/display: Fix MST dp_blank REG_WAIT timeout 003d29ca6fba PCI: dwc: Move interrupt acking into the proper callback b90e95417c02 PCI: dwc: Take lock when ACKing an interrupt d51df9e16301 PCI: dwc: Use interrupt masking instead of disabling c122260b25cd drm/amdgpu: Add new VegaM pci id 789040bc5039 vfio/type1: Fix unmap overflow off-by-one 86cecca3d93e i2c: dev: prevent adapter retries and timeout being set as minus value 50558f1ca67b ACPI / PMIC: xpower: Fix TS-pin current-source handling 4b75905144c7 ACPI: power: Skip duplicate power resource references in _PRx c78b2116c9d7 mm, memcg: fix reclaim deadlock with writeback 8bf6869b4d75 mm/usercopy.c: no check page span for stack objects d6c879709135 slab: alien caches must not be initialized if the allocation of the alien cache failed bb1c250d55ff USB: Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB 39fa1b192449 USB: storage: add quirk for SMI SM3350 4385b42a4cc2 USB: storage: don't insert sane sense for SPC3+ when bad sense specified d10e7b64e2b3 usb: cdc-acm: send ZLP for Telit 3G Intel based modems af318dc8d1f4 cifs: Fix potential OOB access of lock element array 4c26d3a072da CIFS: Do not hide EINTR after sending network packets 50c6b89008ec CIFS: Fix adjustment of credits for MTU requests a7eb3c3dc214 ALSA: hda/realtek - Disable headset Mic VREF for headset mode of ALC225 dcb78b2a6e1c ALSA: hda/realtek - Add unplug function into unplug state of Headset Mode for ALC225 26b78760c7ae ALSA: hda/realtek - Support Dell headset mode for New AIO platform 94ddf9e27eb5 cpufreq: scmi: Fix frequency invariance in slow path 516c5e5f484f Revert "x86/hyper-v: Check cpumask_to_vpset() return value in hyperv_flush_tlb_others_ex()"
Bruce Ashfield [Wed, 6 Feb 2019 19:50:38 +0000 (19:50 +0000)]
linux-yocto/4.18: update to v4.18.26
Integrating Paul Gortmaker's stable updates that comprise the following
commits:
89754c7da63f Linux 4.18.26 c564abe1908c NFSv4: Fix a tracepoint Oops in initiate_file_draining() 890d46c677fd net: hns3: fix return value error while hclge_cmd_csq_clean failed 9cee553eeef0 PCI/AER: Remove duplicate PCI_EXP_AER_FLAGS definition 5ffe615c7959 fbdev: omap2: omapfb: fix ifnullfree.cocci warnings 9a2eb194c961 fbdev: omap2: omapfb: fix bugon.cocci warnings 795731d5307f fbdev: omap2: omapfb: fix boolreturn.cocci warnings 8c656840a4cc PCI: mobiveil: Add Kconfig/Makefile entries 0f7c216a5905 pinctrl: mediatek: include chained_irq.h header 3f240c958d39 m68k/io: Add missing ioremap define guards, fix typo 3aca0a7960d4 dm writecache: report start_sector in status line 50de44fbe274 arm64: mm: Export __sync_icache_dcache() for xen-privcmd 4c521f993bb9 tipc: add missing dev_put() on error in tipc_enable_l2_media 0a7f5ef06a67 clk: actions: Add missing REGMAP_MMIO dependency 90cbc3a9021a net: remove redundant input checks in SIOCSIFTXQLEN case of dev_ifsioc 92b0d2a490ba nvmet: check fileio lba range access boundaries 95550ccfee82 EVM: fix return value check in evm_write_xattrs() 9c63338b2ecc multicast: remove useless parameter for group add 818380e81f55 regulator: qcom_spmi: Do not initialise static to NULL 80faeb6437d9 netfilter: nft_socket: Break evaluation if no socket found 7896db3d286a netfilter: nft_tproxy: Move nf_tproxy_assign_sock() to nf_tproxy.h 6ee2615cbc6c x86/hyper-v: Check cpumask_to_vpset() return value in hyperv_flush_tlb_others_ex() b98d573d572f drm/nouveau/kms/nv50-: fix drm-get-put.cocci warnings 5b4fbedbb14a ASoC: qdsp6: q6routing: off by one in routing_hw_params() 0ce601464e44 drm/amdgpu: get VCN start to process in the dpm disabled case cdb988723c92 net: stmmac: Fix PCI module removal leak f014d3b35b9f ip: on queued skb use skb_header_pointer instead of pskb_may_pull ee45cb43d804 linux/device.h: fix kernel-doc notation warning eb11d9a94de0 regulator: Revert "regulator: pfuze100: add enable/disable for switch" 26d53be66490 KVM: VMX: hide flexpriority from guest when disabled at the module level 1c9ebfaf8229 media: omap3isp: fix warning for !CONFIG_PM 60f30bf144b8 cfg80211: fix wext-compat memory leak 9685f469611b spi: spi-mem: Add missing description for data.nbytes field 07b7e110c17b arm64: dts: renesas: r8a77990: Remove non-existing STBE region d6e90a26c5bd media: cx231xx: fix RC_CORE dependency 7a281dbd6967 media: v4l: cadence: add VIDEO_V4L2 dependency 3b95f46801af perf Documentation: Fix out-of-tree asciidoctor man page generation 8d927494900d selftests: forwarding: mirror_gre_vlan_bridge_1q: Unset rp_filter 8359363df5a6 net/mlx5: Use u16 for Work Queue buffer strides offset 0f85219db2ee kconfig: remove a spurious self-assignment 40535cf8ca98 netfilter: nf_tables: don't prevent event handler from device cleanup on netns exit 10d27d084c16 drm/i915: Stop holding a ref to the ppgtt from each vma e9c0ce028417 f2fs: wake up gc thread immediately when gc_urgent is set b9f47e1e8a61 tcp: avoid resetting ACK timer upon receiving packet with ECN CWR flag f1a29b5218b0 tcp: mandate a one-time immediate ACK 4474fad367bf selftests: rtnetlink: use a local IP address for IPsec tests f9229f11713c selftests: rtnetlink: hide complaint from terminated monitor 2b4cb6ad782d i40iw: Reorganize acquire/release of locks in i40iw_manage_apbvt f2aa45e70b9a drm/sun4i: mark PM functions as __maybe_unused 6c4f9bb9e2c7 drm/v3d: Checking for NULL vs IS_ERR()
Mingli Yu [Wed, 13 Feb 2019 05:43:28 +0000 (13:43 +0800)]
logrotate.py: restore /etc/logrotate.d/wtmp
During the test logrotate.LogrotateTest.test_1_logrotate_setup,
there is below logic:
# mkdir $HOME/logrotate_dir
# sed -i "s#wtmp {#wtmp {\n olddir $HOME/logrotate_dir#" /etc/logrotate.d/wtmp
After all logrotate.LogrotateTest finished, only cleanup
$HOME/logrotate_dir as below, but don't restore
the config file /etc/logrotate.d/wtmp.
[snip]
def tearDownClass(cls):
cls.tc.target.run('rm -rf $HOME/logrotate_dir')
[snip]
That's to say, there is one additional line added
to /etc/logrotate.d/wtmp and will make the logrotate
service start failed when run systemd.SystemdBasicTests.test_systemd_failed
Take an example as below when run test as root:
# cat /etc/logrotate.d/wtmp
# no packages own wtmp -- we'll rotate it here
/var/log/wtmp {
olddir /root/logrotate_dir
missingok
monthly
create 0664 root utmp
minsize 1M
rotate 1
}
# ls /root/logrotate_dir
ls: cannot access '/root/logrotate_dir': No such file or directory
# systemctl start logrotate
Job for logrotate.service failed because the control process exited with error code.
See "systemctl status logrotate.service" and "journalctl -xe" for details.
# systemctl status logrotate
logrotate.service - Rotate log files
Loaded: loaded (/lib/systemd/system/logrotate.service; static; vendor preset>
Active: failed (Result: exit-code) since Wed 2019-02-13 03:35:19 UTC; 7s ago
Docs: man:logrotate(8)
man:logrotate.conf(5)
Process: 540 ExecStart=/usr/sbin/logrotate /etc/logrotate.conf (code=exited, status=1/FAILURE)
Main PID: 540 (code=exited, status=1/FAILURE)
Feb 13 03:35:18 qemumips systemd[1]: Starting Rotate log files...
Feb 13 03:35:19 qemumips logrotate[540]: error: wtmp:9 error verifying olddir path /root/logrotate_dir: No such file or directory
Feb 13 03:35:19 qemumips logrotate[540]: error: found error in file wtmp, skipping
Feb 13 03:35:19 qemumips systemd[1]: logrotate.service: Main process exited, code=exited, status=1/FAILURE
Feb 13 03:35:19 qemumips systemd[1]: logrotate.service: Failed with result 'exit-code'.
Feb 13 03:35:19 qemumips systemd[1]: Failed to start Rotate log files.
Add the logic to restore /etc/logrotate.d/wtmp to
make the cleanup complete to fix the above issue.
Richard Purdie [Wed, 30 Jan 2019 22:01:23 +0000 (22:01 +0000)]
oeqa/runtime/ptest: Ensure OOM errors are logged
Currently processed being killed by the OOM killer may not be spotted by
ptest-runner. After we complete the tests, check the logs and report if there
were any. This ensures the user is aware of OOM conditions affecting the
ptest results.
Richard Purdie [Tue, 29 Jan 2019 16:52:18 +0000 (16:52 +0000)]
oeqa/logparser: Various misc cleanups
Get rid of further unneeded code complications:
* value mappings we could just direct use
* ftools when we can write files easily ourself
* test result status filtering we don't use
* variable overwriting module imports
Richard Purdie [Tue, 29 Jan 2019 13:24:45 +0000 (13:24 +0000)]
oeqa/logparser: Reform the ptest results parser
Now we have a dedicated ptest parser, merge in the remaining ptest
specific pieces to further clarify and simplify the code, moving to
a point where we can consider extending/enhancing it.
logparser is only used by ptest. Its slightly overcomplicated as it was
intended to be reusable but wasn't. Simplify it as a dedicated parser is
likely to me more readable and maintainable.
Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
