Joshua Watt [Mon, 16 Nov 2020 14:38:26 +0000 (08:38 -0600)]
systemd: Re-enable chvt as non-root user without polkit
systemd 245 introduced a regression in behavior where they removed
support for non-root users to chvt from a service file. This prevents
running compositors (e.g. weston) as any user other than root. The
intention is for polkit to be used to allow this (and in fact the
default polkit rules that ship with systemd allow this). However, polkit
is a huge dependency to bring in for an embedded system, and isn't
support by OE-core.
The patch has been proposed upstream to restore the previous behavior of
allowing a non-root user to chvt to unbreak the regression without
requiring polkit.
python3: split python target configuration into own class
Setting _PYTHON_SYSCONFIGDATA_NAME in python3native class globally was
problematic as it was leaking into host python environment, which
was causing tracebacks depending on host distro and action
(typically anything involving importing sysconfig module).
The new class sets the variable only in specific tasks where it is needed,
and should be inherited explicitly:
- use python3native to run scripts with native python
- use python3targetconfig to run scripts with native python
if those scripts need to access target config data (such
as correct installation directories). This also adds a dependency
on target python, so should be used carefully to avoid lengthening builds.
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Luca Boccassi [Fri, 13 Nov 2020 14:50:31 +0000 (14:50 +0000)]
dbus: split -common and -tools out of main package
Certain config files and units are shared between dbus-daemon and
dbus-broker (available in meta-openembedded), so split them out to
allow installing dbus-broker without pulling in dbus-daemon and its
dependencies.
Stand-alone command line tools can also be used regardless of whether
the buses are provided by dbus-daemon or dbus-broker, so split them
out into dbus-tools.
Finally, move the XML schema files out of the main package and into
the development package.
All these changes follow the same pattern used by Fedora, which was
one of the first distro to switch to dbus-broker by default:
Bruce Ashfield [Fri, 13 Nov 2020 06:32:06 +0000 (01:32 -0500)]
kernel: provide module.lds for out of tree builds in v5.10+
The upstream commit 596b0474d3d [kbuild: preprocess module linker
script], adds a dependency on module.lds for external module
building.
Since module.lds is generated as part of 'modules_prepare', we
must make it available with the other kernel artifacts in the
kernel shared workdir, otherwise out of tree builds fail.
This fixes errors like:
| make[4]: *** No rule to make target 'scripts/module.lds', needed by
'build/tmp/work/qemuarm64-poky-linux/cryptodev-module/1.11-r0/git/cryptodev.ko'.
Stop.
| make[4]: *** Waiting for unfinished jobs....
We also ensure that kernel-devsrc has a copy to support on
target module builds that are often prepared with 'make scripts
prepare'. Those targets won't regenerate it, so the build fails.
If 'make modules_prepare' is used, the file will be regenerated
and overwrite our copy (as expected).
Signed-off-by: Pan, Kris <kris.pan@intel.com> Signed-off-by: Lili Li <lili.li@intel.com> Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Mark Jonas [Thu, 12 Nov 2020 19:28:10 +0000 (20:28 +0100)]
libbsd: Remove BSD-4-Clause from main package
libbsd contains a multitude of licenses. For (commercial) projects the
3rd clause of the BSD-4-Clause license can be problematic. But only a
few man pages use this license. This means that the main package
containing the binary library itself is not under BSD-4-Clause ruling.
Signed-off-by: Mark Jonas <toertel@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Yann Dirson [Thu, 12 Nov 2020 17:26:16 +0000 (18:26 +0100)]
systemtap: split runtime material in its own package
Note the _class-target qualifier, here to prevent a funky dependency of
systemtap-native on systemtap-native-runtime-native. This possibly hints
to something deeper ?
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Matt Madison [Thu, 12 Nov 2020 14:51:41 +0000 (06:51 -0800)]
layer.conf: fix syntax error in PATH setting
Commit 05a87be51b44608ce4f77ac332df90a3cd2445ef introduced
a Python conditional expression when updating PATH that
generates syntax warnings in bitbake-cookerdaemon.log:
Var <PATH[:=]>:1: SyntaxWarning: "is not" with a literal. Did you mean "!="?
Fix this by using the more appropriate '!=' comparison
operator.
Signed-off-by: Matt Madison <matt@madison.systems> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Dan Callaghan [Tue, 21 Jan 2020 01:24:12 +0000 (11:24 +1000)]
gdb: add PACKAGECONFIG for xz (lzma) compression support
Similar to elfutils, when xz support is built into gdb it will be able
to read xz-compressed ELF sections containing debuginfo. This is used by
the "mini debuginfo" format:
https://sourceware.org/gdb/onlinedocs/gdb/MiniDebugInfo.html
Signed-off-by: Dan Callaghan <dan.callaghan@opengear.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Alban Bedel [Tue, 3 Nov 2020 15:13:34 +0000 (16:13 +0100)]
systemd: Fix systemd when used with busybox less
Per default systemd use a pager for the output of most of its tools
and it expect this pager to be color capable. But that is not the case
when the busybox `less` is used, which lead to output garbled by color
escape sequences.
To fix this issue add a profile frament that disable the systemd pager
when busybox `less` is detected.
Signed-off-by: Alban Bedel <alban.bedel@aerq.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Khem Raj [Wed, 11 Nov 2020 01:47:53 +0000 (17:47 -0800)]
lto.inc: Disable LTO for webkit
webkit fails to link with LTO on at this point. Some of the issues
are being worked on upstream and disabling LTO should be re-evaluated as
we update this change.
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Randy MacLeod [Wed, 11 Nov 2020 01:06:52 +0000 (20:06 -0500)]
libsdl2: Disable video-rpi
When building on Raspbery Pi OS/64-bit, libsdl2 fails with
the error:
.../tmp/work/aarch64-linux/libsdl2-native/2.9.12-r0/SDL2-2.0.12/src/video/raspberry/SDL.rpivideo.h:47:5:
error: unknown type name 'EGL_DISPMANX_WINDOW_T'
EGL_DISPMANX_WINDOW_T dispman_window;
Disable video-rpi to avoid the problem since video suppport is
not needed for rpi and this configuration option is harmless when
building on x86-64 hosts.
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
With the packported patch from rt-tests (67da9d8af7d8a0e1a0822e6ee99d68fa3d5a46d2)
that allows build for all archs this patch can be reverted. An error is dumped in
run-time is frc() is not present.
Signed-off-by: Peter Bergin <peter@berginkonsult.se> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Peter Bergin [Wed, 11 Nov 2020 22:15:02 +0000 (23:15 +0100)]
rt-tests: backport patch that enable build for all archs
Upstream rt-tests has applied a patch that allow builds for all archs.
The problem is that oslat using frc() that is not present for all archs.
With this backported patch oslat is building but in run-time an error
message is dumped if frc() is not present.
Signed-off-by: Peter Bergin <peter@berginkonsult.se> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Denys Zagorui [Tue, 10 Nov 2020 18:14:12 +0000 (18:14 +0000)]
binutils: reproducibility: reuse debug-prefix-map for stabs
powerpc 32bit Linux Kernel widely uses .stabs pseudo-op to
produce debugging information in stabs format. Faced an issue
that during Linux Kernel build with Yocto build system for 32bit
powerpc platform resulting vmlinux contains absolute path in
.stabstr section that cannot be remapped with -fdebug-prefix-map
option.
Yocto uses scripts/mkmakefile Linux Kernel build approach that
allows to store all generated files outside of kernel source
tree. With this approach each compilier invocation is performed
with an absolute path to a file that will be compiled and this
absolute path is recorded in init stab. There is no way to remap
this path.
Reuse remap_debug_filename api to make -fdebug-prefix-map flag
aplicable for init stab.
Signed-off-by: Denys Zagorui <dzagorui@cisco.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Konrad Weihmann [Tue, 10 Nov 2020 19:20:16 +0000 (20:20 +0100)]
testimage: print results for interrupted runs
When a run is ended by overall timeout, print the already executed
testcases, to provide some hints which testcase might made the
test suite reach global timeout.
Nonetheless make the testrun exit with an error
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Konrad Weihmann [Tue, 10 Nov 2020 19:20:14 +0000 (20:20 +0100)]
oeqa/core/context: expose results as variable
register an unittest handler for testresults and expose it as
variable result.
With this even partial results from an interrupted test suite run
can be made available
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Steve Sakoman [Tue, 10 Nov 2020 17:34:01 +0000 (07:34 -1000)]
openssh: whitelist CVE-2014-9278
The OpenSSH server, as used in Fedora and Red Hat Enterprise
Linux 7 and when running in a Kerberos environment, allows remote
authenticated users to log in as another user when they are listed
in the .k5users file of that user, which might bypass intended
authentication requirements that would force a local login.
Whitelist the CVE since this issue is Redhat specific.
Signed-off-by: Steve Sakoman <steve@sakoman.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Federico Pellegrin (1):
openssl: Add c_rehash to misc package and add perl runtime dependency
c_rehash implemented in perl is back (in history was moved to shell for
some time), so handle it inside the -misc package so just that one will
carry the heavy runtime dependency on perl and not the whole openssl
package. Note: in misc there were already before a few perl files
(tsget.pl and CA.pl) so the added perl dependency will fix those too.
[YOCTO #14083]
Signed-off-by: Federico Pellegrin <fede@evolware.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Joseph Reynolds [Tue, 10 Nov 2020 03:56:42 +0000 (11:56 +0800)]
add new extrausers command passwd-expire
This enhances extrausers with a new passwd-expire command that causes
a local user's password to be expired as if the `passwd --expire`
command was run, so the password needs to be changed on initial login.
Tested: on useradd accounts
When configured with Linux-PAM, console login prompts for and can
successfully change the password. OpenSSH server works. Dropbear
SSH server notes the password must be changed but does not offer a
password change dialog and rejects the login request.
Signed-off-by: Joseph Reynolds <joseph-reynolds@charter.net> Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Update the python3-manifest to match the files installed by the
new version of python3.
- Kept tkinter the way it was although tk isnt part of OE-Core
- Made typing part of python3-core
- Update other packages with new dependencies such as filecmp and dataclasses.
Signed-off-by: Alejandro Enedino Hernandez Samaniego <alhe@linux.microsoft.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Several issues are addressed:
1. weston requires pam when starting under systemd
2. systemd was attempting to launch weston twice (from
sysvinit script and from systemd unit file) which caused confusion
and errors.
3. runtime test should stop/start weston via systemd only if systemd
actually controls system startup, not merely when systemd is present.
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Khem Raj [Mon, 9 Nov 2020 00:02:17 +0000 (16:02 -0800)]
gcc: Handle duplicate names for variables
PREFIXVAR is defined in cppdefaults.c as well which shows up as error
when LTO is enabled to build gcc, therefore rename the one instance to PREFIXVAR1
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Khem Raj [Mon, 9 Nov 2020 00:02:14 +0000 (16:02 -0800)]
gcc: Do no parameterize LTO configuration flags
These flags are redundant as LTO now enabled in GCC by default for
sometime, Moreover, dropping LTO variable here avoids a conflict with
global LTO variable being added for distrowide LTO support
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Khem Raj [Mon, 9 Nov 2020 00:02:08 +0000 (16:02 -0800)]
python3: Enable lto if its in DISTRO_FEATURES
python3 configure compiles on object file and then greps for strings in
it for endianness for target ,when using LTO the .o files are not nomal
ELF onjects so this test fails, since we are using --enable-lto to
enable this here we dont need to inject extra paths via bitbake anyway
therefore reset LTO variable for target
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Khem Raj [Mon, 9 Nov 2020 00:02:07 +0000 (16:02 -0800)]
lto: Add global LTO distro policy file
Distros which want to enable LTO can utilize this file, it only covers
packages from OE-Core, other layers should include there own exclusion
list for recipe which dont work with LTO
Document the needed changes in local.conf.extended
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Martin Jansa [Fri, 6 Nov 2020 02:42:52 +0000 (03:42 +0100)]
webkitgtk: fix opengl PACKAGECONFIG
* ENABLE(OPENGL) was renamed to ENABLE(GRAPHICS_CONTEXT_GL) in r254064:
https://github.com/WebKit/webkit/commit/92f9916b4a0d799c3f7be10b69aa53f40a149a2d
and
https://github.com/WebKit/webkit/commit/b3cb3ba4fa713e23ae27b2a79c14c6735d40d671
but AUH doesn't notice that and builds without opengl in DISTRO_FEATURES are now
failing with:
| CMake Error at Source/cmake/OptionsGTK.cmake:323 (message):
| Either OpenGL or OpenGLES2 is needed for ENABLE_GRAPHICS_CONTEXT_GL.
| Call Stack (most recent call first):
| Source/cmake/WebKitCommon.cmake:58 (include)
| CMakeLists.txt:173 (include)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Yi Zhao [Fri, 6 Nov 2020 02:54:26 +0000 (10:54 +0800)]
dhcpcd: install dhcpcd to /sbin rather than /usr/sbin
The dhcpcd path is hardcoded to /sbin in ifupdown package. Move dhcpcd
from /usr/sbin to /sbin to make sure ifup/ifdown can find it when dhcpcd
as the dhcp client backend.
Signed-off-by: Yi Zhao <yi.zhao@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
systemd: selinux hook handling to enumerate nexthop
When selinux is enabled, the call of
manager_rtnl_enumerate_nexthop() fails.
This fix is to facilitate selinux hook handling
for enumerating nexthop.
In manager_rtnl_enumerate_nexthop() there is a check
if "Not supported" is returned by the send_netlink() call.
This check expects that -EOPNOTSUPP is returned,
the selinux hook seems to return -EINVAL instead.
This happens in kernel older than 5.3
(more specificallytorvalds/linux@65ee00a) as it does not support
nexthop handling through netlink.
And if SELinux is enforced in the order kernel, callingRTM_GETNEXTHOP
returns -EINVAL.
Thus adding a call in the manager_rtnl_enumerate_nexthop for the
extra return -EINVAL.
Note: systemd version is different in yocto project (v246.6) and
systemd master(v247) and In systemd verison(246.6)
mac_selinux_enforcing() function is not declared and defined.
Signed-off-by: Purushottam choudhary <purushottam.choudhary@kpit.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Nathan Rossi [Wed, 4 Nov 2020 11:34:48 +0000 (11:34 +0000)]
cml1.bbclass: Handle ncurses-native being available via pkg-config
The linux kernel will by default use pkg-config to get ncurses(w) paths,
falling back to absolute path checks otherwise. If the build host does
not have ncurses installed this will fail as pkg-config will not search
the native sysroot for ncurses.
To more all kernel/kconfig sources, inject the equivalent native
pkg-config variables similar to what is done by the pkg-config-native
script. This only affects the menuconfig python task itself and the
oe_terminal call inside it.
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Yi Zhao [Thu, 5 Nov 2020 08:05:54 +0000 (16:05 +0800)]
pulseaudio: unify volatiles file name
Make the volatiles file name start with a numeric value to unified
volatiles file naming. I searched in oe-core, only pluseaudio volatiles
file name is not start with number.
On a default sato-sdk image:
$ ls /etc/default/volatiles/
00_core 01_bootlogd 99_dbus 99_sshd 99_wpa_supplicant volatiles.04_pulse
This is just a name change and will not affect the functionality.
Signed-off-by: Yi Zhao <yi.zhao@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Leitner [Wed, 4 Nov 2020 14:25:32 +0000 (15:25 +0100)]
weston-init: introduce WESTON_GROUP
Currently the WESTON_USER variable is used as user and group name for
chown'ing XDG_RUNTIME_DIR. If WESTON_USER has no group with the same
name this fails.
Therefore add a new WESTON_GROUP variable which is set to WESTON_USER if
not specified to ensure backwards compatibility.
Signed-off-by: Richard Leitner <richard.leitner@skidata.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Andrej Valek [Wed, 4 Nov 2020 13:35:33 +0000 (14:35 +0100)]
autotools: CONFIG_SHELL defaults
Do not hard-code default shell to /bin/bash even if CONFIG_SHELL is already
set to other shell, but keep /bin/bash as a default. This will fix a shadow
issue, where CONFIG_SHELL is exported to /bin/sh, but /bin/bash is used
even if it's not installed.
Signed-off-by: Andrej Kozemcak <andrej.kozemcak@siemens.com> Signed-off-by: Andrej Valek <andrej.valek@siemens.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Gratian Crisan [Thu, 5 Nov 2020 21:39:56 +0000 (15:39 -0600)]
kernel-module-split.bbclass: identify kernel modconf files as configuration files
Currently the modconf fragments representing the configuration for
kernel modules are written out to appropriate .conf files and added to
the FILES variable. However they are not identified as 'configuration
files' and installing a new version of a kernel module results in a
conflict and a failed installed because the respective .conf file is
already in place from a previous install.
Add the generated .conf files to the CONFFILES variable denoting their
true nature.
Signed-off-by: Gratian Crisan <gratian.crisan@ni.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Anibal Limon [Thu, 5 Nov 2020 18:04:47 +0000 (12:04 -0600)]
recipes-graphics: libxkbcommon disable build of libxkbregistry
This library depends on libxml2 causing a build failure,
...
07:50:36 Run-time dependency xcb-xkb found: YES 1.14
07:50:36 Found CMake: NO
07:50:36 Run-time dependency libxml-2.0 found: NO (tried pkgconfig)
07:50:36
07:50:36 ../libxkbcommon-1.0.1/meson.build:329:4: ERROR: Dependency "libxml-2.0" not found, tried pkgconfig
07:50:36
07:50:36 A full log can be found at /srv/oe/build/tmp-rpb-glibc/work/cortexa53-linaro-linux/libxkbcommon/1.0.1-r0/build/meson-logs/meson-log.txt
07:50:36 WARNING: exit code 1 from a shell command.
...
According libxkbcommon PACKAGING file the libxkbregistry is suggested to
be packaged separately, users of libxkbcommon dosen't require
libxkbregistry and vice-versa, see:
Nathan Rossi [Thu, 5 Nov 2020 11:02:47 +0000 (11:02 +0000)]
vim: add nativesdk to BBCLASSEXTEND
Enable nativesdk build support in order to be able to include vim in
nativesdk targets (e.g. buildtools-tarball/sdk). It is useful to be able
to provide an editor in a relocatable form for when hosts do not provide
an editor. Additionally the vim recipe provides the xxd tool.
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Richard Purdie [Thu, 29 Oct 2020 22:14:53 +0000 (22:14 +0000)]
alsa-utils: Fix license to GPLv2 only
Parts of alsa-utils are v2 only, parts are v2 or later. The effect is
the end result is GPLv2 and there seems little value in marking everything
as being a mixture of both. Fix LICENSE to match reality.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Ricardo Salveti [Mon, 2 Nov 2020 22:34:29 +0000 (19:34 -0300)]
dosfstools: add mkfs.vfat to ALTERNATIVE
The mkfs.vfat tool can also be provided by busybox via the CONFIG_MKFS_VFAT
configuration (not enabled by default in OE but can be enabled on
systems avoiding components based on GPLv3).
Signed-off-by: Ricardo Salveti <ricardo@foundries.io> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Jason Wessel [Mon, 2 Nov 2020 22:28:52 +0000 (14:28 -0800)]
systemd-serialgetty: Switch to TERM=linux
Long ago in commit 473ff65c2f69de4ece3204fadfae7c5cb992149a
(serial-getty service: Add xterm as default TERM), the xterm
became the default for the serial port terminal.
Using the version of vim.tiny in oe-core master with the
serial port connected in xterm version 322 (which is one
of the most widely deployed versions at the current time)
causes artifacts and missed characters.
The example sequence is the following:
* Start vim
* Press "i" to enter input mode
* Type "123"
* Press Escape to enter command mode
* Press "a" to enter append mode
* Type "456"
At this point if you are using xterm less than version 535 you will
see on your screen "12456" instead of "123456".
Changing the TERM variable to "linux" will still allow you to have all
the same functionality with colorization, ansi character escapes
etc..., but will avoid the extra xterm specific escape sequence that
only exists in the most recent versions of xterm.
This patch allows the end user to set the serial terminal type to
something other than the new default of "linux" by changing the
SERIAL_TERM variable in local.conf. For example:
SERIAL_TERM = "xterm"
Signed-off-by: Jason Wessel <jason.wessel@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Jason Wessel [Mon, 2 Nov 2020 22:28:51 +0000 (14:28 -0800)]
base-files/profile: Add universal resize function
Using an editor or any kind of command line that wraps beyond the
column width of the session on a serial port is quite problematic
unless you are using an 80x24 session.
The original /etc/profile tried to use the resize binary if it was
available. The problem is that you only get the resize binary if
xterm, or busybox is installed.
This updated /etc/profile will add a resize function available to the
shell when no xterm or busybox resize binary is found. More care is
taken in this new version to test that terminal is interactive. The
EDITOR and SHLVL environment variables are checked to prevent resize
from running necessarily.
The function definitions are not indented intentionally to keep them
to the 80 column width.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
