Fabio Estevam [Sun, 25 Oct 2015 22:07:01 +0000 (20:07 -0200)]
linux-fslc (4.1): Update to latest version fa868c9e
Commit fa868c9e ("dts: imx6: fix sd card gpio polarity specified in
device tree") missed to be applied into 4.1.11 causing esdhc regressions
on mx6, so let's apply it so that we can have SD card working with
4.1.11.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Sat, 24 Oct 2015 20:42:26 +0000 (18:42 -0200)]
linux-timesys: Remove unused kernel
The Vybrid reference board (twr-vf65gs10) now uses the linux-fslc
(4.1) kernel. This makes this kernel recipe unused. Remove it as it
has known security flaws, toolchain problems and is quite old.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Stefan Agner [Sat, 24 Oct 2015 05:49:34 +0000 (22:49 -0700)]
twr-vf65gs10: move to Linux 4.1 based linux-fslc tree
Change the default Kernel to the linux-fslc 4.1 kernel.
What seems to work:
- UART
- CPU/Memory (obviously) and L2 Cache
- ARM global timer as clock source
- Pinctrl/GPIO support
- SD-Card
- USB Host (according to bootlog, not tested)
- SoC internal RTC (SNVS RTC)
- Watchdog
Not tested, but should be working:
- Audio using SGTL5000 connected via SAI (hardware not available)
- DCU Framebuffer device (hardware not available)
- Ethernet PHYs (not sure, might be a hardware issue)
Known to be missing:
- Spansion Flash S25FL128S connected via QuadSPI
- MCC v1 and v2
- Touchscreen with TWR-LCD-RGB (according to Tony)
Signed-off-by: Stefan Agner <stefan.agner@toradex.com> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Andreas Müller [Thu, 22 Oct 2015 19:11:12 +0000 (21:11 +0200)]
efl: fix build with current master meta-oe/oe-core
fixes:
| In file included from /home/a.mueller/tmp/oe-core-glibc/sysroots/zeravarimx6q/usr/include/EGL/eglplatform.h:38:0,
| from /home/a.mueller/tmp/oe-core-glibc/sysroots/zeravarimx6q/usr/include/EGL/egl.h:39,
| from ../src/modules/evas/engines/gl_common/evas_gl_api_ext.h:7,
| from ../src/modules/evas/engines/gl_common/evas_gl_core_private.h:5,
| from modules/evas/engines/gl_generic/evas_engine.c:2:
| /home/a.mueller/tmp/oe-core-glibc/sysroots/zeravarimx6q/usr/include/EGL/eglvivante.h:266:2: error: #error "Platform not recognized"
| #error "Platform not recognized"
| ^
Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com>
Daiane Angolini [Thu, 22 Oct 2015 16:10:22 +0000 (14:10 -0200)]
imx6ulevk: Configure machine to use u-boot SPL
At first, this machine was supported only by u-boot-imx U-Boot provider, however
as soon as u-boot-fslc included this support, the U-Boot provider was changed.
During the change of default U-Boot provider, the SPL configuration end up being
missed.
The needed SPL configuration is set up in this patch.
image_types_fsl.bbclass: Fix image generation for i.MX 6UltraLite
When the i.MX 6UltraLite (mx6ul) was separated from the SoC family mx6
(commit 24396b28f0137464cd82b9a19f705c1db180ead2) it started to create
invalid sdcard images.
This is because of SDCARD_GENERATION_COMMAND no more being triggered.
The solution in this moment is add a mx6ul override for the
SDCARD_GENERATION_COMMAND definition.
Signed-off-by: Felipe Provenzano <felipeprovenzano@maxtrack.com.br> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Tue, 20 Oct 2015 11:47:25 +0000 (09:47 -0200)]
Remove unused patch files
Those patch files were left orphan when upgrading the linux-imx and
u-boot-imx recipes, becoming unused. The removal of them cause no harm
and helps to keep the metadata clean.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Update the U-Boot fork to a 2015.10-rc5 based version. This brings
several fixes for i.MX and Vybrid based systems. Mainly:
cf04ad3 arm: vf610twr: improve memory layout d45fd01 colibri_vf: Fix bstlen field e24bb2b mtd: nand: vf610_nfc: resync with upstream Linux version f861f51 ls102xa: Fix reset hang f532727 imx_watchdog: Add a header file for watchdog registers 040ef8f pcm052: fix MTD partitioning 61903b7 imximage: fix commands other than write_data 835c30e imximage: header.length of 4 is valid
Change-Id: Ifdb607d9a94ef594f3fe37d2b6388dc9a8268106 Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Wed, 14 Oct 2015 18:26:53 +0000 (15:26 -0300)]
image_types_fsl.bbclass: Fail if a Device Tree file is missing
When generating the rootfs we need to include all the referenced
Device Tree files. The code were gracefully checking if the file
existed before building the image however the expected behavior is to
fail.
As consequence of this change, if someone is using a very old kernel
(no Device Tree based) and tries to generate an image, it will fail
until the machine definition is changed to not list Device Tree files
for installation.
Currently all machines supported by meta-fsl-arm BSP are consistent
for the default kernel in use however custom BSP may need to be
changed accordingly.
Change-Id: I548c65c61dfefe24154a455d097032b1598b14d3 Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
The code which copies the boot scripts and Device Tree files is
duplicated across the different image types. This patch reworks this
code to avoid this duplication.
Change-Id: Ib9405067a5419e1b295dfac9e3d3bd9b896d424e Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Stefan Agner [Thu, 15 Oct 2015 05:28:52 +0000 (22:28 -0700)]
linux-fslc (4.1): Add Vybrid SoC to compatible machines
Upstream Linux 4.1 supports the Vybrid SoC quite well, so enable
linux-fslc also for Vybrid SoC's.
Change-Id: I6745b67f4cc4b12ccc6f05754af9241e60731c6a Signed-off-by: Stefan Agner <stefan.agner@toradex.com> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Wed, 14 Oct 2015 17:33:07 +0000 (14:33 -0300)]
imx-base.inc: Set a default provider for u-boot-mxsboot-native
The O.S. Systems Embedded Linux provides an alternative version of
U-Boot and, for completeness, an alternative recipe for
u-boot-mxsboot-native.
The provider, in imx-base.inc, had no default thus raising a
warning. This turns the u-boot-fslc-mxsboot-native as the default
provider but allows custom distributions to override it.
Change-Id: I46799f9ec744a074d95c383561cf0cbddb26e151 Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Wed, 14 Oct 2015 14:36:04 +0000 (11:36 -0300)]
opencv: Use the 2.4 release only
The opencv 3.0 is not tested and does not have the i.MX6 specific
patch ported so we disable it for the i.MX6 SoC from Quad, DualLite,
SoloX and SoloLite families. The 2.4 is used instead.
This fixes following warning:
,----
| NOTE: multiple providers are available for runtime opencv-samples (opencv-samples, opencv)
| NOTE: consider defining a PREFERRED_PROVIDER entry to match opencv-samples
`----
Change-Id: I2f897cdd31dcee9046ee7d28ef4dcadb154ae88c Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Wed, 14 Oct 2015 14:26:01 +0000 (11:26 -0300)]
mesa-gl: Blacklist the recipe for i.MX6 SoCs with GPU
The mesa-gl is not in sure for the i.MX6 SoC from Quad, DualLite,
SoloX and SoloLite families. The full featured, but trimmed, mesa is
used instead.
This fixes following warning:
,----
| NOTE: multiple providers are available for runtime libgl-mesa-dev (mesa, mesa-gl)
| NOTE: consider defining a PREFERRED_PROVIDER entry to match libgl-mesa-dev
| NOTE: multiple providers are available for runtime mesa-driver-swrast (mesa, mesa-gl)
| NOTE: consider defining a PREFERRED_PROVIDER entry to match mesa-driver-swrast
`----
Change-Id: I082b8f7a739e4ea3cfe5f1760c7163d118e9883c Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Zhenhua Luo [Tue, 13 Oct 2015 06:15:55 +0000 (14:15 +0800)]
cryptodev-qoriq: Fix runtime providers so 'cryptodev' is not taken as provider
QorIQ targets should use FSL custom cryprodev instead of the one provided by
poky, fix the runtime providers to ensure 'cryptodev-qoriq' is taken as
provider.
Signed-off-by: Zhenhua Luo <zhenhua.luo@freescale.com> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Tue, 29 Sep 2015 21:22:22 +0000 (18:22 -0300)]
linux-fslc-mx6: Update revision to 964e5a3 revision
The 964e5a3 revision includes the 3.14.54 stable release fixes plus
following changes contributed by Gateworks:
7292dc7 ASoC: add tda1997x codec support aa4ee3d ipu3: keep buffer offset aligned 05608b5 ipu3: fix stripe calculation 30c6d90 thermal: imx: allow crit_delta to be passed in via kernel param 334fc35 arm: dts: add handles to anatop regulators c7a4d85 fec: Russell Kings corruption fix 0c2c11f net: fec: fix the warning found by dma debug b5b53b5 pci: imx6: Add delay after LTSSM transition 6dba6b0 fec_main: add mb() before setting status 05ab2a6 net: fec: fix NULL pointer dereference in fec_enet_timeout_work 07465db drivers: video: mxc: Add support for interlace on hdmi out 3eca3ca imx: thermal: use CPU temperature grade info for thresholds 172ad49 media: pci: tw6869: Implement ENUM_FRAMESIZES ioctl a7d429e media: pci: tw6869: add device registered dev info 957f3fa media: pci: tw6869: initial add cb61124 ARM: dts: imx: fix invalid #address-cells value ea53bf7f imx:busfreq: disable busfreq driver by default e3e114d video: mxc: ldb: use native mode for display timings fa6b13a net: igb: register mii_bus for SerDes w/ external phy 09359b6 net: igb: add phy read/write functions that accept phy addr d6daeac net: igb: add i210/i211 support for phy read/write 00b2ceb video: mxc: add adv739x TV encoder 3117a93 mxc_capture: add tda1997x HDMI receiver video support 9348099 imx: add imx tda1997x i2s DAI support b81d263 mfd: add tda1997x HDMI receiver support dba225f mxc_capture: check for init_camera_struct failure 09f7c1f mxc_capture: add device registration info 1db12fc mxc_hdmi: present sysfs edid as binary data instead of ascii bd0601d mxc_hdmi: enable overflow interrupt after initialization complete d6cc9e6 mxc_ipuv3: show device name for overlay fb a7f44be mxc_ipuv3: show ipu_id/disp_id of registered device e9ea090 regulator: Add LTC3676 support 3e12a168 regulator: core: Fix the init of DT defined fixed regulators 154b8be hwmon: mma8451: add fxos8700 magnetometer support e19d671 hwmon: mma8451: add fxos8700 accel support 760c31c cpufreq: imx: add a 25mV tollerance to the operating point voltages ef2eda1 cpufreq: imx: show soc voltage when debugging b205762d cpufreq: imx: init mutex before it can be used 04bc9ed input: edt-ft5x06 - add device-tree config for screen res and inversion 1ca89b6 Input: edt-ft5x06 - fix an i2c write for M09 support dc5f6c9 Input: edt-ft5x06 - add a missing condition f2854dd Input: edt-ft5x06 - add support for M09 firmware version 390394c Input: edt-ft5x06 - ignore touchdown events 6b60fb3 Input: edt-ft5x06 - adjust delays to conform datasheet 74bceb0 Input: edt-ft5x06 - add DT support 481da81 input: goodix: add invert and rotate support via device-tree 6297f18 input: goodix: add support for performing init sqequence 4746ef3 input: goodix: add device-tree support
For compatibility with the Vivante kernel module build, the following
commit has be also applied:
964e5a3 FSLC: Add busfreq-imx.h header for forward compatibility
Change-Id: I92b566943c7245751b484302f2320b42ec7d761c Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Wed, 7 Oct 2015 01:38:49 +0000 (22:38 -0300)]
kernel-module-imx-gpu-viv: Fork driver for FSL Community
The driver source code provided by Freescale needs fixes. This fork is
a community driven development and allow faster development and easier
integration of fixes.
The "+fslc" suffix is added to the module during probing to make a
clear identification.
Change-Id: I914f1a7731263effdef75827e3a9fb8daba37ec9 Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Wed, 7 Oct 2015 18:28:22 +0000 (15:28 -0300)]
imx-base.inc: Ensure MACHINE_HAS_VIVANTE_KERNEL_DRIVER_SUPPORT is expanded
The MACHINE_HAS_VIVANTE_KERNEL_DRIVER_SUPPORT needs to be expanded and
cannot have a default overriden later, otherwise it does not respect
the default set in the SoC.
Change-Id: I1d90d173603e6ee258f3e05c7a53e576b3b1f552 Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Wed, 16 Sep 2015 19:04:31 +0000 (16:04 -0300)]
u-boot-fslc: Update to 2015.10-based fork
This updates the fork based on upcoming 2015.10 release. This is
currently based on 2015.10-rc3 tag and offers a very solid release for
start the tests for Yocto Project 2.0 release.
Change-Id: I1d35409a9806a96f8dd538e2b8c2a3520e9104ba Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Gary Thomas [Tue, 6 Oct 2015 16:03:47 +0000 (10:03 -0600)]
kernel-module-imx-gpu-viv: Better work-around for change in name of busfreq-imx.h
The renaming of include/linux/busfreq-imx6.h to include/linux/busfreq-imx.h
is not consistent over the many kernel versions currently being built. This
changeset works around this inconsistency by creating a local symbolic link
to whatever file is actually present in the kernel sources.
Gary Thomas [Mon, 5 Oct 2015 22:09:17 +0000 (16:09 -0600)]
qt4: Fix *.la pollution
Recent [platform dependent] changes to QT_CONFIG_FLAGS allow
some C-preprocessor defines to creep into *.la (libtool) files.
This are not allowed (or even handled) and cause linker errors
when trying to link against these libraries.
This patch removes the incorrect/erroneous preprocessor directives
to leave the *.la files useable once again. The change is done in
a post-processing step to clean up the *.la files as they are only
used externally to this package.
Signed-off-by: Gary Thomas <gary@mlbassoc.com>
Upstream-status: Innapropriate [OE patch causes the problem] Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
--Upgrade gst1.0-fsl-plugin to version 4.0.7 released in 3.14.38-6UL_ga and 3.14.38-6QP_ga releases.
--Add gstreamer-plugins-bad as one of the dependency.
--Imxcompositor enhancement:
1. fix alpha blending capbility query issue of g2d.
2. add zorder feature.
3. add keep ratio feature.
4. find best output format by leverage the total complexity and picture quality.
Signed-off-by: Yuqing Zhu <b54851@freescale.com> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Mon, 21 Sep 2015 20:47:06 +0000 (17:47 -0300)]
Move mxs-base.inc contents to imx-base.inc
The consolidation of all i.MX related base settings allows a more
global view of the settings in place.
One of the reasons for this patch is the fragmentation caused by
i.MX23 and i.MX28 SoCs using mxs-base.inc.
The changes needed to get i.MX23 and i.MX28 SoCs working have been
included in imx-base.inc file already and some values required rework
to apply to specific SoC families to avoid regressions.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Thu, 17 Sep 2015 17:09:14 +0000 (14:09 -0300)]
imx-base.inc, mxs-base.inc: Change default image to sdcard.gz
Replace .sdcard image to sdcard.gz image as a default image type for
all machines.
The SDCard class has the feature of compress the generated .sdcard image.
It can be used to ease the exchange of this image among developers or machines.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Thu, 17 Sep 2015 14:14:10 +0000 (11:14 -0300)]
imx-base.inc, mxs-base.inc: Stop generating tar.bz2 image tarball by default
The tar.bz2 is useful for people using NFS or generating the SD card
image byhand, those can enable this in the board file or in the
local.conf when needed. By default the SD card image should be the
only image built as it is the most commonly used one for initial
development.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Wed, 23 Sep 2015 12:53:31 +0000 (09:53 -0300)]
image_types_fsl.bbclass: Fix DeviceTree copy for FAT partition
The rootfs generation script now runs outside of the deploy directory
so the code need to use the full path for the installed files. This
fixes the rootfs generation process so the files are copied to the FAT
partition, allowing the system to boot.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br> Tested-by: Daiane Angolini <daiane.angolini@freescale.com>
Otavio Salvador [Tue, 22 Sep 2015 22:20:04 +0000 (19:20 -0300)]
kernel-module-imx-gpu-viv: Fix build against 3.14-based kernels - again
The build fail about the bus frequency header (linux/busfreq-imx6.h)
not being found is caused by the mistaken check for the wrong kernel
version.
The regression has been introduced by d476c35
(kernel-module-imx-gpu-viv: Upgrade to 5.0.11.p7.1 for 3.14.38-6QP_ga
release) which has been not properly tested. This patch fixes it,
again, by adding back the removed patch.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Tue, 11 Aug 2015 20:32:47 +0000 (17:32 -0300)]
Enable Vivante kernel driver dynamic provider
The linux-imx.inc based kernels now can dynamically provide the
Vivante kernel driver and satisfy the runtime dependency added for the
Vivante GPU user space libraries. The beauty of this solution is that
it makes ease for 3rd party kernel to reuse the same infrastructure
and use the external module easily.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
kernel-module-imx-gpu-viv: Upgrade to 5.0.11.p7.1 for 3.14.38-6QP_ga release
- Package name is changed to kernel-module-imx-gpu-viv.
- Patch platform-Fix-kernel-version-check-for-3.14-based-ker.patch is no longer required
as the fix has been applied upstream.
- Upgrade to graphics version 5.0.11.p7.1
- Makefile patch will be included in next release.
Signed-off-by: Neena Busireddy <neena.busireddy@freescale.com> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Ting Liu [Wed, 12 Aug 2015 08:51:09 +0000 (16:51 +0800)]
adjust MACHINEOVERRIDES ordering
FILESPATH is in part built by using MACHINEOVERRIDES and the path
is built working right to left. Use =. instead of .= to prepend
(e6500-64b:qoriq-ppc) to (soc:board).
Take t2080rdb-64b as example, change from:
FILESOVERRIDES="powerpc64:t2:t2080:t2080rdb-64b:qoriq-ppc:e6500-64b:poky"
MACHINEOVERRIDES="t2:t2080:t2080rdb-64b:qoriq-ppc:e6500-64b"
To:
FILESOVERRIDES="powerpc64:e6500-64b:qoriq-ppc:t2:t2080:t2080rdb-64b:poky"
MACHINEOVERRIDES="e6500-64b:qoriq-ppc:t2:t2080:t2080rdb-64b"
Otavio Salvador [Wed, 16 Sep 2015 05:34:20 +0000 (13:34 +0800)]
openssl-qoriq: Fix runtime providers so 'openssl' is not taken as provider
Fix the following parse error:
ERROR: Multiple .bb files are due to be built which each provide openssl
(.../meta-freescale/recipes-connectivity/openssl/openssl-qoriq_1.0.1i.bb
/poky/meta/recipes-connectivity/openssl/openssl_1.0.2d.bb). This usually
means one provides something the other doesn't and should.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Lauren Post [Thu, 17 Sep 2015 19:27:42 +0000 (14:27 -0500)]
imx-gpu-viv: Update to 5.0.11-p7.1 version
Upgrade to 5.0.11 P7.1 for i.MX6 with GPU
i.MX6QP qualified graphics driver(5.0.11P7.1).
Includes many of the bug fixes and stability improvements.
For more information refer to release notes from http://www.freescale.com/imx6qp
libGAL_egl no longer provided in p7.1 so removed from include
Signed-off-by: Lauren Post <lauren.post@freescale.com> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
These are not portable features and are flagged by clang
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Ross Burton <ross.burton@intel.com>
Broke the directfb build as the new patch has been applied in the .inc
file and was unconditionally being included. The patch was include for
new versions of DirectFB and we ought to avoid including changes from
OE-Core, for this recipe, without notice.
It is likely the patch needs to be ported later for the forked
DirectFB recipe but this is should be done afterwards.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Mon, 14 Sep 2015 18:15:49 +0000 (15:15 -0300)]
imx-gpu-viv: Fix host user contamination in package
The copy of contents must not use the host user when copying the
contents for packaging. This fixes following QA errors as:
,----
| WARNING: QA Issue:
| .../packages-split/imx-gpu-viv-tools/usr/bin/gmem_info is owned by uid
| 1000, which is the same as the user running bitbake. This may be due
| to host contamination [host-user-contaminated]
`----
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Otavio Salvador [Wed, 2 Sep 2015 19:49:45 +0000 (16:49 -0300)]
Rework i.MX6 UltraLite support to not use other i.MX6 code
The i.MX6 UltraLite is very different from the other i.MX6 SoCs and
the current BSP infrastructure needs to be reworked to allow for more
granullar control of the features each SoC provide to control the
changes to be applied for the SoC peripherals support.
For now, it is not possible to express this clearly in the BSP so the
current change is to revert some of the changes done for the i.MX6
UltraLite to be enabled and make sure that the boards using the SoC
does not inherit the 'mx6' override.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Andreas Müller [Sun, 13 Sep 2015 20:36:21 +0000 (22:36 +0200)]
qtbase: follow 5.5 platform configuration style
This one comes up when building for non-x11 / wayland.
for further details see qtbase
commit d04c3d2079e0df79592128a67e115ecb90b08454
Author: Laszlo Agocs <laszlo.agocs@theqtcompany.com>
Date: Mon Mar 2 16:09:22 2015 +0100
eglfs: Pluginize RPi, iMX6 and Mali backends
eglfs does not depend on the device makespecs anymore when it comes to these device
integration backends (hooks). Instead, backends are autodetected by configure.
The name of the preferred plugin is still set in the device makespecs. This
is optional. When not set and there is more than one plugin present in the system,
the environment variable QT_QPA_EGLFS_INTEGRATION will have to be set at runtime.
In the absence of that, the order is undefined.
Change-Id: Ie1ced2c9aa1beff2adb13b4fdea7c499cb5a6aab Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> Reviewed-by: Andy Nichols <andy.nichols@theqtcompany.com> Signed-off-by: Andreas Müller <schnitzeltony@googlemail.com> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
