]> code.ossystems Code Review - openembedded-core.git/log
openembedded-core.git
6 years agopatch/insane: Rework patch fuzz handling
Andreas Müller [Fri, 5 Apr 2019 23:45:56 +0000 (01:45 +0200)]
patch/insane: Rework patch fuzz handling

Currently there are three issues which can be enhanced:

1. Fuzz warnings cannot be configured as errors for hardening. It happened
   often to me that these warnings were overseen and detected after commits
   were already out.
2. The output is too verbose - particularly when more than one file is
   affected. Meanwhile all users should know why patch fuzz check is performed.
   So move links with background information to insane.bbclass.
3. Reduce copy & paste effort slightly by printing PN (nit: <recipe> was not
   a correct suggestion e.g for native extended recipe - see example below)

To achieve patch.py drops patch-fuzz info encapsulated by a header- and footer-
string into log.do_patch. With this insane.bbclass can drop warnings/errors
depending on 'patch-fuzz' in ERROR_QA or WARN_QA. Default remains unchanged:
Spit out warnings only.

A message for two fuzzed patches and 'pact-fuzz' in ERROR_QA now looks like:

| ERROR: autoconf-native-2.69-r11 do_patch: Fuzz detected:
|
| Applying patch autoreconf-exclude.patch
| patching file bin/autoreconf.in
| Hunk #1 succeeded at 73 with fuzz 1 (offset -3 lines).
| Hunk #2 succeeded at 143 (offset 6 lines).
| Hunk #3 succeeded at 167 (offset 6 lines).
| Hunk #4 succeeded at 177 (offset 6 lines).
| Hunk #5 succeeded at 281 (offset 15 lines).
| Hunk #6 succeeded at 399 (offset 15 lines).
| Hunk #7 succeeded at 571 (offset 20 lines).
| Hunk #8 succeeded at 612 (offset 20 lines).
| Hunk #9 succeeded at 636 (offset 20 lines).
| Hunk #10 succeeded at 656 (offset 20 lines).
| Hunk #11 succeeded at 683 (offset 20 lines).
|
| Applying patch autoreconf-gnuconfigize.patch
| patching file bin/autoreconf.in
| Hunk #1 succeeded at 55 with fuzz 1 (offset -3 lines).
| Hunk #3 succeeded at 663 (offset 18 lines).
|
| The context lines in the patches can be updated with devtool:
|
|     devtool modify autoconf-native
|     devtool finish --force-patch-refresh autoconf-native <layer_path>
|
| Don't forget to review changes done by devtool!
|
| ERROR: autoconf-native-2.69-r11 do_patch: QA Issue: Patch log indicates that patches do not apply cleanly. [patch-fuzz]

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolib/oe/utils: Make prune_suffix prune a suffix
Andre Rosa [Sat, 6 Apr 2019 01:28:25 +0000 (01:28 +0000)]
lib/oe/utils: Make prune_suffix prune a suffix

... instead of replacing a substring that could happen more than once and not only when it ends with it. Do the same for the prefix.

See related https://github.com/openembedded/bitbake/pull/24 . There it stops replacing sufixes once first one is matched but not here.

Signed-off-by: Andre Rosa <andre.rosa@lge.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoautoconf: update runtime perl module dependencies
Randy MacLeod [Sat, 6 Apr 2019 00:32:10 +0000 (20:32 -0400)]
autoconf: update runtime perl module dependencies

Running:
   # autoreconf -if
on target for prelink-cross was failing due to missing perl modules:
   Can't locate File/Spec.pm in @INC ...

Add the required perl modules and duplicate them for the SDK.

Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agosanity: clarify error message if TMPDIR moves
Ross Burton [Fri, 5 Apr 2019 20:00:05 +0000 (21:00 +0100)]
sanity: clarify error message if TMPDIR moves

If TMPDIR is moved the error message says "move it back or rebuild" but the
obvious rebuild method of running 'bitbake [recipe]] -cclean' fails with the
same error.

Make it clear what we mean by adding "delete and".

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoghostscript: Fix 3 CVEs
Ovidiu Panait [Fri, 5 Apr 2019 14:56:31 +0000 (17:56 +0300)]
ghostscript: Fix 3 CVEs

It was discovered that the ghostscript /invalidaccess checks fail under
certain conditions. An attacker could possibly exploit this to bypass
the -dSAFER protection and, for example, execute arbitrary shell commands
via a specially crafted PostScript document.

It was found that the superexec operator was available in the internal
dictionary in ghostscript before 9.27. A specially crafted PostScript
file could use this flaw in order to, for example, have access to the
file system outside of the constrains imposed by -dSAFER.

It was found that the forceput operator could be extracted from the
DefineResource method in ghostscript before 9.27. A specially crafted
PostScript file could use this flaw in order to, for example, have
access to the file system outside of the constrains imposed by -dSAFER.

References:
https://nvd.nist.gov/vuln/detail/CVE-2019-6116
https://www.openwall.com/lists/oss-security/2019/01/23/5
https://nvd.nist.gov/vuln/detail/CVE-2019-3835
https://nvd.nist.gov/vuln/detail/CVE-2019-3838

Upstream patches:
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=13b0a36
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=2db98f9
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=99f1309
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=59d8f4d
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=2768d1a
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=49c8092
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=2ff600a
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=779664d
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=e8acf6d
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=2055917
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=d683d1e
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=ed9fcd9
http://git.ghostscript.com/?p=ghostpdl.git;a=commitdiff;h=a82601e

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoxf86-video-vesa: Refuse to run on UEFI machines
Ovidiu Panait [Fri, 5 Apr 2019 11:19:42 +0000 (14:19 +0300)]
xf86-video-vesa: Refuse to run on UEFI machines

Fix the following Xorg start failure on UEFI machines when using xf86-video-vesa
driver (e.g. in qemu, when anaconda tries to start X):
Xorg -br -logfile /tmp/X.log :1 vt7 -s 1440 -ac -nolisten tcp -dpi 96 -noreset
...
(EE) Cannot run in framebuffer mode. Please specify busIDs for all framebuffer devices
...

Upstream patch:
https://cgit.freedesktop.org/xorg/driver/xf86-video-vesa/commit/?id=2645e0aa9c17c2c966a0533e52ad00510311483e

Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolibgcc: Create linux-musleabihf and linux-gnueabihf symlinks
Khem Raj [Thu, 4 Apr 2019 05:49:32 +0000 (22:49 -0700)]
libgcc: Create linux-musleabihf and linux-gnueabihf symlinks

When we have hard-float ABI enabled, certain tools e.g. llvm/clang
expects the hf version of tuples for crt files from libgcc, therefore
create a symlink to help the cause.

This makes clang work with hard-float defaults on target

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agodevtool: standard: Handle exporting generated config fragments
Nathan Rossi [Wed, 3 Apr 2019 05:37:02 +0000 (05:37 +0000)]
devtool: standard: Handle exporting generated config fragments

The cml1 and ccmake bbclasses generate configuration fragment source
files that must be exported from the WORKDIR as a source file to be
preserved across builds. This change adds detection of the current
recipes inherited classes and for cml1 and ccmake classes checks for the
specific generated configuration fragment files. These files are then
exported by devtool and included as SRC_URI files from within the target
layer.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoccmake.bbclass: Create a cml1 style class for the CMake curses UI
Nathan Rossi [Wed, 3 Apr 2019 05:37:02 +0000 (05:37 +0000)]
ccmake.bbclass: Create a cml1 style class for the CMake curses UI

The ccmake bbclass implements two tasks. The first task 'ccmake'
preserves the configured state of CMakeCache.txt (generated from the
configure task) and invokes the 'ccmake' program within a oe_terminal
execution. The user can then review, select and modify configuration
options and once satisfied with the configuration exit ccmake. Once
ccmake has exited the build can be run and the updated configuration
should be reflected in the output build.

The ccmake bbclass has a second task 'ccmake_diffconfig' to compute the
differences in configuration which was modified by ccmake. Since there
are many ways to persist the configuration changes within recipes and
layer configuration, the differences are emitted as a bitbake recipe
fragment (configuration.inc) using EXTRA_OECMAKE as well as a CMake
script file which can be used as a input to cmake via the '-C' argument.
Both files are generated in the WORKDIR of the build and the paths to
the files are written as output from the build. It is then up to the
user to take this configuration and apply it to the desired location.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agocmake-native: Enable ccmake by default and depend on ncurses
Nathan Rossi [Wed, 3 Apr 2019 05:37:02 +0000 (05:37 +0000)]
cmake-native: Enable ccmake by default and depend on ncurses

Enable the building of the curses based ui for cmake. This depends on
ncurses.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agogtk+: update for new catalog path
Ross Burton [Thu, 4 Apr 2019 22:16:44 +0000 (23:16 +0100)]
gtk+: update for new catalog path

The XML catalogue is now at the canonical path, ${sysconfdir}/xml/catalog.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoxmlto: clean up RDEPENDS
Ross Burton [Thu, 4 Apr 2019 22:16:43 +0000 (23:16 +0100)]
xmlto: clean up RDEPENDS

Because of differences in how RDEPENDS works for native/target, add libxml2 and
libxslt to RDEPENDS (so that native dependencies work), but also add
libxml2-utils (for xmllint) and libxslt-bin (for xsltproc) to target RDEPENDS.

Also add libxml2-native to DEPENDS as that is needed for the
docbook-(xml,xsl)-native catalog to be generated.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoxmlto: remove XML catalog
Ross Burton [Thu, 4 Apr 2019 22:16:42 +0000 (23:16 +0100)]
xmlto: remove XML catalog

Now that docbook-xml and docbook-xsl use the xmlcatalog class, xmlto can stop
shipping a hand-coded catalogue.

It still needs to keep the wrapper so that the sysroot catalog is used instead
of /etc/xml/catalog.  The wrapper is native-specific so mark it as such.

Note that this does effectively break xmlto on the target as the xmlcatalog
class doesn't write a catalog for the target yet, but I'm hoping that nobody
actually uses it on target.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoasciidoc: use correct XML catalog path
Ross Burton [Thu, 4 Apr 2019 22:16:41 +0000 (23:16 +0100)]
asciidoc: use correct XML catalog path

Now that docbook-xml and docbook-xsl are writing catalog files, tell
xmllint/xsltproc where the catalog is.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolibxslt: update for new catalog path
Ross Burton [Thu, 4 Apr 2019 22:16:40 +0000 (23:16 +0100)]
libxslt: update for new catalog path

The XML catalogue is now at the canonical path, ${sysconfdir}/xml/catalog.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agodocbook-xsl: use xmlcatalog
Ross Burton [Thu, 4 Apr 2019 22:16:39 +0000 (23:16 +0100)]
docbook-xsl: use xmlcatalog

There is no need to ship a static catalog that we have to patch, as upstream
comes with a catalog fragment.

Use the xmlcatalog class to register this catalog.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agodocbook-xsl: neaten documentation
Ross Burton [Thu, 4 Apr 2019 22:16:38 +0000 (23:16 +0100)]
docbook-xsl: neaten documentation

Tidy up the install task and don't version the directory under ${docdir}.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agodocbook-xml: use xmlcatalog class
Ross Burton [Thu, 4 Apr 2019 22:16:37 +0000 (23:16 +0100)]
docbook-xml: use xmlcatalog class

Instead of shipping a static catalog and patching it for native builds, use
libxml2-native to generate a catalog with the correct paths.

Use the xmlcatalog class to register this catalog automatically.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoxmlcatalog: new class to update the XML catalogue
Ross Burton [Thu, 4 Apr 2019 22:16:36 +0000 (23:16 +0100)]
xmlcatalog: new class to update the XML catalogue

This is a new class to handle recipes that need to add/remove entries in the XML
Catalog(ue)[1].  In the future it will handle updating the catalogue on the
target, but the immediate requirement is during the build so currently this only
works with native recipes.

Note that as this is a new class and target use hasn't been implemented yet, it
is possible that the behaviour of this class will change.

[1] https://en.wikipedia.org/wiki/XML_catalog

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolttng-tools: lttng-tools works fine on musl no need to remove it
Jonathan Rajotte [Thu, 4 Apr 2019 21:47:43 +0000 (21:47 +0000)]
lttng-tools: lttng-tools works fine on musl no need to remove it

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolttng-ust: lttng-ust works fine on musl no need to remove it
Jonathan Rajotte [Thu, 4 Apr 2019 21:47:42 +0000 (21:47 +0000)]
lttng-ust: lttng-ust works fine on musl no need to remove it

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolttng-ust: backport musl workaround
Jonathan Rajotte [Thu, 4 Apr 2019 21:47:41 +0000 (21:47 +0000)]
lttng-ust: backport musl workaround

musl implementation for _SC_NPROCESSORS_CONF is a bit fishy.

[1] https://www.openwall.com/lists/musl/2019/03/15/5

Anyway, we implemented a fallback.

This patch should be gone by next recipe update.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolttng-tools: improve ptest and test suite
Jonathan Rajotte [Thu, 4 Apr 2019 21:47:40 +0000 (21:47 +0000)]
lttng-tools: improve ptest and test suite

Multiple patches are to be applied to improve the current ptest suite.

0001-Fix-tests-link-libpause_consumer-on-liblttng-ctl.patch
0002-Fix-test-skip-test_getcpu_override-on-single-thread-.patch
0003-Fix-test-unit-the-tree-origin-can-be-a-symlink-itsel.patch
0006-Tests-check-for-lttng-modules-presence.patch

All deal with problem in the test suite. Most of these are already
accepted upstream and will be removed on the next recipe update.

0004-Skip-when-testapp-is-not-present.patch

Is a OE specific fix that make sure that we skip the test if
the test util application (event generator) is not present. We are
still unsure on how (upstream) we are going to solve this problem. We
already have this problem if a user build lttng without lttng-ust
(--without-lttng-ust). We will most probably end up splitting each test
into kernel and userspace tests and adjust the makefile accordingly.
Another option is to probe lttng for enabled function at runtime.

0005-Tests-use-modprobe-to-test-for-the-presence-of-lttng.patch

Is a requirement for 0006 that should be accepted upstream shorlty.

0007-Fix-getgrnam-is-not-MT-Safe-use-getgrnam_r.patch

Fixes a race found while testing OE built with musl. This is a legit
bug. The fixes or a variant should be accepted soon.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobase/pixbufcache: Remove obsolete sstatecompletions code
Richard Purdie [Thu, 4 Apr 2019 11:00:41 +0000 (12:00 +0100)]
base/pixbufcache: Remove obsolete sstatecompletions code

This has been unused in OE-Core since the introduction of recipe specific
sysroots. Its not so useful since it only runs once upon sstate installation,
not per installation per sysroot.

Remove the weird looking comment left behind in pixbufcache too.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoresulttool/manualexecution: Refactor and simplify codebase
Yeoh Ee Peng [Thu, 4 Apr 2019 08:48:38 +0000 (16:48 +0800)]
resulttool/manualexecution: Refactor and simplify codebase

Simplify and removed unnecessary codes.
Refactor to allow pythonic loop.

Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoresulttool/manualexecution: Fixed step sorted by integer
Yeoh Ee Peng [Thu, 4 Apr 2019 08:48:37 +0000 (16:48 +0800)]
resulttool/manualexecution: Fixed step sorted by integer

Currently the manual execution display step by sorting
the step as string, where steps were not being sorted
correctly when there are more than 9 steps.

Fixed the step sorting by sorting step as integer.

Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoresulttool/manualexecution: Enable display full steps without press enter
Yeoh Ee Peng [Thu, 4 Apr 2019 08:48:36 +0000 (16:48 +0800)]
resulttool/manualexecution: Enable display full steps without press enter

Current manualexecution required pressing enter button to show each step
information, where this was wasting execution time. Enable display
full steps without needing to any press enter button.

Signed-off-by: Mazliana <mazliana.mohamad@intel.com>
Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoresulttool/manualexecution: Standardize input check
Yeoh Ee Peng [Thu, 4 Apr 2019 08:48:35 +0000 (16:48 +0800)]
resulttool/manualexecution: Standardize input check

Current input checking does not match the standard input practiced
by QA team. Change the input checking to match the standard
input practiced by the QA team.

Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolibsecret: remove intltool DEPENDS
Ross Burton [Wed, 3 Apr 2019 15:44:28 +0000 (16:44 +0100)]
libsecret: remove intltool DEPENDS

libsecret 0.18.7 removed intltool and now uses pure gettext.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoutils.py: added sh_quote() function
Enrico Scholz via Openembedded-core [Wed, 3 Apr 2019 15:41:31 +0000 (17:41 +0200)]
utils.py: added sh_quote() function

This function is a wrapper around "shlex.quote()" and can be used in
"${@...}" context where shlex (or pipes, which provides similar
functionality) is unavailable.

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agocore-image-sato-sdk-ptest: Fix free space issues causing test failures
Richard Purdie [Wed, 3 Apr 2019 17:02:41 +0000 (18:02 +0100)]
core-image-sato-sdk-ptest: Fix free space issues causing test failures

Some tests such as strace-ptest require more than the current 500MB of free
space. Increase the amount available, staying under the 4GB limit. We have more
flexibility now since we shrank kernel-devsrc and the comments are out of date
due to that.

This should improve the strace-ptest results and the util-linux ones since
those sort after strace and also hit the space issues as strace-ptest didn't
clean up after itself when failing.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoresulttool: Allow extraction of ptest data
Richard Purdie [Sat, 2 Mar 2019 16:34:16 +0000 (16:34 +0000)]
resulttool: Allow extraction of ptest data

Rather than simply discarding the ptest data, change the code to discard
it when writing out the new testresult files, or optionally either preserve
it, or write it as seperate discrete logs.

This means the autobuilder should start writing out individual ptest log
files as well as allowing ueers to extract these manually.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoresulttool: Allow store to work on single files
Richard Purdie [Tue, 2 Apr 2019 22:51:02 +0000 (23:51 +0100)]
resulttool: Allow store to work on single files

Store operations using a single file as a source weren't working as the os.walk
command didn't like being given a single file. Fix the store operation to
work for single files.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agocmake: 3.14.0 -> 3.14.1
Pascal Bach [Mon, 1 Apr 2019 12:16:54 +0000 (14:16 +0200)]
cmake: 3.14.0 -> 3.14.1

The FindFontconfig module added by 3.14.0 accidentally used uppercase
FONTCONFIG_* variable names that do not match our conventions.
3.14.1 revises the module to use Fontconfig_* variable names.
This is incompatible with 3.14.0 but since the module is new in the
3.14 series usage should not yet be widespread.

Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agotoolchain-shar-extract/init-install-efi-testfs: Unify question spaces
Gianfranco Costamagna [Fri, 29 Mar 2019 09:32:12 +0000 (10:32 +0100)]
toolchain-shar-extract/init-install-efi-testfs: Unify question spaces

unify the spacing for questions in various places e.g. before the [Y/n]
there should be a space, and before "?" there should be none. Unify the
questions where the system expect an answer from the end user.

Signed-off-by: Gianfranco Costamagna <costamagnagianfranco@yahoo.it>
Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoasciidoc: specify XML catalogue to use
Ross Burton [Tue, 2 Apr 2019 16:52:07 +0000 (17:52 +0100)]
asciidoc: specify XML catalogue to use

libxml-native by default uses a XML catalogue at /etc/xml/catalog, instead of
the one in the sysroot.  Until this is fixed (#13260) override the XML catalogue
manually in the recipe to point explicitly at the docbook-xml and docbook-xsl
catalogues.

This fixes either complete build failures (where the host doesn't have
docbook-xml installed) or slow builds (where the host doesn't have docbook-xsl
installed).

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agowic/engine: Add missing newline
Richard Purdie [Wed, 3 Apr 2019 11:52:48 +0000 (12:52 +0100)]
wic/engine: Add missing newline

On some hosts the wic.Wic2.test_wic_cp_ext selftest was failing as files weren't
being copied into the rootfs with "wic cp". This was due to a bug added by:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=89d4a8df074598cfb3a76e41db7c45d845afd961

where there should be a second newline added at the end of the expression due
to the difference in the way echo -e and printf behave.

[YOCTO #13237]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoarch-arm64.inc: Lower the priority of aarch64 in MACHINEOVERRIDES
Peter Kjellerstedt [Tue, 2 Apr 2019 19:31:03 +0000 (21:31 +0200)]
arch-arm64.inc: Lower the priority of aarch64 in MACHINEOVERRIDES

This makes sure, e.g., ${SOC_FAMILY} and ${MACHINE} have higher
priorities than aarch64.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoperl: Don't use TARGET_ARCH in filepaths
William A. Kennington III via Openembedded-core [Tue, 2 Apr 2019 21:53:47 +0000 (14:53 -0700)]
perl: Don't use TARGET_ARCH in filepaths

Platforms like powerpc64le have different variants of the same target.
Perl guesses that the target should be called powerpc64le-linux, while
TARGET_ARCH think it is called ppc64le-linux. If we use TARGET_ARCH
for perl-native on powerpc64le this build will fail since the
post-install rm command won't reference and existing file.

We know that there is only one arch existing per build, so use a
wildcard for finding the path instead of trying to guess the correct
architecture name.

Signed-off-by: William A. Kennington III <wak@google.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoarch-armv8a.inc: Correct PACKAGE_EXTRA_ARCHS_tune-armv8a-*
Peter Kjellerstedt [Tue, 2 Apr 2019 19:30:59 +0000 (21:30 +0200)]
arch-armv8a.inc: Correct PACKAGE_EXTRA_ARCHS_tune-armv8a-*

The armv8a tune specific PACKAGE_EXTRA_ARCHS contained tune feature
names like "crc" and "crypto" rather than package architecture names
like "armv8a-crc" and "armv8a-crypto".

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agollvm: fix link error for powerpc
Changqing Li [Tue, 2 Apr 2019 00:43:03 +0000 (08:43 +0800)]
llvm: fix link error for powerpc

fix below link error for powerpc

lib/libLLVMSupport.a(CommandLine.cpp.o): in function `llvm::cl::opt_storage<(anonymous namespace):
:HelpPrinterWrapper, true, true>::setLocation(llvm::cl::Option&, (anonymous namespace)::HelpPrinterWrapper&) [clone .isra.189]':
/usr/src/debug/llvm/8.0-r0/git/llvm/include/llvm/Support/CommandLine.h:1218:(.text.startup+0x5c):
relocation truncated to fit: R_PPC_PLTREL24 against symbol `llvm::errs()' defined in .text section in lib/libLLVMSupport.a(raw_ostream.cpp.o)+8000
lib/libLLVMSupport.a(CommandLine.cpp.o): in function `setLocation':

Signed-off-by: Changqing Li <changqing.li@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoresulttool: Enable report for single result file
Yeoh Ee Peng [Tue, 2 Apr 2019 06:38:03 +0000 (14:38 +0800)]
resulttool: Enable report for single result file

Current validation check function inside resulttool disallow the
report for single result file although the underlying library
was able to handle both directory and file as source input to report.
Removed the validation check as it was no longer needed and to
enable report for single result file.

Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agocml1.bbclass: Use POSIX sh instead of var-SHELL
Nathan Rossi [Tue, 2 Apr 2019 08:17:39 +0000 (08:17 +0000)]
cml1.bbclass: Use POSIX sh instead of var-SHELL

Use the default POSIX sh instead of relying of var-SHELL being set to a
compatible shell. Such that in cases where SHELL is set to a
incompatible shell (e.g. csh, zsh, fish, etc.) the terminal command does
not just silently fail.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoterminal.bbclass: Generate do_terminal as bitbake would
Nathan Rossi [Tue, 2 Apr 2019 08:17:39 +0000 (08:17 +0000)]
terminal.bbclass: Generate do_terminal as bitbake would

This changes the runfile that is generated to have the same behaviour as
bitbake with regards to emitting the shebang and trap code. The existing
implementation used 'env' with the current var-SHELL. This means that if
the user has configured there system/environment with a alternate shell
(e.g. csh, zsh, fish, etc.) the do_terminal function would attempt to
execute with the wrong/incompatible shell and fail silently.

With this change devshell and other classes that rely on terminal can
now run when the var-SHELL is not set to a sh compatible shell. For
devshell, it will launch the devshell with the users configured shell.

Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agowebkitgtk: 2.22.6 -> 2.22.7
Kai Kang [Tue, 2 Apr 2019 07:44:27 +0000 (03:44 -0400)]
webkitgtk: 2.22.6 -> 2.22.7

webkitgtk 2.22.7 is a bug fix release in the stable 2.22 series.

* Fix rendering of glyphs in Hebrew (and possibly other languages) when
  Unicode NFC normalization is used.
* Fix several crashes and race conditions.

See https://www.webkitgtk.org/2019/03/01/webkitgtk2.22.7-released.html

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoavahi: fix CVE-2017-6519
Kai Kang [Tue, 2 Apr 2019 07:44:26 +0000 (03:44 -0400)]
avahi: fix CVE-2017-6519

Backport patch to fix CVE-2017-6519.

CVE: CVE-2017-6519

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobase.bbclass, staging.bbclass: Move prepare_recipe_sysroot task dependency
Peter Kjellerstedt [Tue, 2 Apr 2019 18:38:10 +0000 (20:38 +0200)]
base.bbclass, staging.bbclass: Move prepare_recipe_sysroot task dependency

Move prepare_recipe_sysroot's task dependency on populate_sysroot from
base.bbclass (where it was specified in the middle of do_configure's
definition) to staging.bbclass (where the rest of
do_prepare_recipe_sysroot is defined). This was a left-over from when
recipe specific sysroots were introduced in commit 809746f5 and the
task dependency on populate_sysroot was moved from do_configure to
do_prepare_recipe_sysroot.

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agotzdata: Install everything by default
Paul Barker [Tue, 2 Apr 2019 14:15:38 +0000 (15:15 +0100)]
tzdata: Install everything by default

tzdata is converted to an empty meta package which pulls in all
subpackages. The subpackages are defined in a TZ_PACKAGES variable so
that we don't have to repeat ourselves.

The timezones and conffiles which were in the tzdata package are moved
to a new 'tzdata-core' package.

Signed-off-by: Paul Barker <paul@betafive.co.uk>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolayer.conf: Update to warrior release name series
Richard Purdie [Mon, 1 Apr 2019 14:52:34 +0000 (15:52 +0100)]
layer.conf: Update to warrior release name series

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobusybox: fix CONFIG_RFKILL enable logic
Matt Porter [Mon, 1 Apr 2019 16:50:34 +0000 (12:50 -0400)]
busybox: fix CONFIG_RFKILL enable logic

Currently CONFIG_RFKILL is enabled only if both bluetooth *and* wifi
distro features are present. It should be enabled when either feature
is present. Fix this by switching to use of bb.utils.contains_any().

Signed-off-by: Matt Porter <mporter@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agopython: improve ptest
Ross Burton [Fri, 29 Mar 2019 22:49:04 +0000 (22:49 +0000)]
python: improve ptest

Add missing runtime dependencies: the test suite needs proper chmod from
coreutils, and the Europe/Minsk timezone.

Also change run-ptest to use -W (run verbosely on failure) instead of -v (always
verbose) to hopefully reduce the noise in the ptest reports.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agokernel-devsrc: fix /usr/src/kernel symlink to also work for SDK
Henrik Nymann Jensen (HNJE) [Fri, 29 Mar 2019 19:14:00 +0000 (19:14 +0000)]
kernel-devsrc: fix /usr/src/kernel symlink to also work for SDK

If kernel-devsrc is used in a SDK context, the symlink from usr/src/kernel
points to an absolute path '/lib/modules/${KERNEL_VERSION}/build',
which ends up pointing to the local machine's build directory.

To address this issue change the symlink to be realtive to
${D}/lib/modules/${KERNEL_VERSION}/build.

Signed-off-by: Henrik Nymann Jensen <hnje@triax.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolibsolv: use GNUInstallDirs
Ross Burton [Mon, 1 Apr 2019 11:22:21 +0000 (12:22 +0100)]
libsolv: use GNUInstallDirs

Backport a patch from upstream to use GNUInstallDirs instead of hand-coded path
logic, so we have proper control over where files end up.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoadwaita-icon-theme: depend on librsvg
Ross Burton [Fri, 29 Mar 2019 14:29:04 +0000 (14:29 +0000)]
adwaita-icon-theme: depend on librsvg

adwaita-icon-theme uses gtk-encode-symbolic-svg to generate icons, so DEPEND on
librsvg-native (and gtk+3-native, via gtk-icon-cache.bbclass) so that this tool
exists and can load SVG files.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoRevert "gtk+3: add librsvg to DEPENDS"
Ross Burton [Fri, 29 Mar 2019 14:29:03 +0000 (14:29 +0000)]
Revert "gtk+3: add librsvg to DEPENDS"

This was added so that adwaita-icon-theme can find the SVG loader for icon
generation, but the fix is in the wrong place.  GTK+ does not depend on librsvg
at all, the tool in GTK+ which loads the icons uses gdk-pixbuf which uses
loadable modules.

This reverts commit 66828ff04d107b7719c9c8857d7c6c2ebf20a8bb.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agopackagegroup-core-base-utils: remove lzip
Ross Burton [Thu, 28 Mar 2019 13:43:48 +0000 (13:43 +0000)]
packagegroup-core-base-utils: remove lzip

lzip is pretty niche: people are typically either sticking with that they know
(gzip, bzip) or using xz.  Data point: only one recipe in oe-core is shipped as
a .lz file.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agollvm: fix more places where '8.0' version of llvm was hardcoded
Alexander Kanavin [Thu, 28 Mar 2019 14:04:23 +0000 (15:04 +0100)]
llvm: fix more places where '8.0' version of llvm was hardcoded

So that it says '8.0.0' to reflect the recent PV change.

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobinutils: set CVE_VERSION
Ross Burton [Thu, 28 Mar 2019 14:41:05 +0000 (14:41 +0000)]
binutils: set CVE_VERSION

PV is 2.32.0 even though the actual release upstream is 2.32.  To a human this
is insignificant, but to automated tooling it matters.  Specifically,
cve-check-tool can't identify CVEs that are in 2.32.

Set CVE_VERSION for now, which should be removed when PV and the upstream
version match again.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agonasm: add CVE_PRODUCT
Chen Qi [Fri, 29 Mar 2019 07:33:02 +0000 (15:33 +0800)]
nasm: add CVE_PRODUCT

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoxserver-xorg: set CVE_PRODUCT
Chen Qi [Fri, 29 Mar 2019 07:07:23 +0000 (15:07 +0800)]
xserver-xorg: set CVE_PRODUCT

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agosqlite3: fix CVE-2019-9936 and CVE-2019-9937
Ross Burton [Thu, 28 Mar 2019 23:30:04 +0000 (23:30 +0000)]
sqlite3: fix CVE-2019-9936 and CVE-2019-9937

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agomachine: clean up config files
Jon Mason [Thu, 28 Mar 2019 18:55:53 +0000 (14:55 -0400)]
machine: clean up config files

Beautify the machine config files by making the names and descriptions
more uniform and verbose

Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agollvm: support older toolchains
Ross Burton [Thu, 28 Mar 2019 12:35:29 +0000 (12:35 +0000)]
llvm: support older toolchains

LLVM is now warning if your host compiler is gcc <5.1, and some of our supported
operating systems still only have 4.8.5.  Set
LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN so those builds continue to work, hopefully
we retire the old operating systems before LLVM requires 5.1+.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agollvm: update from 8.0.0rc2 to 8.0.0 final release
Alexander Kanavin [Wed, 27 Mar 2019 14:09:21 +0000 (15:09 +0100)]
llvm: update from 8.0.0rc2 to 8.0.0 final release

Also, update PV to match the version scheme used by upstream
to tag releases (e.g. major.minor.patch).

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agomesa: update 19.0.0 -> 19.0.1
Alexander Kanavin [Wed, 27 Mar 2019 17:30:18 +0000 (18:30 +0100)]
mesa: update 19.0.0 -> 19.0.1

x.0.0 releases are actually considered 'development' by the upstream,
and true releases are x.0.1:

https://www.mesa3d.org/relnotes/19.0.0.html

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agogcc-8.3: add back GLIBC_DYNAMIC_LINKER riscv changes
Ricardo Salveti [Tue, 26 Mar 2019 18:07:35 +0000 (15:07 -0300)]
gcc-8.3: add back GLIBC_DYNAMIC_LINKER riscv changes

The riscv GLIBC_DYNAMIC_LINKER changes were dropped during the gcc 8.3
update, breaking usrmerge support.

Signed-off-by: Ricardo Salveti <ricardo@foundries.io>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agocmake: 3.13.4 -> 3.14.0
Pascal Bach [Wed, 27 Mar 2019 10:02:52 +0000 (11:02 +0100)]
cmake: 3.13.4 -> 3.14.0

The copyright date changed in the license file, thus the hash change.

CMake 3.14 fixes some issues with implicit include path that lead to
errors with gcc not finding "stdlib.h" etc in include_next.

Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoopenssl: follow OE's rule for specifying CVE ID
Chen Qi [Wed, 27 Mar 2019 09:25:56 +0000 (17:25 +0800)]
openssl: follow OE's rule for specifying CVE ID

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolibarchive: fix up CVE IDs in patches
Chen Qi [Wed, 27 Mar 2019 08:45:51 +0000 (16:45 +0800)]
libarchive: fix up CVE IDs in patches

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoasciidoc: use Python 3 port
Ross Burton [Wed, 27 Mar 2019 14:20:05 +0000 (14:20 +0000)]
asciidoc: use Python 3 port

There's a sort-of-official port of asciidoc to Python 3.  Whilst the official
replacement is asciidoctor which is rewritten in Ruby, this is a fairly trivial
swap and removes Python 2 from core-image-sato builds entirely.

Moving forward we should evaluate asciidoctor, but that can wait.

Change the RDEPENDS so that python3 is only a dependency for target and
nativesdk builds, for native this can use the host python3.

Remove redundant DESTDIR export that isn't needed.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolibexif: fix CVE-2016-6328 and CVE-2018-20030
Ross Burton [Wed, 27 Mar 2019 13:40:38 +0000 (13:40 +0000)]
libexif: fix CVE-2016-6328 and CVE-2018-20030

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agotarget-sdk-provides-dummy: add more perl modules to avoid populate_sdk failure
Vincent Prince [Wed, 27 Mar 2019 12:59:23 +0000 (13:59 +0100)]
target-sdk-provides-dummy: add more perl modules to avoid populate_sdk failure

Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agosystemd: Add pattern matching support to PACKAGECONFIG
Vincent Prince [Wed, 27 Mar 2019 15:45:11 +0000 (16:45 +0100)]
systemd: Add pattern matching support to PACKAGECONFIG

libpcre2 is needed to enable grep option to journalctl.

Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agollvm: don't inherit perlnative
Ross Burton [Wed, 27 Mar 2019 23:07:12 +0000 (23:07 +0000)]
llvm: don't inherit perlnative

This doesn't appear to be required at all.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agollvm: doesn't actually need pythonnative
Ross Burton [Wed, 27 Mar 2019 23:07:11 +0000 (23:07 +0000)]
llvm: doesn't actually need pythonnative

LLVM doesn't actually need pythonnative, the host Python2 is sufficient but
cmake's executable searching currently isn't reliable in cross-compilations.

Convince cmake by setting PYTHON_EXECUTABLE to point at python2 in the HOSTTOOLS
directory.  Note that currently LLVM *needs* python2 currently:

https://github.com/llvm-mirror/llvm/blob/master/CMakeLists.txt#L670

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agosysprof: drop obsolete no-update reason
Alexander Kanavin [Wed, 27 Mar 2019 14:09:22 +0000 (15:09 +0100)]
sysprof: drop obsolete no-update reason

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobinutils: fix upstream version check
Alexander Kanavin [Wed, 27 Mar 2019 14:09:20 +0000 (15:09 +0100)]
binutils: fix upstream version check

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agosysklogd: switch SRC_URI to the new, maintained location
Alexander Kanavin [Wed, 27 Mar 2019 14:09:19 +0000 (15:09 +0100)]
sysklogd: switch SRC_URI to the new, maintained location

The previous SRC_URI seems to be gone, and sysklogd hasn't received
any updates there for a long time.

The new location says:

Origin & References

This is the continuation of the original sysklogd by Martin Schulze.
Now maintained by Joachim Nilsson. Please file bug reports, or send
pull requests for bug fixes and proposed extensions at GitHub.

and generally seems credible: http://troglobit.com/

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobmap-tools: fix upstream version check
Alexander Kanavin [Wed, 27 Mar 2019 14:09:18 +0000 (15:09 +0100)]
bmap-tools: fix upstream version check

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoblktool: remove a duplicate patch
Alexander Kanavin [Wed, 27 Mar 2019 15:04:55 +0000 (16:04 +0100)]
blktool: remove a duplicate patch

blktool-gnulib-makedev.patch is actually doing the same
thing as 0004-fix-ftbfs-glibc-2.28.patch, so we end up
including the same file twice.

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoblktool: update to 4-7.1
Alexander Kanavin [Wed, 27 Mar 2019 14:09:17 +0000 (15:09 +0100)]
blktool: update to 4-7.1

This update adds a patch from Debian to match the latest version there.

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agosyslinux: fix upstream version check
Alexander Kanavin [Wed, 27 Mar 2019 14:09:16 +0000 (15:09 +0100)]
syslinux: fix upstream version check

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agodb: fix upstream version check
Alexander Kanavin [Wed, 27 Mar 2019 14:09:15 +0000 (15:09 +0100)]
db: fix upstream version check

The new regex excludes the 5.3.28+dfsg1 which is a Debian
repackaging of the original tarball:

* Repack the .orig tarball to eliminate prebuilt binaries that need a
    Visual Studio plugin to build from source. (Closes: #898215)

https://metadata.ftp-master.debian.org/changelogs/main/d/db5.3/unstable_changelog

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agotimezone: update to 2019a
Armin Kuster [Tue, 26 Mar 2019 16:13:11 +0000 (09:13 -0700)]
timezone: update to 2019a

The 2019a release of the tz code and data is available. It reflects the following changes, which were either circulated on the tz mailing list or are relatively minor technical or administrative changes:

  Briefly:
    Palestine "springs forward" on 2019-03-30 instead of 2019-03-23.
    Metlakatla "fell back" to rejoin Alaska Time on 2019-01-20 at 02:00.

  Changes to past and future timestamps

    Palestine will not start DST until 2019-03-30, instead of 2019-03-23 as
    previously predicted.  Adjust our prediction by guessing that spring
    transitions will be between 24 and 30 March, which matches recent practice
    since 2016.  (Thanks to Even Scharning and Tim Parenti.)

    Metlakatla ended its observance of Pacific standard time,
    rejoining Alaska Time, on 2019-01-20 at 02:00.  (Thanks to Ryan
    Stanley and Tim Parenti.)

  Changes to past timestamps

    Israel observed DST in 1980 (08-02/09-13) and 1984 (05-05/08-25).
    (Thanks to Alois Treindl and Isaac Starkman.)

  Changes to time zone abbreviations

    Etc/UCT is now a backward-compatibility link to Etc/UTC, instead
    of being a separate zone that generates the abbreviation "UCT",
    which nowadays is typically a typo.  (Problem reported by Isiah
    Meadows.)

  Changes to code

    zic now has an -r option to limit the time range of output data.
    For example, 'zic -r @1000000000' limits the output data to
    timestamps starting 1000000000 seconds after the Epoch.
    This helps shrink output size and can be useful for applications
    not needing the full timestamp history, such as TZDIST truncation;
    see Internet RFC 8536 section 5.1.  (Inspired by a feature request
    from Christopher Wong, helped along by bug reports from Wong and
    from Tim Parenti.)

  Changes to documentation

    Mention Internet RFC 8536 (February 2019), which documents TZif.

    tz-link.html now cites tzdata-meta
    <https://tzdata-meta.timtimeonline.com/>.

Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoless: upgrade 549 (terribly broken) -> 550
Andreas Müller [Tue, 26 Mar 2019 15:00:11 +0000 (16:00 +0100)]
less: upgrade 549 (terribly broken) -> 550

Test case:

* open xfce4-terminal
* run 'echo | less'
* press arrow up/down few times
* exit less with 'q'
=> From now on all mouse(wheel) buttons create strange inputs on terminal

Release note says [1]: "Sometimes the terminal was left in mouse-reporting mode
after exiting less."

http://www.greenwoodsoftware.com/less/index.html

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoadwaita-icon-theme: do not delete symbolic svg but pack them in ${PN}-symbolic
Andreas Müller [Tue, 26 Mar 2019 14:21:34 +0000 (15:21 +0100)]
adwaita-icon-theme: do not delete symbolic svg but pack them in ${PN}-symbolic

This fixes:
* gtk-icon-browser: for symbolic view almost all icons were missing
* xfce's thunar: 'home' and 'up' icons were missing. Had a long discussion with
  XFCE-people [1] and asked here [2].

How could I overlook the most obvious...

[1] https://bugzilla.xfce.org/show_bug.cgi?id=14443
[2] http://lists.openembedded.org/pipermail/openembedded-core/2018-November/275815.html

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agogtk+3: add librsvg to DEPENDS
Andreas Müller [Tue, 26 Mar 2019 10:29:19 +0000 (11:29 +0100)]
gtk+3: add librsvg to DEPENDS

adwaita-icon-themes failes to create symbolic icons. In log.do_install when
calling gtk-encode-symbolic-svg there many complaints

| Can't load file: Unrecognized image file format

We fail her now due to:

commit 7f6c57635ff4e1edf7a46c49af34846ad0a4bf73
Author: Alexander Kanavin <alex.kanavin@gmail.com>
Date:   Wed Jan 30 11:59:25 2019 +0100

gtk+3: remove the gtk-icon-utils-native recipe

gtk-icon-utils-native had librsvg in its DEPENDS. We do not add librsvg-native
because same issue would occure for gtk-encode-symbolic-svg on target.

Signed-off-by: Andreas Müller <schnitzeltony@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agosysvinit: consolidate patches
Ross Burton [Tue, 26 Mar 2019 12:02:50 +0000 (12:02 +0000)]
sysvinit: consolidate patches

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agozlib: clean up ptest
Ross Burton [Tue, 26 Mar 2019 12:02:27 +0000 (12:02 +0000)]
zlib: clean up ptest

Instead of patching and sedding the makefile, just install test/example and
execute it in run-ptest.  example is the bulk of the test suite, as minimal as
it is.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoglib: do a build check for strlcpy before runtime
Ross Burton [Tue, 26 Mar 2019 12:02:02 +0000 (12:02 +0000)]
glib: do a build check for strlcpy before runtime

There's no need to do a runtime check for the behaviour of strlcpy if it doesn't
even exist.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agoglib: set glib-specific cross properties
Ross Burton [Tue, 26 Mar 2019 12:01:57 +0000 (12:01 +0000)]
glib: set glib-specific cross properties

GLib wants to execute code to identify several properties of the system, for
example is vsprintf() broken and what direction does the stack grow. In
cross-compiled environments these fallback to the default values which are not
always correct (our vsprintf() is fine, but the test assumes it isn't) so set
these properties explicitly.

Ideally this happens magically by meson.bbclass using the same logic as
siteinfo.bbclass, but we need to fix glib now.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolibsndfile1: fix CVE-2019-3832
Ross Burton [Mon, 25 Mar 2019 23:21:08 +0000 (23:21 +0000)]
libsndfile1: fix CVE-2019-3832

The previous fix for CVE-2018-19758 wasn't complete, so backport another patch
to solve it properly.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agobluez5: fix CVE-2018-10910
Ross Burton [Mon, 25 Mar 2019 23:21:07 +0000 (23:21 +0000)]
bluez5: fix CVE-2018-10910

Fix this CVE (Bluetooth discoverability may be enabled with no agents to handle
requests) by backporting a number of patches from upstream.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agorun-ptest: use error handling for useradd and userdel
Aditya Tayade [Mon, 25 Mar 2019 15:27:11 +0000 (15:27 +0000)]
run-ptest: use error handling for useradd and userdel

Error handling in shell scripts is too easy to forget and
get wrong. It is possible to check every external command
for return values but it is better to use a generic setting
which halts execution of the script on any failures.

Upstream-Status: Pending
Signed-off-by: Aditya Tayade <Aditya.Tayade@kpit.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agowget: Convert EXTRA_OECONF to PACKAGECONFIG, extend PACKAGECONFIG
Alex Kiernan [Mon, 25 Mar 2019 13:27:28 +0000 (13:27 +0000)]
wget: Convert EXTRA_OECONF to PACKAGECONFIG, extend PACKAGECONFIG

Convert existing EXTRA_OECONF and DEPENDS to PACKAGECONFIG, fill out
remaining PACKAGECONFIG options. When building without libpsl we pass in
--without-libpsl, which we didn't previously, but all this actually ends
up doing is silencing a warning from the configure script, the code
still uses an internal implemention when using this option.

Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agooeqa/qemurunner: Dont mix binary and non-binary strings
Richard Purdie [Mon, 25 Mar 2019 10:33:21 +0000 (10:33 +0000)]
oeqa/qemurunner: Dont mix binary and non-binary strings

self.msg is a str(), bootlog is b'' so this code clearly doesn't work. Add
in a decode since its being used as a string.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agomdadm: add -Wno-error to DEBUG_OPTIMIZATION
Changqing Li [Fri, 22 Mar 2019 03:57:48 +0000 (11:57 +0800)]
mdadm: add -Wno-error to DEBUG_OPTIMIZATION

when compile with DEBUG_OPTIMIZATION(-Og), compile failed with below
error, fix by add -Wno-error:

[snip]
| Incremental.c: In function 'Incremental_container':
| Incremental.c:1593:3: error: 'mdfd' may be used uninitialized in this function [-Werror=maybe-uninitialized]
| close(mdfd);
| ^~~~~~~~~~~

[snip]
super-intel.c: In function 'apply_takeover_update':
| super-intel.c:9615:15: error: '%d' directive writing between 1 and 11 bytes into a region of size 7 [-Werror=format-overflow=]
| " MISSING_%d", du->index);
| ^~
...

Signed-off-by: Changqing Li <changqing.li@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agolibpsl: Extend with native, nativesdk
Alex Kiernan [Mon, 25 Mar 2019 09:37:54 +0000 (09:37 +0000)]
libpsl: Extend with native, nativesdk

To allow wget with libpsl to build native/nativesdk versions we need
those variants here.
Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agosystemd: Add PACKAGECONFIG for openssl
Alex Kiernan [Mon, 25 Mar 2019 09:34:49 +0000 (09:34 +0000)]
systemd: Add PACKAGECONFIG for openssl

Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
6 years agodropbear: update to 2019.77
Andrej Valek [Mon, 25 Mar 2019 09:43:54 +0000 (10:43 +0100)]
dropbear: update to 2019.77

 - update dropbear to version 2019.77
 - drop obsolete patch

Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>