Andreas Müller [Tue, 2 Jun 2020 18:37:10 +0000 (20:37 +0200)]
vte: Pack ${libexecdir}/vte-urlencode-cwd to vte-prompt
Have vte-prompt in my images. Since upgrade 0.60.2 all terminals complain with:
| bash: /usr/libexec/vte-urlencode-cwd: No such file or directory
Grepping sources shows that vte.csh and vte.sh are the only callers of
vte-urlencode-cwd. Both are installed by vte-prompt so move vte-urlencode-cwd
where it's used.
Signed-off-by: Andreas Müller <schnitzeltony@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Ralph Siemsen [Tue, 2 Jun 2020 18:21:13 +0000 (14:21 -0400)]
cve-check: include epoch in product version output
In the generated cve.log files, include the epoch in the product
version. This better matches how versions are displayed elsewhere,
in particular the bb.warn("Found unpatched CVE...") that appears
on the terminal when CVEs are found.
Signed-off-by: Ralph Siemsen <ralph.siemsen@linaro.org> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
which can only be caused by the qemu.stop() method not being called.
Tweak the error handling to fix the blanket exception handler which
is likely meaning this function isn't getting called.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
cairo: Do not try to remove nonexistent directories
Commit 0e1f8fa0 (bitbake.conf: propagate 'opengl' DISTRO_FEATURE to
native/nativesdk from target) changed the default PACKAGECONFIG for
native and nativesdk so that it becomes empty unless "x11" is in
DISTRO_FEATURES since "trace" was also removed (propbably
unintentionally). This highlighted than an empty PACKAGECONFIG would
lead to a build failure since /usr/bin is never created under these
conditions, but the recipe still tried to remove it.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Konrad Weihmann [Sun, 31 May 2020 20:57:48 +0000 (22:57 +0200)]
sysfsutils: rem leftover settings for libsysfs-dev
22af6a2595dbec98ce4a2e3b1324ad8d400390ad removed the PACKAGES
setting, but left the FILES-assignments of libsysfs-dev and -staticdev.
As these have no use anymore they can be safely removed
Signed-off-by: Konrad Weihmann <kweihmann@outlook.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
License-Update: http changed to https Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Replace pcre-cross.patch with the (default) option
to use pre-built tables; the README says it's ok, and
recommended in cross-compile situations. The option
was in the recipe from the start and neither the commit
that adds the recipe, nor the patch to make it work explain
why.
License-Update: copyright years Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
License-Update: copyright years Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
License-Update: copyright years, formatting Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
License-Update: additional copyright statements, all BSD Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* With the missing Subject line fixed in GitApplyTree.prepareCommit()
we should be able to revert, the fix which was trying to help it by
parsing GitApplyTree.patch_line_prefix ("%% original patch:") also
from Subject line, now GitApplyTree.patch_line_prefix should always
end on separate line which is then skipped when copying the lines to
resulting patch, see original commit message from Paul:
lib/oe/patch: fix handling of patches with no header
If a patch applied by a recipe has no header and we turn the recipe's
source into a git tree (when PATCHTOOL = "git" or when using devtool
extract / modify / upgrade), the commit message ends up consisting only
of the original filename marker ("%% original patch: filename.patch").
When we come to do turn the commits back into a set of patches in
extractPatches(), this first line ends up in the "Subject: " part of
the file, but we were ignoring it because the line didn't start with the
marker text. The end result was we weren't able to get the original
patch name. Strip off any "Subject [PATCH x/y]" part before looking for
the marker text to fix.
This caused "devtool modify openssl" followed by "devtool update-recipe
openssl" (without any changes in-between) to remove version-script.patch
because that patch has no header and we weren't able to determine the
original filename.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Martin Jansa [Fri, 29 May 2020 22:03:26 +0000 (00:03 +0200)]
lib/oe/patch: GitApplyTree: save 1 echo in commit-msg hook
* also remove the extra blank lines which is often added to patches
when refreshed with devtool (GitApplyTree.patch_line_prefix lines
are ignored when refreshing .patch files, but newly added blank
lines aren't - the leading blank line wasneeded for patches with
just the subject line (to prevent the GitApplyTree.patch_line_prefix
line ending appended to the commit summary), but we can add it
in prepareCommit instead
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Martin Jansa [Fri, 29 May 2020 22:03:25 +0000 (00:03 +0200)]
lib/oe/patch: prevent applying patches without any subject
* this was discovered with
$ devtool finish --force-patch-refresh
where it was removing some patches and replacing them with
patch in filename called "patch:"
e.g. this .patch file:
https://github.com/OSSystems/meta-browser/blob/311067d2d8a50cee5c836892606444f63f2bb3ab/dynamic-layers/rust-layer/recipes-browser/firefox/firefox/fixes/fix-camera-permission-dialg-doesnot-close.patch
confuses devtool which results to create new .patch file called "patch:"
$ devtool finish --force-patch-refresh firefox meta-browser
NOTE: Starting bitbake server...
WARNING: Host distribution "ubuntu-20.04" has not been validated with this version of the build system; you may possibly experience unexpected failures. It is recommended that you use a tested distribution.
Loading cache: 100% |###################################################################################################################################################################################################################################| Time: 0:00:00
Loaded 2480 entries from dependency cache.
Parsing recipes: 100% |#################################################################################################################################################################################################################################| Time: 0:00:00
Parsing of 1718 .bb files complete (1717 cached, 1 parsed). 2480 targets, 68 skipped, 0 masked, 0 errors.
Summary: There was 1 WARNING message shown.
INFO: Updating patch 0001-Bug-1554949-Fix-WebRTC-build-failure-with-newer-linu.patch
...
INFO: Updating patch pre-generated-old-configure.patch
INFO: Adding new patch patch:
INFO: Updating recipe firefox_68.0esr.bb
INFO: Removing file /OE/build/test-oe-build-time/poky/meta-browser/dynamic-layers/rust-layer/recipes-browser/firefox/firefox/fixes/fix-camera-permission-dialg-doesnot-close.patch
INFO: Cleaning sysroot for recipe firefox...
INFO: Leaving source tree /OE/build/test-oe-build-time/poky/build/workspace/sources/firefox as-is; if you no longer need it then please delete it manually
this looked like incorrect parsing of the git format-patch
files exported from workspace/sources (the git format-patch
version of fix-camera-permission-dialg-doesnot-close.patch
starts like this:
$ head 0008-original-patch-fix-camera-permission-dialg-doesnot-c.patch
From 37dfa11961b48024bedcfb9336f49107c9535638 Mon Sep 17 00:00:00 2001
From: Takuro Ashie <ashie@clear-code.com>
Date: Mon, 20 Aug 2018 10:16:20 +0900
Subject: [PATCH 08/34] %% original patch:
fix-camera-permission-dialg-doesnot-close.patch
so first I've modified GitApplyTree.extractPatches() to be able to
parse the original patch name correctly even in this case where subject
is wrapped, but then it still wasn't right, because we ended with
correctly named .patch file, but all we could use for Subject line
was the name of the original .patch file (instead of the Subject
from metadata commit which introduced this .patch files as some other
.patch files get when refreshed with devtool.
In the end the issue happens even sooner in GitApplyTree.prepareCommit()
where it correctly found the Subject from metadata commit, but then
didn't apply it when there weren't any other outlines from patch headers.
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Martin Jansa [Fri, 29 May 2020 22:03:23 +0000 (00:03 +0200)]
devtool: use -f and don't use --exclude-standard when adding files to workspace
* I see a case where a tarball contains .gitignore and bunch of files
which are normally ignored in git, but still included in the tarball
(e.g. configure script next to configure.ac)
* when devtool is creating a git repo in workspace it won't include these
files from tarball in the initial devtool-base commit, because
git ls-files won't list them
* but then the first .patch file (without git headers) when applied with
GitApplyTree._applypatch() will add all these still ignored files to a
commit which used to only modify some files, because it's using -f:
# Add all files
shellcmd = ["git", "add", "-f", "-A", "."]
output += runcmd(["sh", "-c", " ".join(shellcmd)], self.dir)
at least in this case it would be better to add all ignored files in
the initial devtool-base commit and then --force-patch-refresh will just
include the small modification as before instead of adding unrelated
files, just because they were initially ignored - this behavior will
also match with the do_patch task in the actual build where the
.gitignore is ignored when unpacking some tarball
* my use-case is fixed in setup_git_repo, but similar function is in
devtool upgrade, I've changed it there as well
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Khem Raj [Tue, 26 May 2020 23:10:37 +0000 (16:10 -0700)]
armv8/tunes: Set TUNE_PKGARCH_64 based on ARMPKGARCH
The setting is to modify TUNE_PKGARCH which is filled with
TUNE_PKGARCH_64 or TUNE_PKGARCH_32 in arm-arch64.inc
This lets higher up tune files for arm64 SOCs override them if needed,
this can help building multiple armv8 machines with different tunes in
same workspace.
No need to set TUNE_PKGARCH in tune files as it is synthesized from ARMPKGARCH
Add ARMPKGARCH for aarch64 tunes
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Joshua Watt [Thu, 21 May 2020 15:34:55 +0000 (10:34 -0500)]
layer.conf: Bump OE-Core layer version
The commits 910ffaf5be ("pyelftools: Import from meta-python") and a96f815c53 ("pycryptodome: Import from meta-python") moved recipes from
meta-python to oe-core. In order for this to be communicated with users,
bump the LAYERVERSION so that meta-python can key of it in its
LAYERDEPENDS.
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Trevor Gamblin [Thu, 28 May 2020 23:06:45 +0000 (16:06 -0700)]
qemuarm: check serial consoles vs /proc/consoles
Note that this patch affects qemuarm AND qemuarm64.
When booting a VM and during operation, the following message
periodically appears:
INIT: Id "hvc0" respawning too fast: disabled for 5 minutes
This is because hvc0 is specified in SERIAL_CONSOLES in qemuarm.conf
and qemuarm64.conf, but it is not in /proc/consoles and
SERIAL_CONSOLES_CHECK is not specified, leaving getty to attempt to
enable hvc0. Add SERIAL_CONSOLES_CHECK to both conf files so that
hvc0 isn't enabled if it hasn't been set there or in local.conf.
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Wang Mingyu [Thu, 28 May 2020 09:06:00 +0000 (17:06 +0800)]
util-linux: upgrade 2.35.1 -> 2.35.2
0001-hwclock-fix-for-glibc-2.31-settimeofday.patch
0001-kill-include-sys-types.h-before-checking-SYS_pidfd_s.patch
0001-libfdisk-script-accept-sector-size-ignore-unknown-he.patch
are removed since they are included in 2.35.2
Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
hongxu [Thu, 28 May 2020 06:46:40 +0000 (14:46 +0800)]
core-image-minimal-initramfs: keep restriction with initramfs-module-install
Since commit [882ae0dcce core-image-minimal-initramfs: use
initramfs-framework for initialization] applied, it should
keep the restriction with initramfs-module-install
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Wang Mingyu [Thu, 28 May 2020 06:01:11 +0000 (14:01 +0800)]
alsa-lib: upgrade 1.2.1.2 -> 1.2.2
0001-Fix-alsa-sound-.h-for-external-programs.patch
0001-configure.ac-remove-an-unnecessary-libtool-fix.patch
0001-uapi-Move-typedefs-from-uapi-to-sound.patch
0001-ucm-Use-strncmp-to-avoid-access-out-of-boundary.patch
0002-ucm-return-always-at-least-NULL-if-no-list-is-availa.patch
0003-namehint-correct-the-args-check.patch
0004-namehint-improve-the-previous-patch-check-the-return.patch
0005-ucm-Do-not-fail-to-parse-configs-on-cards-with-an-em.patch
removed since they are included in 1.2.2
Signed-off-by: Wang Mingyu <wangmy@cn.fujitsu.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Bruce Ashfield [Fri, 29 May 2020 01:29:19 +0000 (21:29 -0400)]
linux-yocto/5.4: update to v5.4.43
Updating linux-yocto/5.4 to the latest korg -stable release that comprises
the following commits:
e0d81ce76004 Linux 5.4.43 b5100186021a sched/fair: Fix enqueue_task_fair() warning some more 8b13f5657fa8 sched/fair: Fix reordering of enqueue/dequeue_task_fair() a2ad232aa6a9 sched/fair: Reorder enqueue/dequeue_task_fair path f4520daa3c5a tpm: check event log version before reading final events 68b7b8183c12 rxrpc: Fix ack discard 283eb0016f97 rxrpc: Trace discarded ACKs f2da8c0dfe81 iio: adc: stm32-dfsdm: fix device used to request dma 7b5af65ca246 iio: adc: stm32-dfsdm: Use dma_request_chan() instead dma_request_slave_channel() 692001a867b6 iio: adc: stm32-adc: fix device used to request dma 8e8836b2b782 iio: adc: stm32-adc: Use dma_request_chan() instead dma_request_slave_channel() 1084eee4dc5d x86/unwind/orc: Fix unwind_get_return_address_ptr() for inactive tasks 860fe59783a9 flow_dissector: Drop BPF flow dissector prog ref on netns cleanup bd6f0c799f4d s390/kexec_file: fix initrd location for kdump kernel 834d24ec3a0a rxrpc: Fix a memory leak in rxkad_verify_response() 23ae6e3e8aeb rxrpc: Fix the excessive initial retransmission timeout c2a26769b43e kasan: disable branch tracing for core runtime 86217fecc4b7 rapidio: fix an error in get_user_pages_fast() error handling 689dacb2b09d device-dax: don't leak kernel memory to user space after unloading kmem 9e451933bba9 s390/kaslr: add support for R_390_JMP_SLOT relocation type 72f3241508ac s390/pci: Fix s390_mmio_read/write with MIO 9c84884cd5dc ipack: tpci200: fix error return code in tpci200_register() 46f47dda27bc mei: release me_cl object reference f505a3e24c6a tty: serial: add missing spin_lock_init for SiFive serial console a5b4b3f97de7 misc: rtsx: Add short delay after exit from ASPM e64b205035fb iio: adc: ti-ads8344: Fix channel selection 9af65dc54b9b iio: dac: vf610: Fix an error handling path in 'vf610_dac_probe()' d54e5a4ff04c iio: sca3000: Remove an erroneous 'get_device()' 56cff2ac7c9d staging: greybus: Fix uninitialized scalar variable a41e02cb4232 staging: kpc2000: fix error return code in kp2000_pcie_probe() dee81110a488 staging: iio: ad2s1210: Fix SPI reading 76296dc723ef media: fdp1: Fix R-Car M3-N naming in debug message 4adb7a2b3161 Revert "gfs2: Don't demote a glock until its revokes are written" bb6524537dc2 kbuild: Remove debug info from kallsyms linking ee71c590dd8d bpf: Avoid setting bpf insns pages read-only when prog is jited 4c732e81bd4d powerpc/64s: Disable STRICT_KERNEL_RWX b67da9dbdb89 powerpc: Remove STRICT_KERNEL_RWX incompatibility with RELOCATABLE 9bcfbd8ba2b5 drm/i915: Propagate error from completed fences 5e171483e947 drm/i915/gvt: Init DPLL/DDI vreg for virtual display instead of inheritance. 0e1d5f67253e vsprintf: don't obfuscate NULL and error pointers 4b1b34621998 dmaengine: owl: Use correct lock in owl_dma_get_pchan() 0fcbe108b01a dmaengine: dmatest: Restore default for channel 57c32a52c3fe drm/etnaviv: Fix a leak in submit_pin_objects() 432b103596bd dmaengine: tegra210-adma: Fix an error handling path in 'tegra_adma_probe()' 870a45e0b507 apparmor: Fix aa_label refcnt leak in policy_update 054934aa9faa apparmor: fix potential label refcnt leak in aa_change_profile 97d817b9ef13 apparmor: Fix use-after-free in aa_audit_rule_init 3b1e38dfbc9f drm/etnaviv: fix perfmon domain interation 53683907ef68 arm64: Fix PTRACE_SYSEMU semantics 96e56055a2f0 scsi: target: Put lun_ref at end of tmr processing 818657105a0b scsi: qla2xxx: Do not log message when reading port speed via sysfs d54c5eff8795 ALSA: hda/realtek - Add more fixup entries for Clevo machines 80f5822c2bf3 ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Xtreme 1b17a0f98ad0 ALSA: pcm: fix incorrect hw_base increase a44cb2581718 ALSA: iec1712: Initialize STDSP24 properly when using the model=staudio option 99e392a4979b KVM: x86: Fix pkru save/restore when guest CR4.PKE=0, move it to x86.c 1c3d707d7d12 ALSA: hda/realtek: Enable headset mic of ASUS UX581LV with ALC295 26a3a3053332 ALSA: hda/realtek - Enable headset mic of ASUS UX550GE with ALC295 c5742497dcd2 ALSA: hda/realtek - Enable headset mic of ASUS GL503VM with ALC295 2523e9010d2b ALSA: hda/realtek: Add quirk for Samsung Notebook 6cc4dd44e207 ALSA: hda/realtek - Add HP new mute led supported for ALC236 0d189b31c4d7 ALSA: hda/realtek - Add supported new mute Led for HP 69d5dc286d05 ALSA: hda: Manage concurrent reg access more properly 1efaaf74528c ALSA: hda: patch_realtek: fix empty macro usage in if block 749e58bd2b09 ALSA: hda - constify and cleanup static NodeID tables 02ebbd1da394 scripts/gdb: repair rb_first() and rb_last() 9eff404a4382 ARM: futex: Address build warning 67a5c3104d12 KVM: selftests: Fix build for evmcs.h 4f48af814798 drm/amd/display: Prevent dpcd reads with passive dongles e0bb3075f91b iommu/amd: Call domain_flush_complete() in update_domain() e1efb9893bdd platform/x86: asus-nb-wmi: Do not load on Asus T100TA and T200TA c8d323578e36 USB: core: Fix misleading driver bug report 42b32a43529e stmmac: fix pointer check after utilization in stmmac_interrupt b68d27c5fffd ceph: fix double unlock in handle_cap_export() df0df8ee2ac7 HID: quirks: Add HID_QUIRK_NO_INIT_REPORTS quirk for Dell K12A keyboard-dock 8a5de4a391e4 gtp: set NLM_F_MULTI flag in gtp_genl_dump_pdp() 7932168ec08e x86/apic: Move TSC deadline timer debug printk 1ae9f1a62a50 ftrace/selftest: make unresolved cases cause failure if --fail-unresolved set 2eac9d3dc23f ibmvnic: Skip fatal error reset after passive init f82a3013226e x86/mm/cpa: Flush direct map alias during cpa 632db044ab99 HID: i2c-hid: reset Synaptics SYNA2393 on resume acd3efa17d96 scsi: ibmvscsi: Fix WARN_ON during event pool release 6ef21295dc20 net/ena: Fix build warning in ena_xdp_set() d0db69f9d132 component: Silence bind error on -EPROBE_DEFER 7a5f60dc3a67 aquantia: Fix the media type of AQC100 ethernet controller in the driver 445437b417b6 vhost/vsock: fix packet delivery order to monitoring devices dcec6678c3b1 configfs: fix config_item refcnt leak in configfs_rmdir() 2b52a61adb38 scsi: qla2xxx: Delete all sessions before unregister local nvme port d2430cb7f2d4 scsi: qla2xxx: Fix hang when issuing nvme disconnect-all in NPIV 7b481b802a8f HID: alps: ALPS_1657 is too specific; use U1_UNICORN_LEGACY instead a08626f6e982 HID: alps: Add AUI1657 device ID 68988c00b153 HID: multitouch: add eGalaxTouch P80H84 support cc6428803d22 gcc-common.h: Update for GCC 10 3c140d22e3c2 net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report() 87863a7426b2 kbuild: avoid concurrency issue in parallel building dtbs and dtbs_check 44fd02a3d719 mtd: Fix mtd not registered due to nvmem name collision 496c7c61bd64 afs: Don't unlock fetched data pages until the op completes successfully 17c9595cca71 ubi: Fix seq_file usage in detailed_erase_block_info debugfs file 274cd3c7b5d3 i2c: mux: demux-pinctrl: Fix an error handling path in 'i2c_demux_pinctrl_probe()' dd540f2d7c2d evm: Fix a small race in init_desc() f96ab0d1f3ec iommu/amd: Fix over-read of ACPI UID from IVRS table 33769c19feba i2c: fix missing pm_runtime_put_sync in i2c_device_probe 9f885f17501d ubifs: remove broken lazytime support ac6f94d3be65 fix multiplication overflow in copy_fdtable() 725b0bb0f94d mtd: spinand: Propagate ECC information to the MTD structure e3637eb6a351 ACPI: EC: PM: Avoid flushing EC work when EC GPE is inactive 3be8ece11440 ubifs: fix wrong use of crypto_shash_descsize() 48bbd44f5fa9 ima: Fix return value of ima_write_policy() 1066327bf936 evm: Check also if *tfm is an error pointer in init_desc() 4aedc534b608 ima: Set file->f_mode instead of file->f_flags in ima_calc_file_hash() ac46cea606d5 KVM: SVM: Fix potential memory leak in svm_cpu_init() 1bed86cfe5cb i2c: dev: Fix the race between the release of i2c_dev and cdev
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Creating an initial feature fragment that can be included when a
reproducible kernel build is desired. This is currently only one
option, but will have more in the future.
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com> Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Bruce Ashfield [Fri, 29 May 2020 01:29:17 +0000 (21:29 -0400)]
linux-yocto/5.4: temporarily revert IKHEADERS in standard kernels
We had a commit that enabled IKHEADERS, since bpf requires them on
target.
This is still causing incremental reproducibility errors during the
module compilation phase of the build.
We are temporarily turning this off, so we can integrate -stable
and other related changes. A replacement feature "reproducibility"
is also being added to this can be conditionally enabled while
we debug.
Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>