]> code.ossystems Code Review - bsp/u-boot.git/log
bsp/u-boot.git
14 years agofat: cannot compare bytes and sectors
Sergei Shtylyov [Mon, 8 Aug 2011 09:39:29 +0000 (09:39 +0000)]
fat: cannot compare bytes and sectors

The code multiples the FAT size in sectors by the sector size and then tries to
compare that to the number of sectors in the 'getsize' variable.  While fixing
this, also change the initial value of 'getsize' as the division of FATBUFSIZE
by the sector size gets us FATBUFBLOCKS.

Signed-off-by: Sergei Shtylyov <sshtylyov@mvista.com>
14 years agofat: fix crash with big sector size
Sergei Shtylyov [Mon, 8 Aug 2011 09:38:33 +0000 (09:38 +0000)]
fat: fix crash with big sector size

Apple iPod nanos have sector sizes of 2 or 4 KiB, which crashes U-Boot when it
tries to read the boot sector into 512-byte buffer situated on stack. Make the
FAT code indifferent to the sector size.

Signed-off-by: Sergei Shtylyov <sshtylyov@mvista.com>
14 years agoMerge branch 'sf' of git://git.denx.de/u-boot-blackfin
Wolfgang Denk [Sat, 1 Oct 2011 19:44:07 +0000 (21:44 +0200)]
Merge branch 'sf' of git://git.denx.de/u-boot-blackfin

* 'sf' of git://git.denx.de/u-boot-blackfin:
  sf: eon: add support for EN25Q32B parts
  cmd_sf: add "update" subcommand to do smart SPI flash update

14 years agoMerge branch 'post' of git://git.denx.de/u-boot-blackfin
Wolfgang Denk [Sat, 1 Oct 2011 19:42:21 +0000 (21:42 +0200)]
Merge branch 'post' of git://git.denx.de/u-boot-blackfin

* 'post' of git://git.denx.de/u-boot-blackfin:
  Blackfin: uart: implement loop callback for post
  Blackfin: bf537-stamp/bf548-ezkit: update POST flash block range
  Blackfin: post: generalize led/button tests with GPIOs
  Blackfin: bf537-stamp: drop uart/flash post tests
  Blackfin: post: drop custom test list
  Blackfin: bf537-stamp: convert to gpio post hotkey

14 years agoEfikaSB: Add preliminary EfikaSB support
Marek Vasut [Sun, 25 Sep 2011 09:55:43 +0000 (09:55 +0000)]
EfikaSB: Add preliminary EfikaSB support

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
14 years agoEfikaMX: Add imximage config for Efika SB
Marek Vasut [Sun, 25 Sep 2011 09:52:04 +0000 (09:52 +0000)]
EfikaMX: Add imximage config for Efika SB

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
14 years agoATA: Squash warnings in mxc_ata.
Marek Vasut [Fri, 23 Sep 2011 00:04:49 +0000 (00:04 +0000)]
ATA: Squash warnings in mxc_ata.

mxc_ata.c: In function ‘set_ata_bus_timing’:
mxc_ata.c:118: warning: dereferencing type-punned pointer will break
strict-aliasing rules
mxc_ata.c:125: warning: dereferencing type-punned pointer will break
strict-aliasing rules
mxc_ata.c:129: warning: dereferencing type-punned pointer will break
strict-aliasing rules

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
14 years agovision2: Place machine ID into board config
Fabio Estevam [Fri, 23 Sep 2011 02:50:51 +0000 (02:50 +0000)]
vision2: Place machine ID into board config

Let common code set the machine ID.

Cc: Stefano Babic <sbabic@denx.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Stefano Babic <sbabic@denx.de>
14 years agozmx25: Fix build warning due to 'get_reset_cause' defined but not used
Fabio Estevam [Fri, 23 Sep 2011 05:13:22 +0000 (05:13 +0000)]
zmx25: Fix build warning due to 'get_reset_cause' defined but not used

When building the zmx25 target we get:

Configuring for zmx25 board...
generic.c:108: warning: 'get_reset_cause' defined but not used

Fix this warning by defining get_reset_cause only if CONFIG_DISPLAY_CPUINFO is defined.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Stefano Babic <sbabic@denx.de>
14 years agozmx25: Place machine ID into board config
Fabio Estevam [Fri, 23 Sep 2011 02:50:50 +0000 (02:50 +0000)]
zmx25: Place machine ID into board config

Let common code set the machine ID.

Cc: Matthias Weisser <weisserm@arcor.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agozmx25: Remove dram_init_banksize()
Fabio Estevam [Fri, 23 Sep 2011 02:50:49 +0000 (02:50 +0000)]
zmx25: Remove dram_init_banksize()

As only one RAM bank is used we can rely on the code from arch/arm/lib/board.c

Cc: Matthias Weisser <weisserm@arcor.de>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Stefano Babic <sbabic@denx.de>
14 years agoI2C: mxc_i2c rework
Marek Vasut [Thu, 22 Sep 2011 09:22:12 +0000 (09:22 +0000)]
I2C: mxc_i2c rework

Rewrite the mxc_i2c driver.
 * This version is much closer to Linux implementation.
 * Fixes IPG_PERCLK being incorrectly used as clock source
 * Fixes behaviour of the driver on iMX51
 * Clean up coding style a bit ;-)

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Heiko Schocher <hs@denx.de>
Cc: Jason Hui <jason.hui@linaro.org>
Acked-by: Jason Liu <jason.hui@linro.org>
Acked-by: Heiko Schocher <hs@denx.de>
Tested-by: Jason Liu <jason.hui@linro.org>
14 years agoMX5: Clean up the output of "clocks" command
Marek Vasut [Wed, 14 Sep 2011 14:09:04 +0000 (14:09 +0000)]
MX5: Clean up the output of "clocks" command

The new output looks like this:
> clocks
PLL1            800 MHz
PLL2            665 MHz
PLL3            216 MHz

AHB          133000 kHz
IPG           66500 kHz
IPG PERCLK   665000 kHz

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Acked-by: Stefano Babic <sbabic@denx.de>
Acked-by: Jason Liu <jason.hui@linaro.org>
14 years agoMX5: Add AHB clock reporting and fix IPG clock reporting
Marek Vasut [Thu, 22 Sep 2011 09:20:37 +0000 (09:20 +0000)]
MX5: Add AHB clock reporting and fix IPG clock reporting

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Jason Liu <jason.hui@linaro.org>
Acked-by: Jason Liu <jason.hui@linaro.org>
14 years agoMX5: Modify the PLL decoding algorithm
Marek Vasut [Fri, 23 Sep 2011 09:43:47 +0000 (11:43 +0200)]
MX5: Modify the PLL decoding algorithm

The PLL decoding algorithm didn't take into account many configuration bits.
Adjust it according to Linux kernel. Also, add PLL4 for MX53.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Jason Hui <jason.hui@linaro.org>
Tested-by: Jason Liu <Jason.hui@linaro.org>
14 years agomx53evk: Place machine ID into board config
Fabio Estevam [Thu, 22 Sep 2011 08:07:22 +0000 (08:07 +0000)]
mx53evk: Place machine ID into board config

Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Stefano Babic <sbabic@denx.de>
Acked-by: Jason Liu <jason.hui@linaro.org>
14 years agomx53ard: Place machine ID into board config
Fabio Estevam [Thu, 22 Sep 2011 08:07:21 +0000 (08:07 +0000)]
mx53ard: Place machine ID into board config

Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agomx53smd: Place machine ID into board config
Fabio Estevam [Thu, 22 Sep 2011 08:07:20 +0000 (08:07 +0000)]
mx53smd: Place machine ID into board config

Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agomx53loco: Place machine ID into board config
Fabio Estevam [Thu, 22 Sep 2011 08:07:19 +0000 (08:07 +0000)]
mx53loco: Place machine ID into board config

Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Jason Liu <jason.hui@linaro.org>
14 years agomx51evk: Place machine ID into board config
Fabio Estevam [Thu, 22 Sep 2011 08:07:18 +0000 (08:07 +0000)]
mx51evk: Place machine ID into board config

Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agoimx31_litekit: Place machine ID into board config
Fabio Estevam [Thu, 22 Sep 2011 08:07:17 +0000 (08:07 +0000)]
imx31_litekit: Place machine ID into board config

Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agomx31ads: Place machine ID into board config
Fabio Estevam [Thu, 22 Sep 2011 08:07:16 +0000 (08:07 +0000)]
mx31ads: Place machine ID into board config

Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agomx25pdk: Place machine ID into board config
Fabio Estevam [Thu, 22 Sep 2011 08:07:15 +0000 (08:07 +0000)]
mx25pdk: Place machine ID into board config

Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agomx31pdk: Place machine ID into board config
Fabio Estevam [Thu, 22 Sep 2011 08:07:14 +0000 (08:07 +0000)]
mx31pdk: Place machine ID into board config

Let common code set the machine ID.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agoimx31_litekit: Remove dram_init_banksize()
Fabio Estevam [Thu, 22 Sep 2011 08:07:13 +0000 (08:07 +0000)]
imx31_litekit: Remove dram_init_banksize()

As only one RAM bank is used we can rely on the code from arch/arm/lib/board.c

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agomx31ads: Remove dram_init_banksize()
Fabio Estevam [Thu, 22 Sep 2011 08:07:12 +0000 (08:07 +0000)]
mx31ads: Remove dram_init_banksize()

As only one RAM bank is used we can rely on the code from arch/arm/lib/board.c

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agomx25pdk: Remove dram_init_banksize()
Fabio Estevam [Thu, 22 Sep 2011 08:07:11 +0000 (08:07 +0000)]
mx25pdk: Remove dram_init_banksize()

As only one RAM bank is used we can rely on the code from arch/arm/lib/board.c

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agomx31pdk: Remove dram_init_banksize()
Fabio Estevam [Thu, 22 Sep 2011 08:07:10 +0000 (08:07 +0000)]
mx31pdk: Remove dram_init_banksize()

As only one RAM bank is used we can rely on the code from arch/arm/lib/board.c

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agoFEC: Move imx_get_mac_from_fuse() definition to fec_mxc.h
Marek Vasut [Sun, 11 Sep 2011 18:05:39 +0000 (18:05 +0000)]
FEC: Move imx_get_mac_from_fuse() definition to fec_mxc.h

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Squish "got MAC from fuse" message, make it debug()
Marek Vasut [Sun, 11 Sep 2011 18:05:38 +0000 (18:05 +0000)]
FEC: Squish "got MAC from fuse" message, make it debug()

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Add timeout for chip reset
Marek Vasut [Sun, 11 Sep 2011 18:05:37 +0000 (18:05 +0000)]
FEC: Add timeout for chip reset

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Allow registering MII postconfiguration callback
Marek Vasut [Sun, 11 Sep 2011 18:05:36 +0000 (18:05 +0000)]
FEC: Allow registering MII postconfiguration callback

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Allow multiple FECes
Marek Vasut [Thu, 15 Sep 2011 23:13:47 +0000 (01:13 +0200)]
FEC: Allow multiple FECes

This patch allows user to register multiple FEC controllers. To preserve
compatibility with older boards, the mxcfec_register() call is still in place.
To use multiple controllers, new macro is in place, the mxcfec_register_multi(),
which takes more arguments. The syntax is:

mxcfec_register_multi(bd, FEC ID, FEC PHY ID on the MII bus, base address);

To disable the fecmxc_register() compatibility stuff, define the macro
CONFIG_FEC_MXC_MULTI. This will remove the requirement for defining IMX_FEC_BASE
and CONFIG_FEC_MXC_PHYADDR.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Abstract access to fec->eth in MII operations
Marek Vasut [Sun, 11 Sep 2011 18:05:34 +0000 (18:05 +0000)]
FEC: Abstract access to fec->eth in MII operations

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Allow selection of MII mode via CONFIG_FEC_XCV_TYPE
Marek Vasut [Sun, 11 Sep 2011 18:05:33 +0000 (18:05 +0000)]
FEC: Allow selection of MII mode via CONFIG_FEC_XCV_TYPE

The default is MII100, which was hardcoded previously in the driver.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Add RMII mode support
Marek Vasut [Sun, 11 Sep 2011 18:05:32 +0000 (18:05 +0000)]
FEC: Add RMII mode support

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Kill mode select FIXME's
Marek Vasut [Sun, 11 Sep 2011 18:05:31 +0000 (18:05 +0000)]
FEC: Kill mode select FIXME's

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Use defined constant instead of magic number
Marek Vasut [Sun, 11 Sep 2011 18:05:30 +0000 (18:05 +0000)]
FEC: Use defined constant instead of magic number

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agoFEC: Use proper accessor to read register in debug call
Marek Vasut [Sun, 11 Sep 2011 18:05:29 +0000 (18:05 +0000)]
FEC: Use proper accessor to read register in debug call

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Cc: Ben Warren <biggerbadderben@gmail.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Detlev Zundel <dzu@denx.de>
14 years agocosmetic: fsl_pmic: cosmetic for the help message
Jason Liu [Wed, 21 Sep 2011 19:30:53 +0000 (19:30 +0000)]
cosmetic: fsl_pmic: cosmetic for the help message

This is cosmetic patch for the help message:

Before:
pmic dump [numregs] dump registers
After:
pmic dump [numregs] - dump registers

Signed-off-by: Jason Liu <jason.hui@linaro.org>
Acked-by: Stefano Babic <sbabic@denx.de>
14 years agoEfikaMX: Adjust undocumented magic constant in config file
Marek Vasut [Wed, 14 Sep 2011 18:16:57 +0000 (18:16 +0000)]
EfikaMX: Adjust undocumented magic constant in config file

This magic constant with zero documentation, when it's last 8 bits are set to
0x45, configures correctly the PERCLK dividers. Therefore the I2C operates
correctly when divider computed from PERCLK.

Note: This constant is written to CBCDR register in
arch/arm/cpu/armv7/mx5/lowlevel_init.S, but it's written only once. The register
is accessed three more times in the file, with different values written to it
each time.

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
14 years agoMX31: Disable watchdog during low-power modes
Fabio Estevam [Wed, 21 Sep 2011 03:29:17 +0000 (03:29 +0000)]
MX31: Disable watchdog during low-power modes

Turn on the watchdog WDZST bit so that watchdog timer does not count during low power modes.

Prior to applying this patch mx31pdk board got watchdog resets because when it booted in the Linux prompt
and there was no activity, the system entered into idle mode while watchdog timer was still active.

Fix this by disabling watchdog timer during idle mode.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agoMX25: Add initial support for MX25PDK
Fabio Estevam [Tue, 6 Sep 2011 09:05:43 +0000 (09:05 +0000)]
MX25: Add initial support for MX25PDK

Add the initial support for MX25PDK booting from SD card via internal boot.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agoMX25: tx25: Avoid the usage of extern in C file
Fabio Estevam [Tue, 6 Sep 2011 09:05:42 +0000 (09:05 +0000)]
MX25: tx25: Avoid the usage of extern in C file

Avoid the usage of extern in C file as pointed out by checkpatch.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agomx31pdk: Change the prompt as per other i.MX boards
Fabio Estevam [Thu, 15 Sep 2011 13:18:23 +0000 (13:18 +0000)]
mx31pdk: Change the prompt as per other i.MX boards

Change the prompt as done in other i.MX boards.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agoMX31: Improve readability for reset cause
Fabio Estevam [Fri, 16 Sep 2011 04:01:22 +0000 (04:01 +0000)]
MX31: Improve readability for reset cause

Currently the reset cause is printed like:
CPU:   Freescale i.MX31 rev 2.0 at 531 MHz.Reset cause: POR

Improve readability by adding a new line like it is done on other i.MX boards.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agoMX31: mx31pdk: Remove nand_spl config.mk file
Fabio Estevam [Mon, 5 Sep 2011 08:55:12 +0000 (08:55 +0000)]
MX31: mx31pdk: Remove nand_spl config.mk file

No need to have a config.mk to only store a single line.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Stefano Babic <sbabic@denx.de>
14 years agoARM: mx25: Print the source of reset
Fabio Estevam [Fri, 2 Sep 2011 05:38:55 +0000 (05:38 +0000)]
ARM: mx25: Print the source of reset

Print the source of reset during boot.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agoARM: mx25: Print the silicon revison
Fabio Estevam [Fri, 2 Sep 2011 05:38:54 +0000 (05:38 +0000)]
ARM: mx25: Print the silicon revison

Print the silicon revison during boot.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
14 years agoarm, davinci, da8xx: add cpuinfo
Heiko Schocher [Wed, 14 Sep 2011 19:59:39 +0000 (19:59 +0000)]
arm, davinci, da8xx: add cpuinfo

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci, am1808: add lowlevel functions for booting from NOR
Heiko Schocher [Wed, 14 Sep 2011 19:59:38 +0000 (19:59 +0000)]
arm, davinci, am1808: add lowlevel functions for booting from NOR

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci: add NOR Boot Configuration Word
Heiko Schocher [Wed, 14 Sep 2011 19:59:37 +0000 (19:59 +0000)]
arm, davinci: add NOR Boot Configuration Word

to add the "NOR Boot Configuration Word" on AM18xx based boards,
define CONFIG_SYS_DV_NOR_BOOT_CFG.

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci: add ddr2 definition
Heiko Schocher [Wed, 14 Sep 2011 19:59:36 +0000 (19:59 +0000)]
arm, davinci: add ddr2 definition

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci, am1808, gpio: add missing defines for bank 8
Heiko Schocher [Wed, 14 Sep 2011 19:59:35 +0000 (19:59 +0000)]
arm, davinci, am1808, gpio: add missing defines for bank 8

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci: add some missing defines in hardware.h
Heiko Schocher [Wed, 14 Sep 2011 19:59:34 +0000 (19:59 +0000)]
arm, davinci: add some missing defines in hardware.h

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci: add SYSCFG1 base and register struct
Heiko Schocher [Wed, 14 Sep 2011 19:59:33 +0000 (19:59 +0000)]
arm, davinci: add SYSCFG1 base and register struct

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agortc, davinci: add support for davinci internal RTC
Heiko Schocher [Wed, 14 Sep 2011 19:48:23 +0000 (19:48 +0000)]
rtc, davinci: add support for davinci internal RTC

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci: add RTC base addr
Heiko Schocher [Wed, 14 Sep 2011 19:48:22 +0000 (19:48 +0000)]
arm, davinci: add RTC base addr

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci: add internal WDT support for AM1808 cpus
Heiko Schocher [Wed, 14 Sep 2011 19:44:02 +0000 (19:44 +0000)]
arm, davinci: add internal WDT support for AM1808 cpus

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci: add missing timer baseaddresses for !DA8xx cpu
Heiko Schocher [Wed, 14 Sep 2011 19:44:01 +0000 (19:44 +0000)]
arm, davinci: add missing timer baseaddresses for !DA8xx cpu

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoarm, davinci: move davinci_timer in header file
Heiko Schocher [Wed, 14 Sep 2011 19:44:00 +0000 (19:44 +0000)]
arm, davinci: move davinci_timer in header file

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agonet, davinci_emac: let the EMAC detect the PHYs
Heiko Schocher [Wed, 14 Sep 2011 19:37:42 +0000 (19:37 +0000)]
net, davinci_emac: let the EMAC detect the PHYs

Once the MDIO state machine has been initialized and enabled, it
starts polling all 32 PHY addresses on the MDIO bus, looking for
an active PHY. Add a 5 ms delay, so all PHYs are for sure detected.

This problem was detected on the cmc board with a KSZ8864 switch.

Signed-off-by: Heiko Schocher <hs@denx.de>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agonet, davinci_emac: make less verbose - turn printf() into debug()
Heiko Schocher [Wed, 14 Sep 2011 19:22:57 +0000 (19:22 +0000)]
net, davinci_emac: make less verbose - turn printf() into debug()

The PHY driver was too verbose and corrupted the boot message display
like this:

...
Net:   Ethernet PHY: KSZ8873 @ 0x02
DaVinci-EMAC
...

Turn printf() into debug() so we get the expected output again:

...
Net:   DaVinci-EMAC
...

Signed-off-by: Heiko Schocher <hs@denx.de>
cc: Paulraj Sandeep <s-paulraj@ti.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agonet, davinci_emac: add KSZ8864 switch
Heiko Schocher [Sun, 18 Sep 2011 19:49:25 +0000 (19:49 +0000)]
net, davinci_emac: add KSZ8864 switch

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Cc: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoi2c, davinci: add i2c set speed
Heiko Schocher [Wed, 14 Sep 2011 19:25:12 +0000 (19:25 +0000)]
i2c, davinci: add i2c set speed

Signed-off-by: Heiko Schocher <hs@denx.de>
Cc: Paulraj Sandeep <s-paulraj@ti.com>
Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoDevkit8000: Change console from ttyS2 to ttyO2
Thomas Weber [Sun, 18 Sep 2011 22:43:58 +0000 (22:43 +0000)]
Devkit8000: Change console from ttyS2 to ttyO2

The omap serial names have changed from ttySx to ttyOx,
so the console should be also changed to support this.

Signed-off-by: Thomas Weber <weber@corscience.de>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoomap4: update maintainer for omap4 boards
Aneesh V [Fri, 23 Sep 2011 01:06:17 +0000 (01:06 +0000)]
omap4: update maintainer for omap4 boards

Steve wants to transfer maintainership of OMAP4 boards
to me as he is not working on these boards lately.

CC: Steve Sakoman <steve@sakoman.com>
CC: Sandeep Paulraj <s-paulraj@ti.com>
CC: Albert Aribaud <albert.u.boot@aribaud.net>
CC: Wolfgang Denk <wd@denx.de>
Signed-off-by: Aneesh V <aneesh@ti.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoomap3evm: env: Fix default console
Sanjeev Premi [Fri, 23 Sep 2011 05:25:28 +0000 (05:25 +0000)]
omap3evm: env: Fix default console

Change the default console from ttyS2 to ttyO0 to
match the Linux default for the EVM.

Signed-off-by: Sanjeev Premi <premi@ti.com>
Cc: Sandeep Paulraj <s-paulraj@ti.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoomap3: Fix compile warning
Sanjeev Premi [Fri, 23 Sep 2011 05:29:45 +0000 (05:29 +0000)]
omap3: Fix compile warning

Building without option CONFIG_DISPLAY_CPUINFO leads to
this warning:
sys_info.c:50:14: warning: 'rev_s_37xx' defined but not used

Signed-off-by: Sanjeev Premi <premi@ti.com>
Cc: Sandeep Paulraj <s-paulraj@ti.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agommc: omap: config VMMC, MMC1_PBIAS
Balaji T K [Thu, 8 Sep 2011 06:34:57 +0000 (06:34 +0000)]
mmc: omap: config VMMC, MMC1_PBIAS

Config VMMC voltage to 3V for MMC/SD card slot
and PBIAS settings needed for OMAP4
Fixes MMC/SD detection on boot from eMMC.

Signed-off-by: Balaji T K <balajitk@ti.com>
Signed-off-by: Aneesh V <aneesh@ti.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agommc: omap: enable high capacity
Balaji T K [Thu, 25 Aug 2011 04:46:51 +0000 (04:46 +0000)]
mmc: omap: enable high capacity

Enable high capacity to host capability.
Fixes eMMC detection on boot from MMC/SD card.

Signed-off-by: Balaji T K <balajitk@ti.com>
Signed-off-by: Aneesh V <aneesh@ti.com>
Acked-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agodevkit8000: Fix build break
Sandeep Paulraj [Fri, 16 Sep 2011 16:35:00 +0000 (12:35 -0400)]
devkit8000: Fix build break

Found a build erros when i ran MAKEALL.
So fix it.

Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoomap-common: reorganize spl.c
Simon Schwarz [Wed, 14 Sep 2011 19:33:34 +0000 (15:33 -0400)]
omap-common: reorganize spl.c

split-up spl.c into spl.c, spl_mmc.c and spl_nand.c. This avoids problems
with missing defines if a board does not use mmc or nand. This includes
adding spl_ prefix to some functions which are now public. spl_image_t is now
a public type. Added some of the common functions to omap-common.h

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoomap3: implement boot parameter saving
Simon Schwarz [Wed, 14 Sep 2011 19:32:57 +0000 (15:32 -0400)]
omap3: implement boot parameter saving

Implements the saving of boot params passed by OMAP3 ROM code.

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agodevkit8000: Add nand-spl support for new SPL
Simon Schwarz [Wed, 14 Sep 2011 19:32:17 +0000 (15:32 -0400)]
devkit8000: Add nand-spl support for new SPL

Add NAND SPL support to the devkit8000 config

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoomap3: new SPL structure support
Simon Schwarz [Wed, 14 Sep 2011 19:31:33 +0000 (15:31 -0400)]
omap3: new SPL structure support

Support for the new spl structure. Using the interface defined by Aneesh V for
OMAP4

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agospl: Add POWER library to new spl
Simon Schwarz [Wed, 14 Sep 2011 19:30:54 +0000 (15:30 -0400)]
spl: Add POWER library to new spl

Adds power library to the new spl

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agospl: add NAND Library to new SPL
Simon Schwarz [Wed, 14 Sep 2011 19:30:16 +0000 (15:30 -0400)]
spl: add NAND Library to new SPL

Adds NAND library to SPL.

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Acked-by: Scott Wood <scottwood@freescale.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoomap-common: add nand spl support
Simon Schwarz [Wed, 14 Sep 2011 19:29:26 +0000 (15:29 -0400)]
omap-common: add nand spl support

Add NAND support for the new SPL structure.

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoomap3: Configure RAM bank 0 if in SPL
Simon Schwarz [Wed, 14 Sep 2011 19:15:37 +0000 (15:15 -0400)]
omap3: Configure RAM bank 0 if in SPL

OMAP3 relied on the memory config done by X-loader or Configuration Header. This
has to be reworked for the implementation of a SPL. This patch configures RAM
bank 0 if CONFIG_SPL_BUILD is set. Settings for Micron-RAM used by devkit8000
are added to mem.h

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoomap-common/omap4: relocate early UART clock setup
Simon Schwarz [Wed, 14 Sep 2011 19:14:46 +0000 (15:14 -0400)]
omap-common/omap4: relocate early UART clock setup

Moves the early UART clock setup setup_clocks_for_console() from
preloader_console_init() to s_init() of OMAP4.

This is done to prepare for OMAP3 integration.

This patch was posted seperatly to the mailinglist but I decidet - since it is
a prereqesit for this patch to add it. Former port to ML:
http://article.gmane.org/gmane.comp.boot-loaders.u-boot/104395

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Signed-off-by: Tom Rini <trini@ti.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoovero: Set IEN on GPMC_CLK to support synchronous clocking.
Philip Balister [Wed, 14 Sep 2011 16:50:12 +0000 (12:50 -0400)]
overo: Set IEN on GPMC_CLK to support synchronous clocking.

Without this change CS's configured for synchronous clocking cannot
read data.

Signed-off-by: Philip Balister <philip@opensdr.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoOMAP3: Overo: Update GPMC timing for ethernet chip
Philip Balister [Wed, 14 Sep 2011 17:32:22 +0000 (13:32 -0400)]
OMAP3: Overo: Update GPMC timing for ethernet chip

The existing timing does not quite meet the minimum requirements
in the LAN9221 datasheet. The timing in this patch solves problems
noticed on some parts. The patch also combines the CS configuration
for the overo and igep0020 boards per request.

Signed-off-by: Philip Balister <philip@opensdr.com>
Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
14 years agoArmada100: Enable 88E3015 PHY support for GplugD
Ajay Bhargav [Tue, 13 Sep 2011 16:52:13 +0000 (22:22 +0530)]
Armada100: Enable 88E3015 PHY support for GplugD

This patch adds support for 88E3015 PHY for Marvell GplugD board.
This patch depends on series of patch which adds support for Marvell
GuruPlug-Display.

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
14 years agoArmada100: Enable Ethernet support for GplugD
Ajay Bhargav [Tue, 13 Sep 2011 16:52:04 +0000 (22:22 +0530)]
Armada100: Enable Ethernet support for GplugD

This patch enables ethernet support for Marvell GplugD board. Network
related commands works.

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
14 years agonet: Adds Fast Ethernet Controller driver for Armada100
Ajay Bhargav [Tue, 13 Sep 2011 16:51:58 +0000 (22:21 +0530)]
net: Adds Fast Ethernet Controller driver for Armada100

This patch adds support for Fast Ethernet Controller driver for
Armada100 series.

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
14 years agoomap4_panda: Ignore omap4 SPL called MLO
Joe Hershberger [Tue, 9 Aug 2011 19:21:50 +0000 (19:21 +0000)]
omap4_panda: Ignore omap4 SPL called MLO

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
Cc: Sandeep Paulraj <s-paulraj@ti.com>
14 years agogpio: Add GPIO driver for Marvell SoC Armada100
Ajay Bhargav [Mon, 22 Aug 2011 12:27:38 +0000 (17:57 +0530)]
gpio: Add GPIO driver for Marvell SoC Armada100

This patch adds support for generic GPIO driver framework for Marvell
SoC Armada100.

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
14 years agogpio: Add GPIO driver framework for Marvell SoCs
Ajay Bhargav [Mon, 22 Aug 2011 12:27:38 +0000 (17:57 +0530)]
gpio: Add GPIO driver framework for Marvell SoCs

This patch adds generic GPIO driver framework support for Marvell SoCs.

To enable GPIO driver define CONFIG_MARVELL_GPIO and for GPIO commands
define CONFIG_CMD_GPIO in your board configuration file.

Signed-off-by: Ajay Bhargav <ajay.bhargav@einfochips.com>
14 years agopowerpc/mpc8349emds: Migrate from spd_sdram to unified DDR driver
York Sun [Fri, 26 Aug 2011 18:32:45 +0000 (11:32 -0700)]
powerpc/mpc8349emds: Migrate from spd_sdram to unified DDR driver

Update MPC8349EMDS to use unified DDR driver instead of spd_sdram.c.
The unified driver can initialize data using DDR controller. No need to
use DMA if just to initialze for ECC.

Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver
York Sun [Fri, 26 Aug 2011 18:32:44 +0000 (11:32 -0700)]
powerpc/mpc83xx: Migrate from spd_sdram to unified DDR driver

Unified DDR driver is maintained for better performance, robustness and bug
fixes. Upgrading to use unified DDR driver for MPC83xx takes advantage of
overall improvement. It requires changes for board files to customize
platform-dependent parameters.

To utilize the unified DDR driver, a board needs to define CONFIG_FSL_DDRx
in the header file. No more boards will be accepted without such definition.

Note: the workaround for erratum DDR6 for the very old MPC834x Rev 1.0/1.1
and MPC8360 Rev 1.1/1.2 parts is not migrated to unified driver.

Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/mpc8xxx: Add DDR2 to unified DDR driver
York Sun [Fri, 26 Aug 2011 18:32:43 +0000 (11:32 -0700)]
powerpc/mpc8xxx: Add DDR2 to unified DDR driver

DDR2 has different ODT table and values. Adding table according to Samsung
application note.

Fix additive latency calculation to avoid interger underflow.

Also converted typedef dynamic_odt_t to struct dynamic_odt.

Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/mpc8xxx: Fix picos_to_mclk() and get_memory_clk_period_ps()
York Sun [Fri, 26 Aug 2011 18:32:42 +0000 (11:32 -0700)]
powerpc/mpc8xxx: Fix picos_to_mclk() and get_memory_clk_period_ps()

Reduce the calculation error to 1ps.

Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/mpc8xxx: Add SPD EEPROM address for single controller 2 slots
York Sun [Fri, 26 Aug 2011 18:32:41 +0000 (11:32 -0700)]
powerpc/mpc8xxx: Add SPD EEPROM address for single controller 2 slots

The two slots on the same controller have different addresses.

Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/mpc8xxx: Fix DDR code for empty first DIMM slot and enable DQS_en
York Sun [Fri, 26 Aug 2011 18:32:40 +0000 (11:32 -0700)]
powerpc/mpc8xxx: Fix DDR code for empty first DIMM slot and enable DQS_en

Check second DIMM slot in case the first one is empty.
Honor DQS enable option for SDRAM mode register.

Signed-off-by: York Sun <yorksun@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/85xx: Refactor P2041RDB to use common p_corenet files
Kumar Gala [Tue, 30 Aug 2011 22:40:11 +0000 (17:40 -0500)]
powerpc/85xx: Refactor P2041RDB to use common p_corenet files

The P2041RDB has almost identical setup for TLB, LAWS, and PCI with
other P-Series CoreNet platforms.

The only difference between P2041RDB & P3041DS/P4080DS/P5020DS is the
CPLD vs PIXIS FPGA which we can handle via some simple #ifdefs in the
TLB and LAW setup tables.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/85xx: refactor common P-Series CoreNet files for FSL boards
Kumar Gala [Tue, 30 Aug 2011 22:29:23 +0000 (17:29 -0500)]
powerpc/85xx: refactor common P-Series CoreNet files for FSL boards

We currently support 4 SoC/Boards from the P-Series of QorIQ SoCs that
are based on the 'CoreNet' Architecture: P2041RDB, P3041DS, P4080DS, and
P5020DS.  There is a significant amount of commonality shared between
these boards that we can refactor into common code:

* Initial LAW setup
* Initial TLB setup
* PCI setup

We start by moving the shared code between P3041DS, P4080DS, and P5020DS
into a common directory to be shared with other P-Series CoreNet boards.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/85xx: Enable CMD_REGINFO on corenet boards
Kumar Gala [Wed, 31 Aug 2011 14:16:02 +0000 (09:16 -0500)]
powerpc/85xx: Enable CMD_REGINFO on corenet boards

Useful for various debug to know how various regsters might be set
in a human readable form.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/85xx: p2041rdb - Remove unused 'execute' perm in TLB entries
Kumar Gala [Tue, 30 Aug 2011 13:42:34 +0000 (08:42 -0500)]
powerpc/85xx: p2041rdb - Remove unused 'execute' perm in TLB entries

We shouldn't be setting execute permissions on TLB entries that will not
actually have any code run from them.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
14 years agopowerpc/85xx: Fix USB protocol definitions for P1020RDB
Ramneek Mehresh [Wed, 24 Aug 2011 13:52:44 +0000 (19:22 +0530)]
powerpc/85xx: Fix USB protocol definitions for P1020RDB

USB protocol macros (CONFIG_USB_EHCI ...) to be included only when
CONFIG_HAS_FSL_DR_USB is defined for a board. Presence of USB DR controller
should be declared along with the underlying protocol used in the controller

Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>