]> code.ossystems Code Review - openembedded-core.git/commit
archiver.bbclass: enhance do_ar_recipe task signature
authorPatrick Ohly <patrick.ohly@intel.com>
Thu, 4 May 2017 14:42:41 +0000 (16:42 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 18 May 2017 13:01:37 +0000 (14:01 +0100)
commit9666f0e0b02efc14226c77497fd38f79fc372f98
tree424038a944cd30ba1f92cc2ee079027dbf2dad91
parent2513edb9a804205480b8fbe11e0c289f283627b0
archiver.bbclass: enhance do_ar_recipe task signature

Previously, do_ar_recipe ran again unnecessarily when adding or
removing classes like buildhistory.bbclass, because that changes the
BBINCLUDED variable which do_ar_recipe uses to find .bbappend files.

This is both extra work and also sometimes triggered "basehash
changed" errors (seen under oe-selftest, which adds machine.inc and
bblayers.inc) because BBINCLUDED is special and does not cause
the basehash to be recalculated.

The file *content* already was not considered in the task signature,
instead relying indirectly on PF (which includes the revision assigned
by a PR server) to ensure that a new versioned source archive gets
created each time there is a rebuild.

Therefore it makes sense to use the same mechanism and also ignore the
file *list*, i.e. exclude BBINCLUDED from the task signature.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/archiver.bbclass