]> code.ossystems Code Review - openembedded-core.git/commit
icu: make filtered data generation optional, serial and off by default
authorAlexander Kanavin <alex.kanavin@gmail.com>
Tue, 23 Jun 2020 21:08:37 +0000 (23:08 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 25 Jun 2020 09:23:33 +0000 (10:23 +0100)
commitdf89e8d1136fd406ba35ae573e2cb0cfc88c6aad
tree3c0e12b2db0f6bdbd6fd8b2f7a5a297f8f1e8c2d
parente8faa3416bc85dab7e7e638448dcb11ff88354a3
icu: make filtered data generation optional, serial and off by default

icu data generation was found to be racy, and causig AB failures;
making it serial and leaving it on is not an option as it regresses
to several minutes.

The specific bug is that rules.mk has:

LD_LIBRARY_PATH=../lib:../stubdata:../tools/ctestfw:$LD_LIBRARY_PATH  ../bin/gencnval -s . -d ./out/build/icudt66l mappings/convrtrs.txt

which creates a file and numerous rules like

LD_LIBRARY_PATH=../lib:../stubdata:../tools/ctestfw:$LD_LIBRARY_PATH  ../bin/genrb -s ./misc -d ./out/build/icudt67l -i ./out/build/icudt67l -k -q numberingSystems.txt

which quietly read it. There is no prerequisite for the former to complete first.

The race is extra complicated to fix as rules.mk is itself
generated through a custom in-tree python tool.

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-support/icu/icu_67.1.bb